From: Chris Ball <cjb@laptop.org>
To: Trey Ramsay <tramsay@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Rich Rattanni <rattanni@gmail.com>,
Radovan Lekanovic <lekanovic@gmail.com>
Subject: Re: [PATCH 1/1] mmc: Bad device can cause mmc driver to hang
Date: Sat, 17 Nov 2012 09:34:50 -0500 [thread overview]
Message-ID: <87ehjs9u2d.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1353079901-8773-1-git-send-email-tramsay@linux.vnet.ibm.com> (Trey Ramsay's message of "Fri, 16 Nov 2012 09:31:41 -0600")
Hi,
On Fri, Nov 16 2012, Trey Ramsay wrote:
> There are infinite loops in the mmc code that can be caused by bad hardware.
> The code will loop forever if the device never comes back from program mode,
> R1_STATE_PRG, and it is not ready for data, R1_READY_FOR_DATA.
>
> A long timeout will be added to prevent the code from looping forever.
> The timeout will occur if the device never comes back from program
> state or the device never becomes ready for data.
>
> Signed-off-by: Trey Ramsay <tramsay@linux.vnet.ibm.com>
Thanks for doing this; pushed to mmc-next for 3.8.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Trey Ramsay <tramsay@linux.vnet.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
Rich Rattanni <rattanni@gmail.com>,
Radovan Lekanovic <lekanovic@gmail.com>
Subject: Re: [PATCH 1/1] mmc: Bad device can cause mmc driver to hang
Date: Sat, 17 Nov 2012 09:34:50 -0500 [thread overview]
Message-ID: <87ehjs9u2d.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1353079901-8773-1-git-send-email-tramsay@linux.vnet.ibm.com> (Trey Ramsay's message of "Fri, 16 Nov 2012 09:31:41 -0600")
Hi,
On Fri, Nov 16 2012, Trey Ramsay wrote:
> There are infinite loops in the mmc code that can be caused by bad hardware.
> The code will loop forever if the device never comes back from program mode,
> R1_STATE_PRG, and it is not ready for data, R1_READY_FOR_DATA.
>
> A long timeout will be added to prevent the code from looping forever.
> The timeout will occur if the device never comes back from program
> state or the device never becomes ready for data.
>
> Signed-off-by: Trey Ramsay <tramsay@linux.vnet.ibm.com>
Thanks for doing this; pushed to mmc-next for 3.8.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-11-17 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 19:36 drivers/mmc/card/block.c infinite loop in mmc_blk_err_check waiting on R1_READY_FOR_DATA Trey Ramsay
2012-10-31 20:47 ` Chris Ball
[not found] ` <50A2A08D.5000601@linux.vnet.ibm.com>
2012-11-13 20:48 ` Chris Ball
2012-11-16 15:31 ` [PATCH 1/1] mmc: Bad device can cause mmc driver to hang Trey Ramsay
2012-11-16 15:31 ` Trey Ramsay
2012-11-16 15:37 ` Chris Ball
2012-11-16 15:37 ` Chris Ball
2012-11-16 23:52 ` Trey Ramsay
2012-11-17 0:37 ` Chris Ball
2012-11-17 5:16 ` Trey Ramsay
2012-11-17 0:40 ` Trey Ramsay
2012-11-17 14:34 ` Chris Ball [this message]
2012-11-17 14:34 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehjs9u2d.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=lekanovic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rattanni@gmail.com \
--cc=tramsay@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.