* [Qemu-trivial] [PATCH] ioh3420: Remove unreachable code
@ 2012-09-01 10:56 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2012-09-01 10:56 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
Report from smatch:
hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/ioh3420.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ioh3420.c b/hw/ioh3420.c
index 94a537c..4d31473 100644
--- a/hw/ioh3420.c
+++ b/hw/ioh3420.c
@@ -125,7 +125,6 @@ static int ioh3420_initfn(PCIDevice *d)
rc = pcie_chassis_add_slot(s);
if (rc < 0) {
goto err_pcie_cap;
- return rc;
}
pcie_cap_root_init(d);
rc = pcie_aer_init(d, IOH_EP_AER_OFFSET);
--
1.7.10
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] ioh3420: Remove unreachable code
@ 2012-09-01 10:56 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2012-09-01 10:56 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
Report from smatch:
hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/ioh3420.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ioh3420.c b/hw/ioh3420.c
index 94a537c..4d31473 100644
--- a/hw/ioh3420.c
+++ b/hw/ioh3420.c
@@ -125,7 +125,6 @@ static int ioh3420_initfn(PCIDevice *d)
rc = pcie_chassis_add_slot(s);
if (rc < 0) {
goto err_pcie_cap;
- return rc;
}
pcie_cap_root_init(d);
rc = pcie_aer_init(d, IOH_EP_AER_OFFSET);
--
1.7.10
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] ioh3420: Remove unreachable code
2012-09-01 10:56 ` [Qemu-devel] " Stefan Weil
@ 2012-09-02 20:31 ` Juan Quintela
-1 siblings, 0 replies; 6+ messages in thread
From: Juan Quintela @ 2012-09-02 20:31 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
Stefan Weil <sw@weilnetz.de> wrote:
> Report from smatch:
> hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] ioh3420: Remove unreachable code
2012-09-01 10:56 ` [Qemu-devel] " Stefan Weil
@ 2012-09-22 15:41 ` Stefan Hajnoczi
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2012-09-22 15:41 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Sat, Sep 01, 2012 at 12:56:03PM +0200, Stefan Weil wrote:
> Report from smatch:
> hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/ioh3420.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-22 15:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-01 10:56 [Qemu-trivial] [PATCH] ioh3420: Remove unreachable code Stefan Weil
2012-09-01 10:56 ` [Qemu-devel] " Stefan Weil
2012-09-02 20:31 ` [Qemu-trivial] " Juan Quintela
2012-09-02 20:31 ` [Qemu-devel] " Juan Quintela
2012-09-22 15:41 ` [Qemu-trivial] " Stefan Hajnoczi
2012-09-22 15:41 ` [Qemu-devel] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.