From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Ren Mingxin <renmx@cn.fujitsu.com>
Cc: kvm@vger.kernel.org, linux-scsi@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org, jens.axboe@oracle.com,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] virtio_blk: add helper function to support mass of disks naming
Date: Thu, 29 Mar 2012 15:10:01 +1030 [thread overview]
Message-ID: <87ehscyq8u.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120328105819.GD6194@redhat.com>
On Wed, 28 Mar 2012 12:58:21 +0200, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote:
> > Hi,
> >
> > The current virtblk's naming algorithm just supports 26^3
> > disks. If there are mass of virtblks(exceeding 26^3), there
> > will be disks with the same name.
> >
> > According to "sd_format_disk_name()", I add function
> > "virtblk_name_format()" for virtblk to support mass of
> > disks.
> >
> > Signed-off-by: Ren Mingxin <renmx@cn.fujitsu.com>
>
> Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe
> did. Except, maybe we should move this function into block core
> instead of duplicating it? Where would be a good place to put it?
> Jens, care to comment?
Indeed.
Cheers,
Rusty.
--
How could I marry someone with more hair than me? http://baldalex.org
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Ren Mingxin <renmx@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
jens.axboe@oracle.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: add helper function to support mass of disks naming
Date: Thu, 29 Mar 2012 15:10:01 +1030 [thread overview]
Message-ID: <87ehscyq8u.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120328105819.GD6194@redhat.com>
On Wed, 28 Mar 2012 12:58:21 +0200, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote:
> > Hi,
> >
> > The current virtblk's naming algorithm just supports 26^3
> > disks. If there are mass of virtblks(exceeding 26^3), there
> > will be disks with the same name.
> >
> > According to "sd_format_disk_name()", I add function
> > "virtblk_name_format()" for virtblk to support mass of
> > disks.
> >
> > Signed-off-by: Ren Mingxin <renmx@cn.fujitsu.com>
>
> Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe
> did. Except, maybe we should move this function into block core
> instead of duplicating it? Where would be a good place to put it?
> Jens, care to comment?
Indeed.
Cheers,
Rusty.
--
How could I marry someone with more hair than me? http://baldalex.org
next prev parent reply other threads:[~2012-03-29 4:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:54 [PATCH] virtio_blk: add helper function to support mass of disks naming Ren Mingxin
2012-03-28 10:58 ` Michael S. Tsirkin
2012-03-28 10:58 ` Michael S. Tsirkin
2012-03-29 4:40 ` Rusty Russell [this message]
2012-03-29 4:40 ` Rusty Russell
2012-03-29 5:36 ` Ren Mingxin
2012-03-29 5:36 ` Ren Mingxin
2012-03-29 12:03 ` Jens Axboe
2012-03-29 12:03 ` Jens Axboe
2012-03-29 12:46 ` Michael S. Tsirkin
2012-03-29 12:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehscyq8u.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jens.axboe@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@redhat.com \
--cc=renmx@cn.fujitsu.com \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.