Re: [PATCH] ARM: OMAP3+: PM debug: fix the use of debugfs_create_* API

[Kevin Hilman <khilman@ti.com>]

Jean Pihet <jean.pihet@newoldbits.com> writes:

> The debugfs_create_* API returns a NULL ptr in case of problem.
> Fix the PM debug code to take this into account.
>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> ---
>  arch/arm/mach-omap2/pm-debug.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
> index 4411163..e5bf367 100644
> --- a/arch/arm/mach-omap2/pm-debug.c
> +++ b/arch/arm/mach-omap2/pm-debug.c
> @@ -264,8 +264,8 @@ static int __init pm_dbg_init(void)
>  		return 0;
>  
>  	d = debugfs_create_dir("pm_debug", NULL);
> -	if (IS_ERR(d))
> -		return PTR_ERR(d);
> +	if (!d)

I think this should be IS_ERR_OR_NULL() because this function can also
return ERR_PTR(-ENODEV).  (Yes, only when debugfs is not enabled, but
it's still more correct.)

Kevin

> +		return -ENOMEM;
>  	(void) debugfs_create_file("count", S_IRUGO,
>  		d, (void *)DEBUG_FILE_COUNTERS, &debug_fops);