All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: "Pedanekar, Hemant" <hemantp@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v2 5/6] TI81XX: Add minimal hwmod data
Date: Thu, 08 Sep 2011 10:30:49 -0700	[thread overview]
Message-ID: <87ehzrj60m.fsf@ti.com> (raw)
In-Reply-To: <2A3DCF3DA181AD40BDE86A3150B27B6B03B4AAB78D@dbde02.ent.ti.com> (Hemant Pedanekar's message of "Thu, 8 Sep 2011 06:49:39 +0530")

"Pedanekar, Hemant" <hemantp@ti.com> writes:

> Hilman, Kevin wrote on Tuesday, August 30, 2011 6:03 AM:
>
>> Hemant Pedanekar <hemantp@ti.com> writes:
>> 
>>> This patch adds minimum required hwmod data (e.g., UARTs) for bootup of
>>> TI81XX devices (currently common data for TI816X and TI814X is added).
>>> 
>>> Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
>> 
>> I haven't looked at the details yet, but just tried to boot this using
>> current mainline and it fails.
>> 
>> My first guess is that it appears to be related to a missing clkdm for the
>> MPU hwmod. 
>> 
>> Kevin
>
> Thanks for the feedback.
>
> I think that the issue is bacause clk_get() on fck_source is failing
> as TI816X clock data had different clock source names compared to
> OMAP3 (e.g., osc_sys_ck instead of sys_ck). I will update this in next
> version.

Actually, I realized also that ti816x doesn't boot on current l-o master
branch, even without this series.

> Even after this, the kernel would get stuck at "Calibrating delay loop..."
> because a few timer register offsets on TI81XX are different than
> OMAP3. 

At least with my tests, it's getting past that and failing here:

[...]
[    0.000000] NR_IRQS:410                                                      
[    0.000000] IRQ: Found an INTC at 0xfa200000 (revision 5.0) with 128 interrup
ts                                                                              
[    0.000000] Total of 128 interrupts on 1 active controller                   
[    0.000000] omap_hwmod: timer1: cannot setup_one: MPU initiator hwmod mpu not
 yet registered                                                                 

The reason seems to be that no hwmods are getting registered at all.

> I see there are some patches floating on ML which add reg_map array
> (similar to i2c driver) but seems they have not (yet) been
> accepted. Any chance that this will get added to kernel?

I'm not sure.  Which series are you referring to?

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 5/6] TI81XX: Add minimal hwmod data
Date: Thu, 08 Sep 2011 10:30:49 -0700	[thread overview]
Message-ID: <87ehzrj60m.fsf@ti.com> (raw)
In-Reply-To: <2A3DCF3DA181AD40BDE86A3150B27B6B03B4AAB78D@dbde02.ent.ti.com> (Hemant Pedanekar's message of "Thu, 8 Sep 2011 06:49:39 +0530")

"Pedanekar, Hemant" <hemantp@ti.com> writes:

> Hilman, Kevin wrote on Tuesday, August 30, 2011 6:03 AM:
>
>> Hemant Pedanekar <hemantp@ti.com> writes:
>> 
>>> This patch adds minimum required hwmod data (e.g., UARTs) for bootup of
>>> TI81XX devices (currently common data for TI816X and TI814X is added).
>>> 
>>> Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
>> 
>> I haven't looked at the details yet, but just tried to boot this using
>> current mainline and it fails.
>> 
>> My first guess is that it appears to be related to a missing clkdm for the
>> MPU hwmod. 
>> 
>> Kevin
>
> Thanks for the feedback.
>
> I think that the issue is bacause clk_get() on fck_source is failing
> as TI816X clock data had different clock source names compared to
> OMAP3 (e.g., osc_sys_ck instead of sys_ck). I will update this in next
> version.

Actually, I realized also that ti816x doesn't boot on current l-o master
branch, even without this series.

> Even after this, the kernel would get stuck at "Calibrating delay loop..."
> because a few timer register offsets on TI81XX are different than
> OMAP3. 

At least with my tests, it's getting past that and failing here:

[...]
[    0.000000] NR_IRQS:410                                                      
[    0.000000] IRQ: Found an INTC at 0xfa200000 (revision 5.0) with 128 interrup
ts                                                                              
[    0.000000] Total of 128 interrupts on 1 active controller                   
[    0.000000] omap_hwmod: timer1: cannot setup_one: MPU initiator hwmod mpu not
 yet registered                                                                 

The reason seems to be that no hwmods are getting registered at all.

> I see there are some patches floating on ML which add reg_map array
> (similar to i2c driver) but seems they have not (yet) been
> accepted. Any chance that this will get added to kernel?

I'm not sure.  Which series are you referring to?

Kevin

  reply	other threads:[~2011-09-08 17:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23 17:13 [RFC PATCH v2 5/6] TI81XX: Add minimal hwmod data Hemant Pedanekar
2011-08-23 17:13 ` Hemant Pedanekar
2011-08-30  0:32 ` Kevin Hilman
2011-08-30  0:32   ` Kevin Hilman
2011-09-08  1:19   ` Pedanekar, Hemant
2011-09-08  1:19     ` Pedanekar, Hemant
2011-09-08 17:30     ` Kevin Hilman [this message]
2011-09-08 17:30       ` Kevin Hilman
2011-09-09  2:42       ` Pedanekar, Hemant
2011-09-09  2:42         ` Pedanekar, Hemant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehzrj60m.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=hemantp@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.