Re: [PATCH v6 0/7] omap3: pm: Update TRITON power scripts and making it generic

Re: [PATCH v6 0/7] omap3: pm: Update TRITON power scripts and making it generic

[Kevin Hilman]

"Lesly Arackal Manuel" <leslyam@ti.com> writes:

>
> Can you please merge these changes, if you don?t have any further
> comments.
>

Please see my reply to PATCH 3/7 for an indication as to why there may
have been delay in reviewing this series.

Also, it is not required, but considered very helpful, especially to
the maintainers if you summarize somplace what has changed since the
previous version.

Since it took a month to post an updated version, you can understand
that I don't remember the details of all my previous review comments
so need some help.  Without this context, I have to go back through
the mailing list archives to re-read my responses to the previous
versions of the patch and check if those issues were addressed.  In
this case, many of them were not.

Kevin

[PATCH v6 0/7] omap3: pm: Update TRITON power scripts and making it generic

[Lesly A M]

T2 script changes rebased on top of Thara's SmartReflex patches.

This series of patch implements a updated TRITON power scripts.
Also moving the sleep, wakeup & warm_reset sequence to a generic script file,
which can be used by different OMAP3 board with the power companion chip TWL4030.

This patch series is based off Kevin's tree remotes/origin/pm-wip-sr branch,
which have the SmartReflex changes done by Thara Gopinath.

Changes to fix Kevin's & Peter's comments.

This changes are tested on OMAP3430 SDP board with:
	enable_off_mode
	voltage_off_while_idle
	sleep_while_idle (VDD1/VDD2 voltage scaling to 0v) enabled in cpuidle and suspned path.

Lesly A M (7):
  omap3: pm: fix for twl4030 script load
  omap3: pm: Using separate clk/volt setup_time for RET and OFF states
  omap3: pm: re-programing the setup time based on CORE_DOMAIN target
    state.
  omap3: pm: changing vdd0_/vdd1_ to vdd1_/vdd2_ in VC param structure.
  omap3: pm: Generic TRITON power scripts for OMAP3 based boards
  omap3: pm: Use generic TRITON power scripts for 3430SDP board
  omap3: pm: Use generic TRITON power scripts for ZOOM[2,3], 3630SDP
    board

 arch/arm/mach-omap2/Makefile                 |   12 +-
 arch/arm/mach-omap2/board-3430sdp.c          |  111 +---------------
 arch/arm/mach-omap2/board-zoom-peripherals.c |    6 +
 arch/arm/mach-omap2/pm.h                     |   18 ---
 arch/arm/mach-omap2/pm34xx.c                 |   26 +---
 arch/arm/mach-omap2/twl4030.c                |  185 ++++++++++++++++++++++++++
 arch/arm/mach-omap2/twl4030.h                |   15 ++
 arch/arm/mach-omap2/voltage.c                |  157 +++++++++++++++++-----
 arch/arm/mach-omap2/voltage.h                |   26 ++++
 drivers/mfd/twl4030-power.c                  |    5 +-
 include/linux/i2c/twl.h                      |    4 +
 11 files changed, 373 insertions(+), 192 deletions(-)
 create mode 100644 arch/arm/mach-omap2/twl4030.c
 create mode 100644 arch/arm/mach-omap2/twl4030.h