From: Peter Korsgaard <jacmet@sunsite.dk>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, dan.j.williams@intel.com
Subject: Re: [PATCH] fsldma: print correct IRQ on mpc83xx
Date: Wed, 14 Jan 2009 17:38:23 +0100 [thread overview]
Message-ID: <87eiz5c074.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <496E1317.9070804@freescale.com> (Timur Tabi's message of "Wed\, 14 Jan 2009 10\:30\:15 -0600")
>>>>> "Timur" == Timur Tabi <timur@freescale.com> writes:
Timur> Peter Korsgaard wrote:
>> Why? Does it buy us anything to request_irq again for each channel?
>>
>> Now we're at it, it seems like there's a check for != NO_IRQ missing
>> in fsl_dma_chan_remove().
Timur> If the device tree doesn't specify an interrupts property in
Timur> the device channel, then I think that's an error. All the
Timur> device trees already do that. So where do you see this
Timur> problem?
Documentation/powerpc/dts-bindings/fsl/dma.txt and
The NO_IRQ check in fsldma.c:fsl_dma_chan_probe()
And it makes sense, there's no per-channel DMAC interrupts on mpc83xx.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-01-14 16:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 14:44 [PATCH] fsldma: print correct IRQ on mpc83xx Peter Korsgaard
2009-01-14 16:10 ` Timur Tabi
2009-01-14 16:15 ` Peter Korsgaard
2009-01-14 16:30 ` Timur Tabi
2009-01-14 16:38 ` Peter Korsgaard [this message]
2009-01-14 16:42 ` Timur Tabi
2009-01-14 19:29 ` Peter Korsgaard
2009-01-14 19:30 ` Timur Tabi
2009-01-15 6:17 ` Dan Williams
2009-01-15 11:21 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eiz5c074.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=dan.j.williams@intel.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.