All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org,  Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 linux-mips@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
	 Aleksander Jan Bajkowski <olek2@wp.pl>,
	 John Crispin <john@phrozen.org>,
	 Sebastien Decourriere <sebtx452@gmail.com>,
	 Yangtao Li <frank.li@vivo.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: mtd: Add lantiq,nor
Date: Tue, 17 Nov 2026 11:35:13 +0100	[thread overview]
Message-ID: <87fqwzn3tq.fsf@bootlin.com> (raw)
In-Reply-To: <20261114100608.3432120-3-sw@simonwunderlich.de> (Simon Wunderlich's message of "Sat, 14 Nov 2026 11:06:04 +0100")

Hi Simon,

On 14/11/2026 at 11:06:04 +01, Simon Wunderlich <sw@simonwunderlich.de> wrote:

> The NOR flash on the External Bus Unit (EBU) of Lantiq SoCs is handled
> by the lantiq-flash driver and used by danube_easy50712.dts, but its
> binding was never documented.
>
> Add a schema for it, including a new optional lantiq,ebu-swap-check
> property. Some boot loaders, like the BOSS bootmonitor on the bintec
> elmeg RS123 and RS353, enable the EBU's own endianness swapping for the
> flash chip select (EBU_BUSCON0 bit 30), and the flash then appears at
> its unswapped addresses. Whether that bit can be trusted depends on the
> SoC: it only works on VR9 (xRX200) from revision 1.2 and on AR10
> (xRX300), and Falcon has no such register. A board property instead of
> a list of SoC revisions in the driver was requested in the review of an
> earlier attempt at this. The property does not state the bit's value,
> so a board keeps working with either boot loader setting.
>
> Link: https://lists.infradead.org/pipermail/linux-mtd/2017-January/071749.html
> Link: https://lists.infradead.org/pipermail/linux-mtd/2017-January/071818.html
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

Let's be honest, I am not very familiar with that MTD area and all the
legacy content is has, but would it be a lot more work to add lantiq as
a physmap variant? I don't like much the fact that you describe the
flash without describing the EBU. Physmap versions typically are matched
using the more specific compatible (lantiq,ebu?) and the cfi-flash
fallback. All your tweaks are EBU/machine/integration details, not
related to the flash itself.

One consequence of not modeling the controller is your need for
EXPORT_SYMBOL_GPL(ltq_ebu_membase) in patch 3/5, which is quite a hack.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org,  Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 linux-mips@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
	 Aleksander Jan Bajkowski <olek2@wp.pl>,
	 John Crispin <john@phrozen.org>,
	 Sebastien Decourriere <sebtx452@gmail.com>,
	 Yangtao Li <frank.li@vivo.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: mtd: Add lantiq,nor
Date: Tue, 17 Nov 2026 11:35:13 +0100	[thread overview]
Message-ID: <87fqwzn3tq.fsf@bootlin.com> (raw)
In-Reply-To: <20261114100608.3432120-3-sw@simonwunderlich.de> (Simon Wunderlich's message of "Sat, 14 Nov 2026 11:06:04 +0100")

Hi Simon,

On 14/11/2026 at 11:06:04 +01, Simon Wunderlich <sw@simonwunderlich.de> wrote:

> The NOR flash on the External Bus Unit (EBU) of Lantiq SoCs is handled
> by the lantiq-flash driver and used by danube_easy50712.dts, but its
> binding was never documented.
>
> Add a schema for it, including a new optional lantiq,ebu-swap-check
> property. Some boot loaders, like the BOSS bootmonitor on the bintec
> elmeg RS123 and RS353, enable the EBU's own endianness swapping for the
> flash chip select (EBU_BUSCON0 bit 30), and the flash then appears at
> its unswapped addresses. Whether that bit can be trusted depends on the
> SoC: it only works on VR9 (xRX200) from revision 1.2 and on AR10
> (xRX300), and Falcon has no such register. A board property instead of
> a list of SoC revisions in the driver was requested in the review of an
> earlier attempt at this. The property does not state the bit's value,
> so a board keeps working with either boot loader setting.
>
> Link: https://lists.infradead.org/pipermail/linux-mtd/2017-January/071749.html
> Link: https://lists.infradead.org/pipermail/linux-mtd/2017-January/071818.html
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

Let's be honest, I am not very familiar with that MTD area and all the
legacy content is has, but would it be a lot more work to add lantiq as
a physmap variant? I don't like much the fact that you describe the
flash without describing the EBU. Physmap versions typically are matched
using the more specific compatible (lantiq,ebu?) and the cfi-flash
fallback. All your tweaks are EBU/machine/integration details, not
related to the flash itself.

One consequence of not modeling the controller is your need for
EXPORT_SYMBOL_GPL(ltq_ebu_membase) in patch 3/5, which is quite a hack.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-17 10:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 10:06 [PATCH 0/5] mtd: maps: lantiq-flash: support boot loaders using the EBU endianness swap Simon Wunderlich
2026-11-14 10:06 ` Simon Wunderlich
2026-11-14 10:06 ` [PATCH 1/5] mtd: maps: lantiq-flash: fix NULL pointer dereference on probe Simon Wunderlich
2026-11-14 10:06   ` Simon Wunderlich
2026-11-14 10:06 ` [PATCH 2/5] dt-bindings: mtd: Add lantiq,nor Simon Wunderlich
2026-11-14 10:06   ` Simon Wunderlich
2026-11-17 10:35   ` Miquel Raynal [this message]
2026-11-17 10:35     ` Miquel Raynal
2026-11-17 16:45     ` Simon Wunderlich
2026-11-17 16:45       ` Simon Wunderlich
2026-11-14 10:06 ` [PATCH 3/5] mips: lantiq: xway: sysctrl: export ltq_ebu_membase Simon Wunderlich
2026-11-14 10:06   ` Simon Wunderlich
2026-11-14 10:06 ` [PATCH 4/5] mtd: maps: lantiq-flash: honour the EBU's own endianness swap Simon Wunderlich
2026-11-14 10:06   ` Simon Wunderlich
2026-11-14 10:06 ` [PATCH 5/5] mips: lantiq: danube: rename NOR node on EASY50712 reference board Simon Wunderlich
2026-11-14 10:06   ` Simon Wunderlich
2026-11-17 13:37 ` [PATCH 0/5] mtd: maps: lantiq-flash: support boot loaders using the EBU endianness swap Miquel Raynal
2026-11-17 13:37   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fqwzn3tq.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frank.li@vivo.com \
    --cc=hauke@hauke-m.de \
    --cc=john@phrozen.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=olek2@wp.pl \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=sebtx452@gmail.com \
    --cc=sw@simonwunderlich.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.