* [PATCH RFC v3 1/5] fastboot: factor out the USB session runner
2026-07-31 8:29 [PATCH RFC v3 0/5] Add fastboot to SPL Carlo Caione
@ 2026-07-31 8:29 ` Carlo Caione
2026-08-17 8:49 ` Mattijs Korpershoek
2026-07-31 8:29 ` [PATCH RFC v3 2/5] fastboot: use the common handler for USB reboot Carlo Caione
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Carlo Caione @ 2026-07-31 8:29 UTC (permalink / raw)
To: u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris,
Mattijs Korpershoek, Tom Rini, Simon Glass, Sam Day,
Quentin Schulz, Carlo Caione, David Lechner, Vitor Sato Eschholz,
Lukasz Majewski, Marek Vasut, Peng Fan, Jaehoon Chung,
Neil Armstrong, Julien Masson, Alexey Charkov, Adrian Freihofer,
Francois Berder, Ilias Apalodimas, Marek Vasut, Vincent Jardin,
Peter Robinson
The fastboot command currently owns USB gadget setup, protocol
initialization, the service loop and teardown. This prevents callers
which do not use the command line from starting USB fastboot without
duplicating the same session lifecycle.
Move that lifecycle into fastboot_usb_run() and leave cmd/fastboot.c
responsible only for argument parsing and transport selection.
Initialize network sessions in their transport path so their existing
behavior is preserved.
Signed-off-by: Julien Masson <jmasson@baylibre.com>
Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
cmd/fastboot.c | 53 ++++-----------------------------------
drivers/fastboot/Makefile | 1 +
drivers/fastboot/fb_usb.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++
include/fastboot.h | 10 ++++++++
4 files changed, 79 insertions(+), 48 deletions(-)
diff --git a/cmd/fastboot.c b/cmd/fastboot.c
index f3929f88dfa..ace877b6e28 100644
--- a/cmd/fastboot.c
+++ b/cmd/fastboot.c
@@ -7,12 +7,9 @@
* Rob Herring <robh@kernel.org>
*/
#include <command.h>
-#include <console.h>
-#include <g_dnl.h>
#include <fastboot.h>
#include <net.h>
-#include <usb.h>
-#include <watchdog.h>
+#include <vsprintf.h>
#include <linux/printk.h>
#include <linux/stringify.h>
@@ -27,6 +24,7 @@ static int do_fastboot_udp(int argc, char *const argv[],
return CMD_RET_FAILURE;
}
+ fastboot_init((void *)buf_addr, buf_size);
err = net_loop(FASTBOOT_UDP);
if (err < 0) {
@@ -47,6 +45,7 @@ static int do_fastboot_tcp(int argc, char *const argv[],
return CMD_RET_FAILURE;
}
+ fastboot_init((void *)buf_addr, buf_size);
err = net_loop(FASTBOOT_TCP);
if (err < 0) {
@@ -63,7 +62,6 @@ static int do_fastboot_usb(int argc, char *const argv[],
{
int controller_index;
char *usb_controller;
- struct udevice *udc;
char *endp;
int ret;
@@ -82,48 +80,9 @@ static int do_fastboot_usb(int argc, char *const argv[],
return CMD_RET_FAILURE;
}
- ret = udc_device_get_by_index(controller_index, &udc);
- if (ret) {
- pr_err("USB init failed: %d\n", ret);
- return CMD_RET_FAILURE;
- }
-
- g_dnl_clear_detach();
- ret = g_dnl_register("usb_dnl_fastboot");
- if (ret)
- return ret;
-
- if (!g_dnl_board_usb_cable_connected()) {
- puts("\rUSB cable not detected.\n" \
- "Command exit.\n");
- ret = CMD_RET_FAILURE;
- goto exit;
- }
+ ret = fastboot_usb_run(controller_index, (void *)buf_addr, buf_size);
- while (1) {
- if (g_dnl_detach())
- break;
- if (IS_ENABLED(CONFIG_CMD_FASTBOOT_ABORT_KEYED)) {
- if (tstc()) {
- getchar();
- puts("\rOperation aborted.\n");
- break;
- }
- } else if (ctrlc()) {
- break;
- }
- schedule();
- dm_usb_gadget_handle_interrupts(udc);
- }
-
- ret = CMD_RET_SUCCESS;
-
-exit:
- udc_device_put(udc);
- g_dnl_unregister();
- g_dnl_clear_detach();
-
- return ret;
+ return ret ? CMD_RET_FAILURE : CMD_RET_SUCCESS;
}
static int do_fastboot(struct cmd_tbl *cmdtp, int flag, int argc,
@@ -167,8 +126,6 @@ NXTARG:
return CMD_RET_USAGE;
}
- fastboot_init((void *)buf_addr, buf_size);
-
#if CONFIG_IS_ENABLED(NET_LEGACY)
if (!strcmp(argv[1], "udp"))
return do_fastboot_udp(argc, argv, buf_addr, buf_size);
diff --git a/drivers/fastboot/Makefile b/drivers/fastboot/Makefile
index a341af076d1..32e8e072c88 100644
--- a/drivers/fastboot/Makefile
+++ b/drivers/fastboot/Makefile
@@ -3,6 +3,7 @@
obj-y += fb_common.o
obj-y += fb_getvar.o
obj-y += fb_command.o
+obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += fb_usb.o
obj-$(CONFIG_FASTBOOT_FLASH_BLOCK) += fb_block.o
# MMC reuses block implementation
obj-$(CONFIG_FASTBOOT_FLASH_MMC) += fb_block.o fb_mmc.o
diff --git a/drivers/fastboot/fb_usb.c b/drivers/fastboot/fb_usb.c
new file mode 100644
index 00000000000..ecb27f28362
--- /dev/null
+++ b/drivers/fastboot/fb_usb.c
@@ -0,0 +1,63 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2008 - 2009 Windriver, <www.windriver.com>
+ * Author: Tom Rix <Tom.Rix@windriver.com>
+ *
+ * (C) Copyright 2014 Linaro, Ltd.
+ * Rob Herring <robh@kernel.org>
+ */
+
+#include <console.h>
+#include <fastboot.h>
+#include <g_dnl.h>
+#include <usb.h>
+#include <u-boot/schedule.h>
+#include <linux/errno.h>
+#include <linux/printk.h>
+
+int fastboot_usb_run(int controller_index, void *buf_addr, u32 buf_size)
+{
+ struct udevice *udc;
+ int ret;
+
+ ret = udc_device_get_by_index(controller_index, &udc);
+ if (ret) {
+ pr_err("USB init failed: %d\n", ret);
+ return ret;
+ }
+
+ fastboot_init(buf_addr, buf_size);
+ g_dnl_clear_detach();
+
+ ret = g_dnl_register("usb_dnl_fastboot");
+ if (ret)
+ goto err_put;
+
+ if (!g_dnl_board_usb_cable_connected()) {
+ puts("\rUSB cable not detected.\n");
+ ret = -ENODEV;
+ goto err_unregister;
+ }
+
+ while (!g_dnl_detach()) {
+ if (IS_ENABLED(CONFIG_CMD_FASTBOOT_ABORT_KEYED)) {
+ if (tstc()) {
+ getchar();
+ puts("\rOperation aborted.\n");
+ break;
+ }
+ } else if (ctrlc()) {
+ break;
+ }
+ schedule();
+ dm_usb_gadget_handle_interrupts(udc);
+ }
+
+err_unregister:
+ g_dnl_unregister();
+ g_dnl_clear_detach();
+err_put:
+ udc_device_put(udc);
+
+ return ret;
+}
diff --git a/include/fastboot.h b/include/fastboot.h
index b106d617749..f02d2559f2b 100644
--- a/include/fastboot.h
+++ b/include/fastboot.h
@@ -125,6 +125,16 @@ void fastboot_set_progress_callback(void (*progress)(const char *msg));
*/
void fastboot_init(void *buf_addr, u32 buf_size);
+/**
+ * fastboot_usb_run() - run a USB fastboot session
+ *
+ * @controller_index: USB gadget controller index
+ * @buf_addr: Pointer to download buffer, or NULL for default
+ * @buf_size: Size of download buffer, or zero for default
+ * Return: 0 on success, or a negative error code
+ */
+int fastboot_usb_run(int controller_index, void *buf_addr, u32 buf_size);
+
/**
* fastboot_boot() - Execute fastboot boot command
*
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH RFC v3 1/5] fastboot: factor out the USB session runner
2026-07-31 8:29 ` [PATCH RFC v3 1/5] fastboot: factor out the USB session runner Carlo Caione
@ 2026-08-17 8:49 ` Mattijs Korpershoek
0 siblings, 0 replies; 11+ messages in thread
From: Mattijs Korpershoek @ 2026-08-17 8:49 UTC (permalink / raw)
To: Carlo Caione, u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris, Tom Rini,
Simon Glass, Sam Day, Quentin Schulz, Carlo Caione, David Lechner,
Vitor Sato Eschholz, Lukasz Majewski, Marek Vasut, Peng Fan,
Jaehoon Chung, Neil Armstrong, Julien Masson, Alexey Charkov,
Adrian Freihofer, Francois Berder, Ilias Apalodimas, Marek Vasut,
Vincent Jardin, Peter Robinson
Hi Carlo,
Thank you for the patch.
On Fri, Jul 31, 2026 at 10:29, Carlo Caione <ccaione@baylibre.com> wrote:
> The fastboot command currently owns USB gadget setup, protocol
> initialization, the service loop and teardown. This prevents callers
> which do not use the command line from starting USB fastboot without
> duplicating the same session lifecycle.
>
> Move that lifecycle into fastboot_usb_run() and leave cmd/fastboot.c
> responsible only for argument parsing and transport selection.
> Initialize network sessions in their transport path so their existing
> behavior is preserved.
>
> Signed-off-by: Julien Masson <jmasson@baylibre.com>
> Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Sorry for the review delay. This looks good to me!
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v3 2/5] fastboot: use the common handler for USB reboot
2026-07-31 8:29 [PATCH RFC v3 0/5] Add fastboot to SPL Carlo Caione
2026-07-31 8:29 ` [PATCH RFC v3 1/5] fastboot: factor out the USB session runner Carlo Caione
@ 2026-07-31 8:29 ` Carlo Caione
2026-08-17 8:56 ` Mattijs Korpershoek
2026-07-31 8:29 ` [PATCH RFC v3 3/5] fastboot: make shared configuration checks phase-aware Carlo Caione
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Carlo Caione @ 2026-07-31 8:29 UTC (permalink / raw)
To: u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris,
Mattijs Korpershoek, Tom Rini, Simon Glass, Sam Day,
Quentin Schulz, Carlo Caione, David Lechner, Vitor Sato Eschholz,
Lukasz Majewski, Marek Vasut, Peng Fan, Jaehoon Chung,
Neil Armstrong, Julien Masson, Alexey Charkov, Adrian Freihofer,
Francois Berder, Ilias Apalodimas, Marek Vasut, Vincent Jardin,
Peter Robinson
USB fastboot resets the device directly from its request-completion
callback, while the network transports route completed commands through
fastboot_handle_boot(). Keeping reset policy in the transport makes it
harder to support callers with a different reset interface.
Send the USB reboot completion through the common handler as
well. U-Boot proper retains the same do_reset() behavior, while
execution-phase-specific policy can be contained in the shared code.
Signed-off-by: Julien Masson <jmasson@baylibre.com>
Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/usb/gadget/f_fastboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
index 8df0e3f331d..471c0e87042 100644
--- a/drivers/usb/gadget/f_fastboot.c
+++ b/drivers/usb/gadget/f_fastboot.c
@@ -422,7 +422,7 @@ static int fastboot_tx_write_str(const char *buffer)
static void compl_do_reset(struct usb_ep *ep, struct usb_request *req)
{
g_dnl_unregister();
- do_reset(NULL, 0, 0, NULL);
+ fastboot_handle_boot(FASTBOOT_COMMAND_REBOOT, true);
}
static unsigned int rx_bytes_expected(struct usb_ep *ep)
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH RFC v3 2/5] fastboot: use the common handler for USB reboot
2026-07-31 8:29 ` [PATCH RFC v3 2/5] fastboot: use the common handler for USB reboot Carlo Caione
@ 2026-08-17 8:56 ` Mattijs Korpershoek
0 siblings, 0 replies; 11+ messages in thread
From: Mattijs Korpershoek @ 2026-08-17 8:56 UTC (permalink / raw)
To: Carlo Caione, u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris, Tom Rini,
Simon Glass, Sam Day, Quentin Schulz, Carlo Caione, David Lechner,
Vitor Sato Eschholz, Lukasz Majewski, Marek Vasut, Peng Fan,
Jaehoon Chung, Neil Armstrong, Julien Masson, Alexey Charkov,
Adrian Freihofer, Francois Berder, Ilias Apalodimas, Marek Vasut,
Vincent Jardin, Peter Robinson
Hi Carlo,
Thank you for the patch.
On Fri, Jul 31, 2026 at 10:29, Carlo Caione <ccaione@baylibre.com> wrote:
> USB fastboot resets the device directly from its request-completion
> callback, while the network transports route completed commands through
> fastboot_handle_boot(). Keeping reset policy in the transport makes it
> harder to support callers with a different reset interface.
>
> Send the USB reboot completion through the common handler as
> well. U-Boot proper retains the same do_reset() behavior, while
> execution-phase-specific policy can be contained in the shared code.
>
> Signed-off-by: Julien Masson <jmasson@baylibre.com>
> Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Sorry for the review delay, this looks good to me!
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v3 3/5] fastboot: make shared configuration checks phase-aware
2026-07-31 8:29 [PATCH RFC v3 0/5] Add fastboot to SPL Carlo Caione
2026-07-31 8:29 ` [PATCH RFC v3 1/5] fastboot: factor out the USB session runner Carlo Caione
2026-07-31 8:29 ` [PATCH RFC v3 2/5] fastboot: use the common handler for USB reboot Carlo Caione
@ 2026-07-31 8:29 ` Carlo Caione
2026-08-17 9:11 ` Mattijs Korpershoek
2026-07-31 8:29 ` [PATCH RFC v3 4/5] image: sparse: add phase-aware SPL support Carlo Caione
2026-07-31 8:29 ` [PATCH RFC v3 5/5] fastboot: add " Carlo Caione
4 siblings, 1 reply; 11+ messages in thread
From: Carlo Caione @ 2026-07-31 8:29 UTC (permalink / raw)
To: u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris,
Mattijs Korpershoek, Tom Rini, Simon Glass, Sam Day,
Quentin Schulz, Carlo Caione, David Lechner, Vitor Sato Eschholz,
Lukasz Majewski, Marek Vasut, Peng Fan, Jaehoon Chung,
Neil Armstrong, Julien Masson, Alexey Charkov, Adrian Freihofer,
Francois Berder, Ilias Apalodimas, Marek Vasut, Vincent Jardin,
Peter Robinson
Fastboot currently builds only for U-Boot proper, so its source and
Makefile rules test CONFIG_FASTBOOT_* directly. The same checks would
select U-Boot-proper options when these files are compiled for another
phase, potentially compiling unavailable backends or using the wrong
configuration values.
Use CONFIG_IS_ENABLED(), CONFIG_VAL() and CONFIG_$(PHASE_) consistently
for code and object selection. The empty phase prefix preserves the
existing U-Boot-proper configuration and behavior while making the
shared implementation safe to reuse from SPL.
Signed-off-by: Julien Masson <jmasson@baylibre.com>
Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
drivers/Makefile | 2 +-
drivers/fastboot/Makefile | 8 ++++----
drivers/fastboot/fb_block.c | 9 ++++-----
drivers/fastboot/fb_command.c | 31 +++++++++++++++++--------------
drivers/fastboot/fb_common.c | 4 ++--
drivers/fastboot/fb_getvar.c | 14 +++++++-------
drivers/fastboot/fb_mmc.c | 36 ++++++++++++++++++------------------
7 files changed, 53 insertions(+), 51 deletions(-)
diff --git a/drivers/Makefile b/drivers/Makefile
index 43d0ba33281..43d03479146 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -12,6 +12,7 @@ obj-$(CONFIG_$(PHASE_)DMA) += dma/
obj-$(CONFIG_$(PHASE_)DMA_LEGACY) += dma/
obj-$(CONFIG_$(PHASE_)DFU) += dfu/
obj-$(CONFIG_$(PHASE_)EXTCON) += extcon/
+obj-$(CONFIG_$(PHASE_)FASTBOOT) += fastboot/
obj-$(CONFIG_$(PHASE_)GPIO) += gpio/
obj-$(CONFIG_$(PHASE_)DRIVERS_MISC) += misc/
obj-$(CONFIG_$(PHASE_)SYSRESET) += sysreset/
@@ -93,7 +94,6 @@ obj-y += block/
obj-y += cache/
obj-$(CONFIG_CPU) += cpu/
obj-y += crypto/
-obj-$(CONFIG_FASTBOOT) += fastboot/
obj-$(CONFIG_FWU_MDATA) += fwu-mdata/
obj-y += misc/
obj-$(CONFIG_MMC) += mmc/
diff --git a/drivers/fastboot/Makefile b/drivers/fastboot/Makefile
index 32e8e072c88..12008ac05e2 100644
--- a/drivers/fastboot/Makefile
+++ b/drivers/fastboot/Makefile
@@ -4,8 +4,8 @@ obj-y += fb_common.o
obj-y += fb_getvar.o
obj-y += fb_command.o
obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += fb_usb.o
-obj-$(CONFIG_FASTBOOT_FLASH_BLOCK) += fb_block.o
+obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_BLOCK) += fb_block.o
# MMC reuses block implementation
-obj-$(CONFIG_FASTBOOT_FLASH_MMC) += fb_block.o fb_mmc.o
-obj-$(CONFIG_FASTBOOT_FLASH_NAND) += fb_nand.o
-obj-$(CONFIG_FASTBOOT_FLASH_SPI) += fb_spi_flash.o
+obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_MMC) += fb_block.o fb_mmc.o
+obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_NAND) += fb_nand.o
+obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_SPI) += fb_spi_flash.o
diff --git a/drivers/fastboot/fb_block.c b/drivers/fastboot/fb_block.c
index 51d1abb18c7..9658b14e668 100644
--- a/drivers/fastboot/fb_block.c
+++ b/drivers/fastboot/fb_block.c
@@ -130,11 +130,10 @@ int fastboot_block_get_part_info(const char *part_name,
char *response)
{
int ret;
- const char *interface = config_opt_enabled(CONFIG_FASTBOOT_FLASH_BLOCK,
- CONFIG_FASTBOOT_FLASH_BLOCK_INTERFACE_NAME,
- NULL);
- const int device = config_opt_enabled(CONFIG_FASTBOOT_FLASH_BLOCK,
- CONFIG_FASTBOOT_FLASH_BLOCK_DEVICE_ID, -1);
+ const char *interface = CONFIG_IS_ENABLED(FASTBOOT_FLASH_BLOCK,
+ (CONFIG_VAL(FASTBOOT_FLASH_BLOCK_INTERFACE_NAME)), (NULL));
+ const int device = CONFIG_IS_ENABLED(FASTBOOT_FLASH_BLOCK,
+ (CONFIG_VAL(FASTBOOT_FLASH_BLOCK_DEVICE_ID)), (-1));
if (!part_name || !strcmp(part_name, "")) {
fastboot_fail("partition not given", response);
diff --git a/drivers/fastboot/fb_command.c b/drivers/fastboot/fb_command.c
index 18d86988f4c..111516fd1b3 100644
--- a/drivers/fastboot/fb_command.c
+++ b/drivers/fastboot/fb_command.c
@@ -339,19 +339,19 @@ void fastboot_data_complete(char *response)
*/
static void __maybe_unused flash(char *cmd_parameter, char *response)
{
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_BLOCK))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_BLOCK))
fastboot_block_flash_write(cmd_parameter, fastboot_buf_addr,
image_size, response);
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_MMC))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC))
fastboot_mmc_flash_write(cmd_parameter, fastboot_buf_addr,
image_size, response);
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_NAND))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_NAND))
fastboot_nand_flash_write(cmd_parameter, fastboot_buf_addr,
image_size, response);
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_SPI))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_SPI))
fastboot_spi_flash_write(cmd_parameter, fastboot_buf_addr,
image_size, response);
}
@@ -367,16 +367,16 @@ static void __maybe_unused flash(char *cmd_parameter, char *response)
*/
static void __maybe_unused erase(char *cmd_parameter, char *response)
{
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_BLOCK))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_BLOCK))
fastboot_block_erase(cmd_parameter, response);
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_MMC))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC))
fastboot_mmc_erase(cmd_parameter, response);
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_NAND))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_NAND))
fastboot_nand_erase(cmd_parameter, response);
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_SPI))
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_SPI))
fastboot_spi_flash_erase(cmd_parameter, response);
}
@@ -482,8 +482,9 @@ static void reboot_recovery(char *cmd_parameter, char *response)
static void __maybe_unused oem_format(char *cmd_parameter, char *response)
{
char cmdbuf[32];
- const int mmc_dev = config_opt_enabled(CONFIG_FASTBOOT_FLASH_MMC,
- CONFIG_FASTBOOT_FLASH_MMC_DEV, -1);
+ const int mmc_dev = CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC,
+ (CONFIG_VAL(FASTBOOT_FLASH_MMC_DEV)),
+ (-1));
if (!env_get("partitions")) {
fastboot_fail("partitions not set", response);
@@ -505,8 +506,9 @@ static void __maybe_unused oem_format(char *cmd_parameter, char *response)
static void __maybe_unused oem_partconf(char *cmd_parameter, char *response)
{
char cmdbuf[32];
- const int mmc_dev = config_opt_enabled(CONFIG_FASTBOOT_FLASH_MMC,
- CONFIG_FASTBOOT_FLASH_MMC_DEV, -1);
+ const int mmc_dev = CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC,
+ (CONFIG_VAL(FASTBOOT_FLASH_MMC_DEV)),
+ (-1));
if (!cmd_parameter) {
fastboot_fail("Expected command parameter", response);
@@ -531,8 +533,9 @@ static void __maybe_unused oem_partconf(char *cmd_parameter, char *response)
static void __maybe_unused oem_bootbus(char *cmd_parameter, char *response)
{
char cmdbuf[32];
- const int mmc_dev = config_opt_enabled(CONFIG_FASTBOOT_FLASH_MMC,
- CONFIG_FASTBOOT_FLASH_MMC_DEV, -1);
+ const int mmc_dev = CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC,
+ (CONFIG_VAL(FASTBOOT_FLASH_MMC_DEV)),
+ (-1));
if (!cmd_parameter) {
fastboot_fail("Expected command parameter", response);
diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
index 9c52e004588..3c0013490cc 100644
--- a/drivers/fastboot/fb_common.c
+++ b/drivers/fastboot/fb_common.c
@@ -234,8 +234,8 @@ void fastboot_set_progress_callback(void (*progress)(const char *msg))
*/
void fastboot_init(void *buf_addr, u32 buf_size)
{
-#if IS_ENABLED(CONFIG_FASTBOOT_FLASH_BLOCK)
- if (!strcmp(CONFIG_FASTBOOT_FLASH_BLOCK_INTERFACE_NAME, "mmc"))
+#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_BLOCK)
+ if (!strcmp(CONFIG_VAL(FASTBOOT_FLASH_BLOCK_INTERFACE_NAME), "mmc"))
printf("Warning: the fastboot block backend features are limited, consider using the MMC backend\n");
#endif
diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c
index e8aa0e09aa6..9e8e8889d08 100644
--- a/drivers/fastboot/fb_getvar.c
+++ b/drivers/fastboot/fb_getvar.c
@@ -70,19 +70,19 @@ static const struct {
.variable = "current-slot",
.dispatch = getvar_current_slot,
.list = true
-#if IS_ENABLED(CONFIG_FASTBOOT_FLASH)
+#if CONFIG_IS_ENABLED(FASTBOOT_FLASH)
}, {
.variable = "has-slot",
.dispatch = getvar_has_slot,
.list = false
#endif
-#if IS_ENABLED(CONFIG_FASTBOOT_FLASH_MMC)
+#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC)
}, {
.variable = "partition-type",
.dispatch = getvar_partition_type,
.list = false
#endif
-#if IS_ENABLED(CONFIG_FASTBOOT_FLASH)
+#if CONFIG_IS_ENABLED(FASTBOOT_FLASH)
}, {
.variable = "partition-size",
.dispatch = getvar_partition_size,
@@ -116,21 +116,21 @@ static int getvar_get_part_info(const char *part_name, char *response,
struct disk_partition disk_part;
struct part_info *part_info;
- if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_BLOCK)) {
+ if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_BLOCK)) {
r = fastboot_block_get_part_info(part_name, &dev_desc, &disk_part,
response);
if (r >= 0 && size)
*size = disk_part.size * disk_part.blksz;
- } else if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_MMC)) {
+ } else if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC)) {
r = fastboot_mmc_get_part_info(part_name, &dev_desc, &disk_part,
response);
if (r >= 0 && size)
*size = disk_part.size * disk_part.blksz;
- } else if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_NAND)) {
+ } else if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_NAND)) {
r = fastboot_nand_get_part_info(part_name, &part_info, response);
if (r >= 0 && size)
*size = part_info->size;
- } else if (IS_ENABLED(CONFIG_FASTBOOT_FLASH_SPI)) {
+ } else if (CONFIG_IS_ENABLED(FASTBOOT_FLASH_SPI)) {
r = fastboot_spi_flash_get_part_info(part_name, &disk_part,
response);
if (r >= 0 && size)
diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
index 9bc782ccd02..ae33e35365b 100644
--- a/drivers/fastboot/fb_mmc.c
+++ b/drivers/fastboot/fb_mmc.c
@@ -75,7 +75,7 @@ static int do_get_part_info(struct blk_desc **dev_desc, const char *name,
int ret;
/* First try partition names on the default device */
- *dev_desc = blk_get_dev("mmc", CONFIG_FASTBOOT_FLASH_MMC_DEV);
+ *dev_desc = blk_get_dev("mmc", CONFIG_VAL(FASTBOOT_FLASH_MMC_DEV));
if (*dev_desc) {
ret = part_get_info_by_name(*dev_desc, name, info);
if (ret >= 0)
@@ -111,7 +111,7 @@ static int part_get_info_by_name_or_alias(struct blk_desc **dev_desc,
return do_get_part_info(dev_desc, name, info);
}
-#ifdef CONFIG_FASTBOOT_MMC_BOOT_SUPPORT
+#if CONFIG_IS_ENABLED(FASTBOOT_MMC_BOOT_SUPPORT)
static void fb_mmc_boot_ops(struct blk_desc *dev_desc, void *buffer,
int hwpart, u32 buff_sz, char *response)
{
@@ -130,7 +130,7 @@ static void fb_mmc_boot_ops(struct blk_desc *dev_desc, void *buffer,
}
#endif
-#ifdef CONFIG_ANDROID_BOOT_IMAGE
+#if CONFIG_IS_ENABLED(ANDROID_BOOT_IMAGE)
/**
* Read Android boot image header from boot partition.
*
@@ -346,7 +346,7 @@ int fastboot_mmc_get_part_info(const char *part_name,
static struct blk_desc *fastboot_mmc_get_dev(char *response)
{
struct blk_desc *ret = blk_get_dev("mmc",
- CONFIG_FASTBOOT_FLASH_MMC_DEV);
+ CONFIG_VAL(FASTBOOT_FLASH_MMC_DEV));
if (!ret || ret->type == DEV_TYPE_UNKNOWN) {
pr_err("invalid mmc device\n");
@@ -370,15 +370,15 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
struct blk_desc *dev_desc;
struct disk_partition info = {0};
-#ifdef CONFIG_FASTBOOT_MMC_BOOT_SUPPORT
- if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT1_NAME) == 0) {
+#if CONFIG_IS_ENABLED(FASTBOOT_MMC_BOOT_SUPPORT)
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_MMC_BOOT1_NAME))) {
dev_desc = fastboot_mmc_get_dev(response);
if (dev_desc)
fb_mmc_boot_ops(dev_desc, download_buffer, 1,
download_bytes, response);
return;
}
- if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) {
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_MMC_BOOT2_NAME))) {
dev_desc = fastboot_mmc_get_dev(response);
if (dev_desc)
fb_mmc_boot_ops(dev_desc, download_buffer, 2,
@@ -388,7 +388,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
#endif
#if CONFIG_IS_ENABLED(EFI_PARTITION)
- if (strcmp(cmd, CONFIG_FASTBOOT_GPT_NAME) == 0) {
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_GPT_NAME))) {
dev_desc = fastboot_mmc_get_dev(response);
if (!dev_desc)
return;
@@ -415,7 +415,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
#endif
#if CONFIG_IS_ENABLED(DOS_PARTITION)
- if (strcmp(cmd, CONFIG_FASTBOOT_MBR_NAME) == 0) {
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_MBR_NAME))) {
dev_desc = fastboot_mmc_get_dev(response);
if (!dev_desc)
return;
@@ -440,7 +440,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
}
#endif
-#ifdef CONFIG_ANDROID_BOOT_IMAGE
+#if CONFIG_IS_ENABLED(ANDROID_BOOT_IMAGE)
if (strncasecmp(cmd, "zimage", 6) == 0) {
dev_desc = fastboot_mmc_get_dev(response);
if (dev_desc)
@@ -450,8 +450,8 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
}
#endif
-#if IS_ENABLED(CONFIG_FASTBOOT_MMC_USER_SUPPORT)
- if (strcmp(cmd, CONFIG_FASTBOOT_MMC_USER_NAME) == 0) {
+#if CONFIG_IS_ENABLED(FASTBOOT_MMC_USER_SUPPORT)
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_MMC_USER_NAME))) {
dev_desc = fastboot_mmc_get_dev(response);
if (!dev_desc)
return;
@@ -485,17 +485,17 @@ void fastboot_mmc_erase(const char *cmd, char *response)
{
struct blk_desc *dev_desc;
struct disk_partition info;
- struct mmc *mmc = find_mmc_device(CONFIG_FASTBOOT_FLASH_MMC_DEV);
+ struct mmc *mmc = find_mmc_device(CONFIG_VAL(FASTBOOT_FLASH_MMC_DEV));
-#ifdef CONFIG_FASTBOOT_MMC_BOOT_SUPPORT
- if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT1_NAME) == 0) {
+#if CONFIG_IS_ENABLED(FASTBOOT_MMC_BOOT_SUPPORT)
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_MMC_BOOT1_NAME))) {
/* erase EMMC boot1 */
dev_desc = fastboot_mmc_get_dev(response);
if (dev_desc)
fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response);
return;
}
- if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) {
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_MMC_BOOT2_NAME))) {
/* erase EMMC boot2 */
dev_desc = fastboot_mmc_get_dev(response);
if (dev_desc)
@@ -504,8 +504,8 @@ void fastboot_mmc_erase(const char *cmd, char *response)
}
#endif
-#ifdef CONFIG_FASTBOOT_MMC_USER_SUPPORT
- if (strcmp(cmd, CONFIG_FASTBOOT_MMC_USER_NAME) == 0) {
+#if CONFIG_IS_ENABLED(FASTBOOT_MMC_USER_SUPPORT)
+ if (!strcmp(cmd, CONFIG_VAL(FASTBOOT_MMC_USER_NAME))) {
/* erase EMMC userdata */
dev_desc = fastboot_mmc_get_dev(response);
if (!dev_desc)
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH RFC v3 3/5] fastboot: make shared configuration checks phase-aware
2026-07-31 8:29 ` [PATCH RFC v3 3/5] fastboot: make shared configuration checks phase-aware Carlo Caione
@ 2026-08-17 9:11 ` Mattijs Korpershoek
0 siblings, 0 replies; 11+ messages in thread
From: Mattijs Korpershoek @ 2026-08-17 9:11 UTC (permalink / raw)
To: Carlo Caione, u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris, Tom Rini,
Simon Glass, Sam Day, Quentin Schulz, Carlo Caione, David Lechner,
Vitor Sato Eschholz, Lukasz Majewski, Marek Vasut, Peng Fan,
Jaehoon Chung, Neil Armstrong, Julien Masson, Alexey Charkov,
Adrian Freihofer, Francois Berder, Ilias Apalodimas, Marek Vasut,
Vincent Jardin, Peter Robinson
Hi Carlo,
Thank you for the patch.
On Fri, Jul 31, 2026 at 10:29, Carlo Caione <ccaione@baylibre.com> wrote:
> Fastboot currently builds only for U-Boot proper, so its source and
> Makefile rules test CONFIG_FASTBOOT_* directly. The same checks would
> select U-Boot-proper options when these files are compiled for another
> phase, potentially compiling unavailable backends or using the wrong
> configuration values.
>
> Use CONFIG_IS_ENABLED(), CONFIG_VAL() and CONFIG_$(PHASE_) consistently
> for code and object selection. The empty phase prefix preserves the
> existing U-Boot-proper configuration and behavior while making the
> shared implementation safe to reuse from SPL.
>
> Signed-off-by: Julien Masson <jmasson@baylibre.com>
> Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Sorry for the review delays.
> ---
> drivers/Makefile | 2 +-
> drivers/fastboot/Makefile | 8 ++++----
> drivers/fastboot/fb_block.c | 9 ++++-----
> drivers/fastboot/fb_command.c | 31 +++++++++++++++++--------------
> drivers/fastboot/fb_common.c | 4 ++--
> drivers/fastboot/fb_getvar.c | 14 +++++++-------
> drivers/fastboot/fb_mmc.c | 36 ++++++++++++++++++------------------
Shouldn't the newly created drivers/fastboot/fb_usb.c be converted as
well?
From what I can see in there, we have:
IS_ENABLED(CONFIG_CMD_FASTBOOT_ABORT_KEYED) which should become:
CONFIG_IS_ENABLED(CMD_FASTBOOT_ABORT_KEYED)
> 7 files changed, 53 insertions(+), 51 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 43d0ba33281..43d03479146 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -12,6 +12,7 @@ obj-$(CONFIG_$(PHASE_)DMA) += dma/
> obj-$(CONFIG_$(PHASE_)DMA_LEGACY) += dma/
> obj-$(CONFIG_$(PHASE_)DFU) += dfu/
> obj-$(CONFIG_$(PHASE_)EXTCON) += extcon/
> +obj-$(CONFIG_$(PHASE_)FASTBOOT) += fastboot/
> obj-$(CONFIG_$(PHASE_)GPIO) += gpio/
> obj-$(CONFIG_$(PHASE_)DRIVERS_MISC) += misc/
> obj-$(CONFIG_$(PHASE_)SYSRESET) += sysreset/
> @@ -93,7 +94,6 @@ obj-y += block/
> obj-y += cache/
> obj-$(CONFIG_CPU) += cpu/
> obj-y += crypto/
> -obj-$(CONFIG_FASTBOOT) += fastboot/
> obj-$(CONFIG_FWU_MDATA) += fwu-mdata/
> obj-y += misc/
> obj-$(CONFIG_MMC) += mmc/
> diff --git a/drivers/fastboot/Makefile b/drivers/fastboot/Makefile
> index 32e8e072c88..12008ac05e2 100644
> --- a/drivers/fastboot/Makefile
> +++ b/drivers/fastboot/Makefile
> @@ -4,8 +4,8 @@ obj-y += fb_common.o
> obj-y += fb_getvar.o
> obj-y += fb_command.o
> obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += fb_usb.o
Same question here, should CONFIG_USB_FUNCTION_FASTBOOT move to a phase
specific as well?
The rest looks good.
Thanks
Mattijs
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v3 4/5] image: sparse: add phase-aware SPL support
2026-07-31 8:29 [PATCH RFC v3 0/5] Add fastboot to SPL Carlo Caione
` (2 preceding siblings ...)
2026-07-31 8:29 ` [PATCH RFC v3 3/5] fastboot: make shared configuration checks phase-aware Carlo Caione
@ 2026-07-31 8:29 ` Carlo Caione
2026-08-17 9:34 ` Mattijs Korpershoek
2026-07-31 8:29 ` [PATCH RFC v3 5/5] fastboot: add " Carlo Caione
4 siblings, 1 reply; 11+ messages in thread
From: Carlo Caione @ 2026-07-31 8:29 UTC (permalink / raw)
To: u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris,
Mattijs Korpershoek, Tom Rini, Simon Glass, Sam Day,
Quentin Schulz, Carlo Caione, David Lechner, Vitor Sato Eschholz,
Lukasz Majewski, Marek Vasut, Peng Fan, Jaehoon Chung,
Neil Armstrong, Julien Masson, Alexey Charkov, Adrian Freihofer,
Francois Berder, Ilias Apalodimas, Marek Vasut, Vincent Jardin,
Peter Robinson
The Android sparse-image writer is selected and configured only through
U-Boot-proper symbols. An SPL storage service therefore cannot reuse
it without either pulling it into every SPL build or interpreting the
U-Boot-proper fill-buffer setting.
Add opt-in SPL symbols, build the writer through the phase-aware object
rule and read the matching phase value with CONFIG_VAL(). Existing
U-Boot-proper builds continue to use IMAGE_SPARSE and retain the same
fill-buffer default.
Signed-off-by: Julien Masson <jmasson@baylibre.com>
Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
lib/Kconfig | 11 +++++++++++
lib/Makefile | 3 ++-
lib/image-sparse.c | 2 +-
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index 24e55ade4d3..07ee3c88fd3 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -205,6 +205,9 @@ config VPL_STRTO
config IMAGE_SPARSE
bool
+config SPL_IMAGE_SPARSE
+ bool
+
config IMAGE_SPARSE_FILLBUF_SIZE
hex "Android sparse image CHUNK_TYPE_FILL buffer size"
default 0x80000
@@ -213,6 +216,14 @@ config IMAGE_SPARSE_FILLBUF_SIZE
Set the size of the fill buffer used when processing CHUNK_TYPE_FILL
chunks.
+config SPL_IMAGE_SPARSE_FILLBUF_SIZE
+ hex "Android sparse image fill buffer size in SPL"
+ default 0x80000
+ depends on SPL_IMAGE_SPARSE
+ help
+ Set the size of the fill buffer used when processing CHUNK_TYPE_FILL
+ chunks in SPL.
+
config USE_PRIVATE_LIBGCC
bool "Use private libgcc"
depends on HAVE_PRIVATE_LIBGCC
diff --git a/lib/Makefile b/lib/Makefile
index 222378a8531..014fda82860 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -44,7 +44,6 @@ obj-$(CONFIG_GENERATE_SMBIOS_TABLE) += smbios.o
endif
obj-$(CONFIG_SMBIOS_PARSER) += smbios-parser.o
-obj-$(CONFIG_IMAGE_SPARSE) += image-sparse.o
obj-y += ldiv.o
obj-$(CONFIG_XXHASH) += xxhash.o
obj-y += net_utils.o
@@ -56,6 +55,8 @@ obj-y += list_sort.o
obj-$(CONFIG_PMBUS) += pmbus.o
endif
+obj-$(CONFIG_$(PHASE_)IMAGE_SPARSE) += image-sparse.o
+
obj-$(CONFIG_$(PHASE_)TPM) += tpm-common.o
ifeq ($(CONFIG_$(PHASE_)TPM),y)
obj-$(CONFIG_TPM) += tpm_api.o
diff --git a/lib/image-sparse.c b/lib/image-sparse.c
index 09225692e9b..48e5d8ee869 100644
--- a/lib/image-sparse.c
+++ b/lib/image-sparse.c
@@ -125,7 +125,7 @@ int write_sparse_image(struct sparse_storage *info,
int i;
int j;
- fill_buf_num_blks = CONFIG_IMAGE_SPARSE_FILLBUF_SIZE / info->blksz;
+ fill_buf_num_blks = CONFIG_VAL(IMAGE_SPARSE_FILLBUF_SIZE) / info->blksz;
/* Read and skip over sparse image header */
sparse_header = (sparse_header_t *)data;
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH RFC v3 4/5] image: sparse: add phase-aware SPL support
2026-07-31 8:29 ` [PATCH RFC v3 4/5] image: sparse: add phase-aware SPL support Carlo Caione
@ 2026-08-17 9:34 ` Mattijs Korpershoek
0 siblings, 0 replies; 11+ messages in thread
From: Mattijs Korpershoek @ 2026-08-17 9:34 UTC (permalink / raw)
To: Carlo Caione, u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris, Tom Rini,
Simon Glass, Sam Day, Quentin Schulz, Carlo Caione, David Lechner,
Vitor Sato Eschholz, Lukasz Majewski, Marek Vasut, Peng Fan,
Jaehoon Chung, Neil Armstrong, Julien Masson, Alexey Charkov,
Adrian Freihofer, Francois Berder, Ilias Apalodimas, Marek Vasut,
Vincent Jardin, Peter Robinson
Hi Carlo,
Thank you for the patch.
On Fri, Jul 31, 2026 at 10:29, Carlo Caione <ccaione@baylibre.com> wrote:
> The Android sparse-image writer is selected and configured only through
> U-Boot-proper symbols. An SPL storage service therefore cannot reuse
> it without either pulling it into every SPL build or interpreting the
> U-Boot-proper fill-buffer setting.
>
> Add opt-in SPL symbols, build the writer through the phase-aware object
> rule and read the matching phase value with CONFIG_VAL(). Existing
> U-Boot-proper builds continue to use IMAGE_SPARSE and retain the same
> fill-buffer default.
>
> Signed-off-by: Julien Masson <jmasson@baylibre.com>
> Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Sorry for the review delays.
This looks good to me.
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH RFC v3 5/5] fastboot: add SPL support
2026-07-31 8:29 [PATCH RFC v3 0/5] Add fastboot to SPL Carlo Caione
` (3 preceding siblings ...)
2026-07-31 8:29 ` [PATCH RFC v3 4/5] image: sparse: add phase-aware SPL support Carlo Caione
@ 2026-07-31 8:29 ` Carlo Caione
2026-08-17 12:35 ` Mattijs Korpershoek
4 siblings, 1 reply; 11+ messages in thread
From: Carlo Caione @ 2026-07-31 8:29 UTC (permalink / raw)
To: u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris,
Mattijs Korpershoek, Tom Rini, Simon Glass, Sam Day,
Quentin Schulz, Carlo Caione, David Lechner, Vitor Sato Eschholz,
Lukasz Majewski, Marek Vasut, Peng Fan, Jaehoon Chung,
Neil Armstrong, Julien Masson, Alexey Charkov, Adrian Freihofer,
Francois Berder, Ilias Apalodimas, Marek Vasut, Vincent Jardin,
Peter Robinson
Some recovery and initial-provisioning flows run before usable firmware
is available in persistent storage. In these flows the SoC ROM loads a
small first stage, but that stage must still provide a standard protocol
with which the host can provision the device.
U-Boot already provides fastboot for this purpose, but its
implementation is currently restricted to U-Boot proper and coupled
to command-line support. This forces platforms that need provisioning
from SPL to maintain a separate downloader or an out-of-tree fastboot
implementation.
Allow boards to run USB fastboot as a service directly from SPL. Include
MMC partition flashing and Android sparse-image handling so that the SPL
service can provision the same storage images accepted by fastboot in
U-Boot proper.
Keep the SPL interface deliberately narrower. The fastboot boot command
is not supported because SPL is being used for provisioning rather than
OS boot orchestration. Filesystem probing is also omitted, so partition
types are reported as raw. Reboot support remains optional since reset
and persistent reboot-reason handling are platform-specific.
SPL size remains an important constraint. Make the support entirely
opt-in and phase-specific: when CONFIG_SPL_FASTBOOT is disabled, no
fastboot code or supporting library is added to SPL and its binary size
is unchanged.
Signed-off-by: Julien Masson <jmasson@baylibre.com>
Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
doc/android/fastboot.rst | 27 ++++++++++++-
drivers/fastboot/Kconfig | 89 ++++++++++++++++++++++++++++++++++++++++-
drivers/fastboot/Makefile | 4 ++
drivers/fastboot/fb_command.c | 27 +++++++++++--
drivers/fastboot/fb_common.c | 21 ++++++++++
drivers/fastboot/fb_getvar.c | 5 +++
drivers/fastboot/fb_usb.c | 3 ++
drivers/usb/gadget/Makefile | 1 +
drivers/usb/gadget/f_fastboot.c | 4 ++
9 files changed, 175 insertions(+), 6 deletions(-)
diff --git a/doc/android/fastboot.rst b/doc/android/fastboot.rst
index 96c544ae11b..885767e450f 100644
--- a/doc/android/fastboot.rst
+++ b/doc/android/fastboot.rst
@@ -10,7 +10,7 @@ The protocol that is used over USB and UDP is described in [1]_.
The current implementation supports the following standard commands:
-- ``boot``
+- ``boot`` (not available in SPL)
- ``continue``
- ``download``
- ``erase`` (if enabled)
@@ -72,6 +72,31 @@ platform. The location of the buffer and size are set with
may be overridden on the fastboot command line using ``-l`` and
``-s``.
+Fastboot in SPL
+^^^^^^^^^^^^^^^
+
+Fastboot can be used from SPL without enabling the command line. Enable
+``CONFIG_SPL_FASTBOOT`` together with the platform's SPL USB gadget support,
+then start the session from board code::
+
+ ret = fastboot_usb_run(controller_index, NULL, 0);
+
+A ``NULL`` buffer and zero size select ``CONFIG_FASTBOOT_BUF_ADDR`` and
+``CONFIG_FASTBOOT_BUF_SIZE``. Passing explicit values overrides these
+defaults. The ``continue`` command ends the session and returns control to the
+caller. Unlike the command-line invocation, an SPL session cannot be aborted
+from the local console.
+
+MMC flash and erase support is enabled with
+``CONFIG_SPL_FASTBOOT_FLASH_MMC``. The SPL partition-table parser matching the
+storage layout must also be enabled, for example ``CONFIG_SPL_EFI_PARTITION``
+for GPT.
+
+The ``boot`` command is not available in SPL. Reboot commands require
+``CONFIG_SPL_FASTBOOT_REBOOT`` and a platform ``reset_cpu()`` implementation.
+The ``reboot-bootloader``, ``reboot-fastboot`` and ``reboot-recovery`` commands
+also require a platform ``fastboot_set_reboot_flag()`` implementation.
+
Fastboot environment variables
------------------------------
diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
index 90212fcf9ef..017fb7956a1 100644
--- a/drivers/fastboot/Kconfig
+++ b/drivers/fastboot/Kconfig
@@ -1,5 +1,6 @@
menu "Fastboot support"
- depends on CMDLINE
+
+if CMDLINE
config FASTBOOT
bool
@@ -47,7 +48,27 @@ config TCP_FUNCTION_FASTBOOT
help
This enables the fastboot protocol over TCP.
-if FASTBOOT
+endif # CMDLINE
+
+config SPL_FASTBOOT
+ bool "Support fastboot in SPL"
+ depends on USB_GADGET && SPL_USB_GADGET
+ depends on SPL_ENV_SUPPORT
+ depends on !SPL_USE_TINY_PRINTF
+ select SPL_LIBCOMMON_SUPPORT
+ select SPL_LIBGENERIC_SUPPORT
+ select SPL_PRINTF
+ help
+ Enable the USB fastboot protocol in SPL. The board is responsible
+ for starting the fastboot session.
+
+config SPL_FASTBOOT_REBOOT
+ bool "Enable fastboot reboot commands in SPL"
+ depends on SPL_FASTBOOT
+ help
+ Enable the fastboot reboot commands in SPL.
+
+if FASTBOOT || SPL_FASTBOOT
config FASTBOOT_BUF_ADDR
hex "Define FASTBOOT buffer address"
@@ -79,6 +100,10 @@ config FASTBOOT_BUF_SIZE
downloads. This buffer should be as large as possible for a
platform. Define this to the size available RAM for fastboot.
+endif # FASTBOOT || SPL_FASTBOOT
+
+if FASTBOOT
+
config FASTBOOT_USB_DEV
int "USB controller number"
depends on USB_FUNCTION_FASTBOOT
@@ -294,4 +319,64 @@ config FASTBOOT_OEM_BOARD
endif # FASTBOOT
+config SPL_FASTBOOT_FLASH
+ bool
+ default y if SPL_FASTBOOT_FLASH_MMC
+ select SPL_IMAGE_SPARSE
+
+config SPL_FASTBOOT_FLASH_MMC
+ bool "Enable fastboot MMC flashing in SPL"
+ depends on SPL_FASTBOOT && SPL_MMC && SPL_DM_MMC && SPL_PARTITIONS
+ select SPL_MMC_WRITE
+ help
+ Build the fastboot MMC flashing backend into SPL. This allows the
+ fastboot flash and erase commands to operate on MMC partitions. A
+ suitable SPL partition-table parser must also be enabled.
+
+config SPL_FASTBOOT_FLASH_MMC_DEV
+ int "Define fastboot MMC flash device in SPL"
+ depends on SPL_FASTBOOT_FLASH_MMC
+ default 0
+ help
+ Define the MMC device that the SPL fastboot flash backend uses.
+
+config SPL_FASTBOOT_MMC_BOOT_SUPPORT
+ bool "Enable eMMC boot-partition flash/erase in SPL"
+ depends on SPL_FASTBOOT_FLASH_MMC && SUPPORT_EMMC_BOOT
+ help
+ Enable the special fastboot targets used to flash or erase the eMMC
+ boot hardware partitions from SPL.
+
+config SPL_FASTBOOT_MMC_BOOT1_NAME
+ string "Target name for updating eMMC boot partition 1 in SPL"
+ depends on SPL_FASTBOOT_MMC_BOOT_SUPPORT
+ default "mmc0boot0"
+
+config SPL_FASTBOOT_MMC_BOOT2_NAME
+ string "Target name for updating eMMC boot partition 2 in SPL"
+ depends on SPL_FASTBOOT_MMC_BOOT_SUPPORT
+ default "mmc0boot1"
+
+config SPL_FASTBOOT_MMC_USER_SUPPORT
+ bool "Enable eMMC user-area flash/erase in SPL"
+ depends on SPL_FASTBOOT_FLASH_MMC
+ help
+ Enable a special fastboot target for flashing or erasing the complete
+ eMMC user area from SPL.
+
+config SPL_FASTBOOT_MMC_USER_NAME
+ string "Target name for updating the eMMC user area in SPL"
+ depends on SPL_FASTBOOT_MMC_USER_SUPPORT
+ default "mmc0"
+
+config SPL_FASTBOOT_GPT_NAME
+ string "Target name for updating GPT from SPL"
+ depends on SPL_FASTBOOT_FLASH_MMC && SPL_EFI_PARTITION
+ default "gpt"
+
+config SPL_FASTBOOT_MBR_NAME
+ string "Target name for updating MBR from SPL"
+ depends on SPL_FASTBOOT_FLASH_MMC && SPL_DOS_PARTITION
+ default "mbr"
+
endmenu
diff --git a/drivers/fastboot/Makefile b/drivers/fastboot/Makefile
index 12008ac05e2..43e391d8ec4 100644
--- a/drivers/fastboot/Makefile
+++ b/drivers/fastboot/Makefile
@@ -3,7 +3,11 @@
obj-y += fb_common.o
obj-y += fb_getvar.o
obj-y += fb_command.o
+ifndef CONFIG_XPL_BUILD
obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += fb_usb.o
+else
+obj-$(CONFIG_SPL_FASTBOOT) += fb_usb.o
+endif
obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_BLOCK) += fb_block.o
# MMC reuses block implementation
obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_MMC) += fb_block.o fb_mmc.o
diff --git a/drivers/fastboot/fb_command.c b/drivers/fastboot/fb_command.c
index 111516fd1b3..4a3cc4cbb27 100644
--- a/drivers/fastboot/fb_command.c
+++ b/drivers/fastboot/fb_command.c
@@ -37,9 +37,9 @@ static void getvar(char *, char *);
static void download(char *, char *);
static void flash(char *, char *);
static void erase(char *, char *);
-static void reboot_bootloader(char *, char *);
-static void reboot_fastbootd(char *, char *);
-static void reboot_recovery(char *, char *);
+static void __maybe_unused reboot_bootloader(char *, char *);
+static void __maybe_unused reboot_fastbootd(char *, char *);
+static void __maybe_unused reboot_recovery(char *, char *);
static void oem_format(char *, char *);
static void oem_partconf(char *, char *);
static void oem_bootbus(char *, char *);
@@ -70,7 +70,9 @@ static const struct {
},
[FASTBOOT_COMMAND_BOOT] = {
.command = "boot",
+#ifndef CONFIG_XPL_BUILD
.dispatch = okay
+#endif
},
[FASTBOOT_COMMAND_CONTINUE] = {
.command = "continue",
@@ -78,19 +80,38 @@ static const struct {
},
[FASTBOOT_COMMAND_REBOOT] = {
.command = "reboot",
+#ifdef CONFIG_XPL_BUILD
+ .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT, (okay), (NULL))
+#else
.dispatch = okay
+#endif
},
[FASTBOOT_COMMAND_REBOOT_BOOTLOADER] = {
.command = "reboot-bootloader",
+#ifdef CONFIG_XPL_BUILD
+ .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT,
+ (reboot_bootloader), (NULL))
+#else
.dispatch = reboot_bootloader
+#endif
},
[FASTBOOT_COMMAND_REBOOT_FASTBOOTD] = {
.command = "reboot-fastboot",
+#ifdef CONFIG_XPL_BUILD
+ .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT,
+ (reboot_fastbootd), (NULL))
+#else
.dispatch = reboot_fastbootd
+#endif
},
[FASTBOOT_COMMAND_REBOOT_RECOVERY] = {
.command = "reboot-recovery",
+#ifdef CONFIG_XPL_BUILD
+ .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT,
+ (reboot_recovery), (NULL))
+#else
.dispatch = reboot_recovery
+#endif
},
[FASTBOOT_COMMAND_SET_ACTIVE] = {
.command = "set_active",
diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
index 3c0013490cc..bd8ba8824de 100644
--- a/drivers/fastboot/fb_common.c
+++ b/drivers/fastboot/fb_common.c
@@ -12,6 +12,7 @@
#include <bcb.h>
#include <command.h>
+#include <cpu_func.h>
#include <env.h>
#include <fastboot.h>
#include <net.h>
@@ -89,6 +90,14 @@ void fastboot_okay(const char *reason, char *response)
* which sets whatever flag your board specific Android bootloader flow
* requires in order to re-enter the bootloader.
*/
+#ifdef CONFIG_XPL_BUILD
+int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
+{
+ (void)reason;
+
+ return -EOPNOTSUPP;
+}
+#else
int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
{
int ret;
@@ -127,6 +136,7 @@ out:
bcb_reset();
return ret;
}
+#endif
/**
* fastboot_get_progress_callback() - Return progress callback
@@ -138,6 +148,7 @@ void (*fastboot_get_progress_callback(void))(const char *)
return fastboot_progress_callback;
}
+#ifndef CONFIG_XPL_BUILD
/**
* fastboot_boot() - Execute fastboot boot command
*
@@ -175,6 +186,7 @@ void fastboot_boot(void)
do_reset(NULL, 0, 0, NULL);
}
}
+#endif /* !CONFIG_XPL_BUILD */
/**
* fastboot_handle_boot() - Shared implementation of system reaction to
@@ -189,12 +201,14 @@ void fastboot_handle_boot(int command, bool success)
return;
switch (command) {
+#ifndef CONFIG_XPL_BUILD
case FASTBOOT_COMMAND_BOOT:
fastboot_boot();
#if CONFIG_IS_ENABLED(NET_LEGACY)
net_set_state(NETLOOP_SUCCESS);
#endif
break;
+#endif
case FASTBOOT_COMMAND_CONTINUE:
#if CONFIG_IS_ENABLED(NET_LEGACY)
@@ -206,7 +220,14 @@ void fastboot_handle_boot(int command, bool success)
case FASTBOOT_COMMAND_REBOOT_BOOTLOADER:
case FASTBOOT_COMMAND_REBOOT_FASTBOOTD:
case FASTBOOT_COMMAND_REBOOT_RECOVERY:
+#ifdef CONFIG_XPL_BUILD
+#if CONFIG_IS_ENABLED(FASTBOOT_REBOOT)
+ /* SPL may omit CMDLINE, so use the platform reset hook directly. */
+ reset_cpu();
+#endif
+#else
do_reset(NULL, 0, 0, NULL);
+#endif
break;
}
}
diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c
index 9e8e8889d08..608a62299af 100644
--- a/drivers/fastboot/fb_getvar.c
+++ b/drivers/fastboot/fb_getvar.c
@@ -240,12 +240,17 @@ static void __maybe_unused getvar_partition_type(char *part_name, char *response
r = fastboot_mmc_get_part_info(part_name, &dev_desc, &part_info,
response);
if (r >= 0) {
+#ifdef CONFIG_XPL_BUILD
+ /* SPL does not pull in filesystem probing just for this getvar. */
+ fastboot_okay("raw", response);
+#else
r = fs_set_blk_dev_with_part(dev_desc, r);
if (r < 0)
/* If we don't know then just default to raw */
fastboot_okay("raw", response);
else
fastboot_okay(fs_get_type_name(), response);
+#endif
}
}
diff --git a/drivers/fastboot/fb_usb.c b/drivers/fastboot/fb_usb.c
index ecb27f28362..37e557365c1 100644
--- a/drivers/fastboot/fb_usb.c
+++ b/drivers/fastboot/fb_usb.c
@@ -40,6 +40,8 @@ int fastboot_usb_run(int controller_index, void *buf_addr, u32 buf_size)
}
while (!g_dnl_detach()) {
+#ifndef CONFIG_XPL_BUILD
+ /* SPL callers own the session lifetime and may have no console. */
if (IS_ENABLED(CONFIG_CMD_FASTBOOT_ABORT_KEYED)) {
if (tstc()) {
getchar();
@@ -49,6 +51,7 @@ int fastboot_usb_run(int controller_index, void *buf_addr, u32 buf_size)
} else if (ctrlc()) {
break;
}
+#endif
schedule();
dm_usb_gadget_handle_interrupts(udc);
}
diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
index f2aebf4e480..87ec0cf6c40 100644
--- a/drivers/usb/gadget/Makefile
+++ b/drivers/usb/gadget/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_$(PHASE_)USB_ETH_RNDIS) += rndis.o
ifdef CONFIG_XPL_BUILD
obj-$(CONFIG_SPL_USB_GADGET) += g_dnl.o
obj-$(CONFIG_SPL_DFU) += f_dfu.o
+obj-$(CONFIG_SPL_FASTBOOT) += f_fastboot.o
obj-$(CONFIG_SPL_USB_SDP_SUPPORT) += f_sdp.o
endif
diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
index 471c0e87042..49cacde9db5 100644
--- a/drivers/usb/gadget/f_fastboot.c
+++ b/drivers/usb/gadget/f_fastboot.c
@@ -490,11 +490,13 @@ static void do_exit_on_complete(struct usb_ep *ep, struct usb_request *req)
g_dnl_trigger_detach();
}
+#ifndef CONFIG_XPL_BUILD
static void do_bootm_on_complete(struct usb_ep *ep, struct usb_request *req)
{
fastboot_boot();
do_exit_on_complete(ep, req);
}
+#endif
static int multiresponse_cmd = -1;
static void multiresponse_on_complete(struct usb_ep *ep, struct usb_request *req)
@@ -560,7 +562,9 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req)
if (!strncmp("OKAY", response, 4)) {
switch (cmd) {
case FASTBOOT_COMMAND_BOOT:
+#ifndef CONFIG_XPL_BUILD
fastboot_func->in_req->complete = do_bootm_on_complete;
+#endif
break;
case FASTBOOT_COMMAND_CONTINUE:
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH RFC v3 5/5] fastboot: add SPL support
2026-07-31 8:29 ` [PATCH RFC v3 5/5] fastboot: add " Carlo Caione
@ 2026-08-17 12:35 ` Mattijs Korpershoek
0 siblings, 0 replies; 11+ messages in thread
From: Mattijs Korpershoek @ 2026-08-17 12:35 UTC (permalink / raw)
To: Carlo Caione, u-boot, GSS_MTK_Uboot_upstream
Cc: Suhrid Subramaniam, Macpaul Lin (林智斌),
Pablo Sun (孫毓翔), Arnaud Ferraris, Tom Rini,
Simon Glass, Sam Day, Quentin Schulz, Carlo Caione, David Lechner,
Vitor Sato Eschholz, Lukasz Majewski, Marek Vasut, Peng Fan,
Jaehoon Chung, Neil Armstrong, Julien Masson, Alexey Charkov,
Adrian Freihofer, Francois Berder, Ilias Apalodimas, Marek Vasut,
Vincent Jardin, Peter Robinson
Hi Carlo,
Thank you for the patch and sorry for the review delays.
On Fri, Jul 31, 2026 at 10:29, Carlo Caione <ccaione@baylibre.com> wrote:
> Some recovery and initial-provisioning flows run before usable firmware
> is available in persistent storage. In these flows the SoC ROM loads a
> small first stage, but that stage must still provide a standard protocol
> with which the host can provision the device.
>
> U-Boot already provides fastboot for this purpose, but its
> implementation is currently restricted to U-Boot proper and coupled
> to command-line support. This forces platforms that need provisioning
> from SPL to maintain a separate downloader or an out-of-tree fastboot
> implementation.
>
> Allow boards to run USB fastboot as a service directly from SPL. Include
> MMC partition flashing and Android sparse-image handling so that the SPL
> service can provision the same storage images accepted by fastboot in
> U-Boot proper.
>
> Keep the SPL interface deliberately narrower. The fastboot boot command
> is not supported because SPL is being used for provisioning rather than
> OS boot orchestration. Filesystem probing is also omitted, so partition
> types are reported as raw. Reboot support remains optional since reset
> and persistent reboot-reason handling are platform-specific.
>
> SPL size remains an important constraint. Make the support entirely
> opt-in and phase-specific: when CONFIG_SPL_FASTBOOT is disabled, no
> fastboot code or supporting library is added to SPL and its binary size
> is unchanged.
>
> Signed-off-by: Julien Masson <jmasson@baylibre.com>
> Signed-off-by: Vitor Sato Eschholz <vsatoes@baylibre.com>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> doc/android/fastboot.rst | 27 ++++++++++++-
> drivers/fastboot/Kconfig | 89 ++++++++++++++++++++++++++++++++++++++++-
> drivers/fastboot/Makefile | 4 ++
> drivers/fastboot/fb_command.c | 27 +++++++++++--
> drivers/fastboot/fb_common.c | 21 ++++++++++
> drivers/fastboot/fb_getvar.c | 5 +++
> drivers/fastboot/fb_usb.c | 3 ++
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/f_fastboot.c | 4 ++
> 9 files changed, 175 insertions(+), 6 deletions(-)
>
> diff --git a/doc/android/fastboot.rst b/doc/android/fastboot.rst
> index 96c544ae11b..885767e450f 100644
> --- a/doc/android/fastboot.rst
> +++ b/doc/android/fastboot.rst
> @@ -10,7 +10,7 @@ The protocol that is used over USB and UDP is described in [1]_.
>
> The current implementation supports the following standard commands:
>
> -- ``boot``
> +- ``boot`` (not available in SPL)
> - ``continue``
> - ``download``
> - ``erase`` (if enabled)
I think there might be other commands that are not available in SPL,
right?
What about oem run, oem console for example?
> @@ -72,6 +72,31 @@ platform. The location of the buffer and size are set with
> may be overridden on the fastboot command line using ``-l`` and
> ``-s``.
>
> +Fastboot in SPL
> +^^^^^^^^^^^^^^^
> +
> +Fastboot can be used from SPL without enabling the command line. Enable
> +``CONFIG_SPL_FASTBOOT`` together with the platform's SPL USB gadget support,
> +then start the session from board code::
> +
> + ret = fastboot_usb_run(controller_index, NULL, 0);
> +
> +A ``NULL`` buffer and zero size select ``CONFIG_FASTBOOT_BUF_ADDR`` and
> +``CONFIG_FASTBOOT_BUF_SIZE``. Passing explicit values overrides these
> +defaults. The ``continue`` command ends the session and returns control to the
> +caller. Unlike the command-line invocation, an SPL session cannot be aborted
> +from the local console.
> +
> +MMC flash and erase support is enabled with
> +``CONFIG_SPL_FASTBOOT_FLASH_MMC``. The SPL partition-table parser matching the
> +storage layout must also be enabled, for example ``CONFIG_SPL_EFI_PARTITION``
> +for GPT.
> +
> +The ``boot`` command is not available in SPL. Reboot commands require
> +``CONFIG_SPL_FASTBOOT_REBOOT`` and a platform ``reset_cpu()`` implementation.
> +The ``reboot-bootloader``, ``reboot-fastboot`` and ``reboot-recovery`` commands
[...]
> +
> +config SPL_FASTBOOT_GPT_NAME
> + string "Target name for updating GPT from SPL"
> + depends on SPL_FASTBOOT_FLASH_MMC && SPL_EFI_PARTITION
> + default "gpt"
> +
> +config SPL_FASTBOOT_MBR_NAME
> + string "Target name for updating MBR from SPL"
> + depends on SPL_FASTBOOT_FLASH_MMC && SPL_DOS_PARTITION
> + default "mbr"
> +
> endmenu
> diff --git a/drivers/fastboot/Makefile b/drivers/fastboot/Makefile
> index 12008ac05e2..43e391d8ec4 100644
> --- a/drivers/fastboot/Makefile
> +++ b/drivers/fastboot/Makefile
> @@ -3,7 +3,11 @@
> obj-y += fb_common.o
> obj-y += fb_getvar.o
> obj-y += fb_command.o
> +ifndef CONFIG_XPL_BUILD
Can we drop the negation and invert the logic please?
It's easier to read the other way around.
> obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += fb_usb.o
> +else
> +obj-$(CONFIG_SPL_FASTBOOT) += fb_usb.o
> +endif
> obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_BLOCK) += fb_block.o
> # MMC reuses block implementation
> obj-$(CONFIG_$(PHASE_)FASTBOOT_FLASH_MMC) += fb_block.o fb_mmc.o
> diff --git a/drivers/fastboot/fb_command.c b/drivers/fastboot/fb_command.c
> index 111516fd1b3..4a3cc4cbb27 100644
> --- a/drivers/fastboot/fb_command.c
> +++ b/drivers/fastboot/fb_command.c
> @@ -37,9 +37,9 @@ static void getvar(char *, char *);
> static void download(char *, char *);
> static void flash(char *, char *);
> static void erase(char *, char *);
> -static void reboot_bootloader(char *, char *);
> -static void reboot_fastbootd(char *, char *);
> -static void reboot_recovery(char *, char *);
> +static void __maybe_unused reboot_bootloader(char *, char *);
> +static void __maybe_unused reboot_fastbootd(char *, char *);
> +static void __maybe_unused reboot_recovery(char *, char *);
Please follow the file conventions and move the __maybe_unused to
the function definition instead.
See, for example:
static void __maybe_unused oem_format(char *cmd_parameter, char *response)
> static void oem_format(char *, char *);
> static void oem_partconf(char *, char *);
> static void oem_bootbus(char *, char *);
> @@ -70,7 +70,9 @@ static const struct {
> },
> [FASTBOOT_COMMAND_BOOT] = {
> .command = "boot",
> +#ifndef CONFIG_XPL_BUILD
> .dispatch = okay
> +#endif
I'm not super fan of the ifdeffery here and below.
Can we consider creating an alternative SPL specific command array?
This might add some code duplication but will it make easier to
identify which commands are supported in SPL and which are in proper.
Or alternatively, have a .dispatch and a .dispatch_xpl ?
> },
> [FASTBOOT_COMMAND_CONTINUE] = {
> .command = "continue",
> @@ -78,19 +80,38 @@ static const struct {
> },
> [FASTBOOT_COMMAND_REBOOT] = {
> .command = "reboot",
> +#ifdef CONFIG_XPL_BUILD
> + .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT, (okay), (NULL))
> +#else
> .dispatch = okay
> +#endif
> },
> [FASTBOOT_COMMAND_REBOOT_BOOTLOADER] = {
> .command = "reboot-bootloader",
> +#ifdef CONFIG_XPL_BUILD
> + .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT,
> + (reboot_bootloader), (NULL))
> +#else
> .dispatch = reboot_bootloader
> +#endif
> },
> [FASTBOOT_COMMAND_REBOOT_FASTBOOTD] = {
> .command = "reboot-fastboot",
> +#ifdef CONFIG_XPL_BUILD
> + .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT,
> + (reboot_fastbootd), (NULL))
> +#else
> .dispatch = reboot_fastbootd
> +#endif
> },
> [FASTBOOT_COMMAND_REBOOT_RECOVERY] = {
> .command = "reboot-recovery",
> +#ifdef CONFIG_XPL_BUILD
> + .dispatch = CONFIG_IS_ENABLED(FASTBOOT_REBOOT,
> + (reboot_recovery), (NULL))
> +#else
> .dispatch = reboot_recovery
> +#endif
> },
> [FASTBOOT_COMMAND_SET_ACTIVE] = {
> .command = "set_active",
> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
> index 3c0013490cc..bd8ba8824de 100644
> --- a/drivers/fastboot/fb_common.c
> +++ b/drivers/fastboot/fb_common.c
> @@ -12,6 +12,7 @@
>
> #include <bcb.h>
> #include <command.h>
> +#include <cpu_func.h>
> #include <env.h>
> #include <fastboot.h>
> #include <net.h>
> @@ -89,6 +90,14 @@ void fastboot_okay(const char *reason, char *response)
> * which sets whatever flag your board specific Android bootloader flow
> * requires in order to re-enter the bootloader.
> */
> +#ifdef CONFIG_XPL_BUILD
> +int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
> +{
> + (void)reason;
Is the void cast needed? Can't we use __maybe_unused in the function
prototype?
Also, why do we need it alltogether? It looks like most stub functions
I've found don't do this.
> +
> + return -EOPNOTSUPP;
> +}
> +#else
> int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
> {
> int ret;
> @@ -127,6 +136,7 @@ out:
> bcb_reset();
> return ret;
> }
> +#endif
>
> /**
> * fastboot_get_progress_callback() - Return progress callback
> @@ -138,6 +148,7 @@ void (*fastboot_get_progress_callback(void))(const char *)
> return fastboot_progress_callback;
> }
>
> +#ifndef CONFIG_XPL_BUILD
> /**
> * fastboot_boot() - Execute fastboot boot command
> *
> @@ -175,6 +186,7 @@ void fastboot_boot(void)
> do_reset(NULL, 0, 0, NULL);
> }
> }
> +#endif /* !CONFIG_XPL_BUILD */
Some #endif have this extra comment. Some others don't.
Can we please be consistent about this?
>
> /**
> * fastboot_handle_boot() - Shared implementation of system reaction to
> @@ -189,12 +201,14 @@ void fastboot_handle_boot(int command, bool success)
> return;
>
> switch (command) {
> +#ifndef CONFIG_XPL_BUILD
> case FASTBOOT_COMMAND_BOOT:
> fastboot_boot();
> #if CONFIG_IS_ENABLED(NET_LEGACY)
> net_set_state(NETLOOP_SUCCESS);
> #endif
> break;
> +#endif
>
> case FASTBOOT_COMMAND_CONTINUE:
> #if CONFIG_IS_ENABLED(NET_LEGACY)
> @@ -206,7 +220,14 @@ void fastboot_handle_boot(int command, bool success)
> case FASTBOOT_COMMAND_REBOOT_BOOTLOADER:
> case FASTBOOT_COMMAND_REBOOT_FASTBOOTD:
> case FASTBOOT_COMMAND_REBOOT_RECOVERY:
> +#ifdef CONFIG_XPL_BUILD
> +#if CONFIG_IS_ENABLED(FASTBOOT_REBOOT)
> + /* SPL may omit CMDLINE, so use the platform reset hook directly. */
> + reset_cpu();
> +#endif
[...]
>
> --
> 2.55.0
^ permalink raw reply [flat|nested] 11+ messages in thread