All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Gabor Juhos <j4g8y7@gmail.com>
Cc: Santhosh Kumar K <s-k6@ti.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org,  Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH v2] mtd: core: always verify OOB offset in mtd_check_oob_ops()
Date: Thu, 11 Sep 2025 16:03:39 +0200	[thread overview]
Message-ID: <87frct9jd0.fsf@bootlin.com> (raw)
In-Reply-To: <a208824c-acf6-4a48-8fde-f9926a6e4db5@gmail.com> (Gabor Juhos's message of "Thu, 11 Sep 2025 10:33:48 +0200")

Hello,

>>>> Applied to mtd/next, thanks!
>>>> [1/1] mtd: core: always verify OOB offset in mtd_check_oob_ops()
>>>>        commit: bf7d0543b2602be5cb450d8ec5a8710787806f88
>>>
>>> I'm seeing a failure in SPI NOR flashes due to this patch:
>>> (Tested on AM62x SK with S28HS512T OSPI NOR flash)
>
> Sorry for the inconvenience.
>
>> Gabor, can you check what happens with mtdblock?
>
> The strange thing is that it works with (SPI) NAND flashes:
>
> # cat /sys/class/mtd/mtd0/type
> nand
> # cat /sys/class/mtd/mtd0/oobavail
> 0
> #
> # hexdump -n 2048 /dev/mtd0

This is not mtdblock, the report was using mtdblock, not mtd directly. I
don't know if that actually makes a difference, but it is worth the try.

Santhosh, please send a revert for now.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Gabor Juhos <j4g8y7@gmail.com>
Cc: Santhosh Kumar K <s-k6@ti.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org,  Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH v2] mtd: core: always verify OOB offset in mtd_check_oob_ops()
Date: Thu, 11 Sep 2025 16:03:39 +0200	[thread overview]
Message-ID: <87frct9jd0.fsf@bootlin.com> (raw)
In-Reply-To: <a208824c-acf6-4a48-8fde-f9926a6e4db5@gmail.com> (Gabor Juhos's message of "Thu, 11 Sep 2025 10:33:48 +0200")

Hello,

>>>> Applied to mtd/next, thanks!
>>>> [1/1] mtd: core: always verify OOB offset in mtd_check_oob_ops()
>>>>        commit: bf7d0543b2602be5cb450d8ec5a8710787806f88
>>>
>>> I'm seeing a failure in SPI NOR flashes due to this patch:
>>> (Tested on AM62x SK with S28HS512T OSPI NOR flash)
>
> Sorry for the inconvenience.
>
>> Gabor, can you check what happens with mtdblock?
>
> The strange thing is that it works with (SPI) NAND flashes:
>
> # cat /sys/class/mtd/mtd0/type
> nand
> # cat /sys/class/mtd/mtd0/oobavail
> 0
> #
> # hexdump -n 2048 /dev/mtd0

This is not mtdblock, the report was using mtdblock, not mtd directly. I
don't know if that actually makes a difference, but it is worth the try.

Santhosh, please send a revert for now.

Thanks,
Miquèl

  parent reply	other threads:[~2025-09-11 14:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01 14:24 [PATCH v2] mtd: core: always verify OOB offset in mtd_check_oob_ops() Gabor Juhos
2025-09-01 14:24 ` Gabor Juhos
2025-09-05 14:55 ` Miquel Raynal
2025-09-05 14:55   ` Miquel Raynal
2025-09-11  6:22   ` Santhosh Kumar K
2025-09-11  6:22     ` Santhosh Kumar K
2025-09-11  8:00     ` Miquel Raynal
2025-09-11  8:00       ` Miquel Raynal
2025-09-11  8:33       ` Gabor Juhos
2025-09-11  8:33         ` Gabor Juhos
2025-09-11 13:03         ` Pratyush Yadav
2025-09-11 13:03           ` Pratyush Yadav
2025-09-11 14:05           ` Miquel Raynal
2025-09-11 14:05             ` Miquel Raynal
2025-09-11 15:33             ` Miquel Raynal
2025-09-11 15:33               ` Miquel Raynal
2025-09-11 14:03         ` Miquel Raynal [this message]
2025-09-11 14:03           ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frct9jd0.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=daniel@makrotopia.org \
    --cc=j4g8y7@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=s-k6@ti.com \
    --cc=stable@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.