* [PATCH] docs: trace: decode_msr.py: make it compatible with python 3
@ 2025-02-11 7:00 Mauro Carvalho Chehab
2025-02-13 16:46 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2025-02-11 7:00 UTC (permalink / raw)
To: Linux Doc Mailing List, Jonathan Corbet
Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab, linux-kernel
This script uses print <foo> instead of print(foo), which is
incompatible with Python 3.
Fix it.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
Documentation/trace/postprocess/decode_msr.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/trace/postprocess/decode_msr.py b/Documentation/trace/postprocess/decode_msr.py
index aa9cc7abd5c2..f5609b16f589 100644
--- a/Documentation/trace/postprocess/decode_msr.py
+++ b/Documentation/trace/postprocess/decode_msr.py
@@ -32,6 +32,6 @@ for j in sys.stdin:
break
if r:
j = j.replace(" " + m.group(2), " " + r + "(" + m.group(2) + ")")
- print j,
+ print(j)
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] docs: trace: decode_msr.py: make it compatible with python 3
2025-02-11 7:00 [PATCH] docs: trace: decode_msr.py: make it compatible with python 3 Mauro Carvalho Chehab
@ 2025-02-13 16:46 ` Jonathan Corbet
2025-02-21 17:53 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2025-02-13 16:46 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Doc Mailing List
Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab, linux-kernel
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:
> This script uses print <foo> instead of print(foo), which is
> incompatible with Python 3.
>
> Fix it.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> Documentation/trace/postprocess/decode_msr.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/postprocess/decode_msr.py b/Documentation/trace/postprocess/decode_msr.py
> index aa9cc7abd5c2..f5609b16f589 100644
> --- a/Documentation/trace/postprocess/decode_msr.py
> +++ b/Documentation/trace/postprocess/decode_msr.py
> @@ -32,6 +32,6 @@ for j in sys.stdin:
> break
> if r:
> j = j.replace(" " + m.group(2), " " + r + "(" + m.group(2) + ")")
> - print j,
> + print(j)
This does make me wonder when this script was last used ... it hasn't
seen a real change since it was added in 2015. Oh well, it should at
least work with current Python ... applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] docs: trace: decode_msr.py: make it compatible with python 3
2025-02-13 16:46 ` Jonathan Corbet
@ 2025-02-21 17:53 ` Pavel Machek
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2025-02-21 17:53 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Mauro Carvalho Chehab, Linux Doc Mailing List, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
On Thu 2025-02-13 09:46:42, Jonathan Corbet wrote:
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:
>
> > This script uses print <foo> instead of print(foo), which is
> > incompatible with Python 3.
> >
> > Fix it.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > ---
> > Documentation/trace/postprocess/decode_msr.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/trace/postprocess/decode_msr.py b/Documentation/trace/postprocess/decode_msr.py
> > index aa9cc7abd5c2..f5609b16f589 100644
> > --- a/Documentation/trace/postprocess/decode_msr.py
> > +++ b/Documentation/trace/postprocess/decode_msr.py
> > @@ -32,6 +32,6 @@ for j in sys.stdin:
> > break
> > if r:
> > j = j.replace(" " + m.group(2), " " + r + "(" + m.group(2) + ")")
> > - print j,
> > + print(j)
>
> This does make me wonder when this script was last used ... it hasn't
> seen a real change since it was added in 2015. Oh well, it should at
> least work with current Python ... applied, thanks.
This conversion is wrong, AFACIT. Old code one avoids adding \n, new
adds it.
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-21 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-11 7:00 [PATCH] docs: trace: decode_msr.py: make it compatible with python 3 Mauro Carvalho Chehab
2025-02-13 16:46 ` Jonathan Corbet
2025-02-21 17:53 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.