From: Kalle Valo <kvalo@kernel.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: shayne.chen@mediatek.com, linux-wireless@vger.kernel.org,
nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com,
evelyn.tsai@mediatek.com, linux-mediatek@lists.infradead.org
Subject: Re: Aw: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
Date: Wed, 08 Jan 2025 11:46:58 +0200 [thread overview]
Message-ID: <87frltr625.fsf@kernel.org> (raw)
In-Reply-To: <trinity-0eec3a68-fc9a-4ec6-8c95-1cd58f3bcff8-1735990797237@trinity-msg-rest-gmx-gmx-live-bbc95d94c-9m2wx> (Frank Wunderlich's message of "Sat, 4 Jan 2025 11:39:57 +0000")
Frank Wunderlich <frank-w@public-files.de> writes:
> Hi
>
> this seems still not merged to next.
>
> can wireless/mtk Maintainer please pick this up?
>
>> Gesendet: Mittwoch, 9. Oktober 2024 um 19:23
>> Betreff: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
>>
>> Hi Shayne
>>
>> > Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr
>> > Von: "Shayne Chen" <shayne.chen@mediatek.com>
>> > Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
>> >
>> > Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
>> > combination is invalid, which will trigger the following warning trace
>> > and get error returned from wiphy_register().
>> >
>> > [ 10.080325] Call trace:
>> > [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
>> > [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
>> > [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
>> > [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
>> >
>> > Fix this by removing unused adhoc iftype.
>> >
>> > Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
>> > Reported-by: Frank Wunderlich <frank-w@public-files.de>
>> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
>>
>> thx for the patch. I can confirm it fixes the issue/trace.
>
> if tested-by is necessary:
>
> Tested-By: Frank Wunderlich <frank-w@public-files.de>
Felix, should I take this directly to wireless-next? Ack?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2025-01-08 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 13:51 [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations Shayne Chen
2024-10-07 13:51 ` Shayne Chen
2024-10-09 17:23 ` Aw: " Frank Wunderlich
2025-01-04 11:39 ` Aw: " Frank Wunderlich
2025-01-08 9:46 ` Kalle Valo [this message]
2025-01-10 12:49 ` Kalle Valo
2025-01-10 12:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frltr625.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=evelyn.tsai@mediatek.com \
--cc=frank-w@public-files.de \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.