* [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
@ 2024-10-07 13:51 ` Shayne Chen
0 siblings, 0 replies; 7+ messages in thread
From: Shayne Chen @ 2024-10-07 13:51 UTC (permalink / raw)
To: linux-wireless
Cc: Ryder Lee, Evelyn Tsai, linux-mediatek, Shayne Chen,
Lorenzo Bianconi, Felix Fietkau
Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
combination is invalid, which will trigger the following warning trace
and get error returned from wiphy_register().
[ 10.080325] Call trace:
[ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
[ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
[ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
[ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
Fix this by removing unused adhoc iftype.
Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt7996/init.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/init.c b/drivers/net/wireless/mediatek/mt76/mt7996/init.c
index f6a010b61a8a..2d36c7325137 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/init.c
@@ -16,9 +16,6 @@
static const struct ieee80211_iface_limit if_limits[] = {
{
- .max = 1,
- .types = BIT(NL80211_IFTYPE_ADHOC)
- }, {
.max = 16,
.types = BIT(NL80211_IFTYPE_AP)
#ifdef CONFIG_MAC80211_MESH
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
@ 2024-10-07 13:51 ` Shayne Chen
0 siblings, 0 replies; 7+ messages in thread
From: Shayne Chen @ 2024-10-07 13:51 UTC (permalink / raw)
To: linux-wireless
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Evelyn Tsai,
linux-mediatek, Frank Wunderlich, Shayne Chen
Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
combination is invalid, which will trigger the following warning trace
and get error returned from wiphy_register().
[ 10.080325] Call trace:
[ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
[ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
[ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
[ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
Fix this by removing unused adhoc iftype.
Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt7996/init.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/init.c b/drivers/net/wireless/mediatek/mt76/mt7996/init.c
index f6a010b61a8a..2d36c7325137 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/init.c
@@ -16,9 +16,6 @@
static const struct ieee80211_iface_limit if_limits[] = {
{
- .max = 1,
- .types = BIT(NL80211_IFTYPE_ADHOC)
- }, {
.max = 16,
.types = BIT(NL80211_IFTYPE_AP)
#ifdef CONFIG_MAC80211_MESH
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
2024-10-07 13:51 ` Shayne Chen
(?)
@ 2024-10-09 17:23 ` Frank Wunderlich
2025-01-04 11:39 ` Aw: " Frank Wunderlich
-1 siblings, 1 reply; 7+ messages in thread
From: Frank Wunderlich @ 2024-10-09 17:23 UTC (permalink / raw)
To: Shayne Chen
Cc: linux-wireless, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Evelyn Tsai, linux-mediatek, Shayne Chen
Hi Shayne
> Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr
> Von: "Shayne Chen" <shayne.chen@mediatek.com>
> Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
>
> Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
> combination is invalid, which will trigger the following warning trace
> and get error returned from wiphy_register().
>
> [ 10.080325] Call trace:
> [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
> [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
> [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
> [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
>
> Fix this by removing unused adhoc iftype.
>
> Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
thx for the patch. I can confirm it fixes the issue/trace.
regards
^ permalink raw reply [flat|nested] 7+ messages in thread* Aw: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
2024-10-09 17:23 ` Aw: " Frank Wunderlich
@ 2025-01-04 11:39 ` Frank Wunderlich
2025-01-08 9:46 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Frank Wunderlich @ 2025-01-04 11:39 UTC (permalink / raw)
To: frank-w, shayne.chen
Cc: linux-wireless, nbd, lorenzo, ryder.lee, evelyn.tsai,
linux-mediatek, shayne.chen
Hi
this seems still not merged to next.
can wireless/mtk Maintainer please pick this up?
> Gesendet: Mittwoch, 9. Oktober 2024 um 19:23
> Betreff: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
>
> Hi Shayne
>
> > Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr
> > Von: "Shayne Chen" <shayne.chen@mediatek.com>
> > Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
> >
> > Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
> > combination is invalid, which will trigger the following warning trace
> > and get error returned from wiphy_register().
> >
> > [ 10.080325] Call trace:
> > [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
> > [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
> > [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
> > [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
> >
> > Fix this by removing unused adhoc iftype.
> >
> > Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
> > Reported-by: Frank Wunderlich <frank-w@public-files.de>
> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
>
> thx for the patch. I can confirm it fixes the issue/trace.
if tested-by is necessary:
Tested-By: Frank Wunderlich <frank-w@public-files.de>
> regards
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Aw: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
2025-01-04 11:39 ` Aw: " Frank Wunderlich
@ 2025-01-08 9:46 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2025-01-08 9:46 UTC (permalink / raw)
To: Frank Wunderlich
Cc: shayne.chen, linux-wireless, nbd, lorenzo, ryder.lee, evelyn.tsai,
linux-mediatek
Frank Wunderlich <frank-w@public-files.de> writes:
> Hi
>
> this seems still not merged to next.
>
> can wireless/mtk Maintainer please pick this up?
>
>> Gesendet: Mittwoch, 9. Oktober 2024 um 19:23
>> Betreff: Aw: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
>>
>> Hi Shayne
>>
>> > Gesendet: Montag, 07. Oktober 2024 um 15:51 Uhr
>> > Von: "Shayne Chen" <shayne.chen@mediatek.com>
>> > Betreff: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
>> >
>> > Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
>> > combination is invalid, which will trigger the following warning trace
>> > and get error returned from wiphy_register().
>> >
>> > [ 10.080325] Call trace:
>> > [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
>> > [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
>> > [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
>> > [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
>> >
>> > Fix this by removing unused adhoc iftype.
>> >
>> > Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
>> > Reported-by: Frank Wunderlich <frank-w@public-files.de>
>> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
>>
>> thx for the patch. I can confirm it fixes the issue/trace.
>
> if tested-by is necessary:
>
> Tested-By: Frank Wunderlich <frank-w@public-files.de>
Felix, should I take this directly to wireless-next? Ack?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
2024-10-07 13:51 ` Shayne Chen
@ 2025-01-10 12:49 ` Kalle Valo
-1 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2025-01-10 12:49 UTC (permalink / raw)
To: Shayne Chen
Cc: Ryder Lee, Evelyn Tsai, linux-wireless, linux-mediatek,
Shayne Chen, Lorenzo Bianconi, Felix Fietkau
Shayne Chen <shayne.chen@mediatek.com> wrote:
> Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
> combination is invalid, which will trigger the following warning trace
> and get error returned from wiphy_register().
>
> [ 10.080325] Call trace:
> [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
> [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
> [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
> [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
>
> Fix this by removing unused adhoc iftype.
>
> Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> Tested-By: Frank Wunderlich <frank-w@public-files.de>
Patch applied to wireless-next.git, thanks.
89aca45f2687 wifi: mt76: mt7996: fix invalid interface combinations
--
https://patchwork.kernel.org/project/linux-wireless/patch/20241007135133.5336-1-shayne.chen@mediatek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations
@ 2025-01-10 12:49 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2025-01-10 12:49 UTC (permalink / raw)
To: Shayne Chen
Cc: linux-wireless, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Evelyn Tsai, linux-mediatek, Frank Wunderlich, Shayne Chen
Shayne Chen <shayne.chen@mediatek.com> wrote:
> Setting beacon_int_min_gcd and NL80211_IFTYPE_ADHOC in the same interface
> combination is invalid, which will trigger the following warning trace
> and get error returned from wiphy_register().
>
> [ 10.080325] Call trace:
> [ 10.082761] wiphy_register+0xc4/0x76c [cfg80211]
> [ 10.087465] ieee80211_register_hw+0x800/0xac4 [mac80211]
> [ 10.092868] mt76_register_device+0x16c/0x2c0 [mt76]
> [ 10.097829] mt7996_register_device+0x740/0x844 [mt7996e]
>
> Fix this by removing unused adhoc iftype.
>
> Fixes: 948f65249868 ("wifi: mt76: mt7996: advertize beacon_int_min_gcd")
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> Tested-By: Frank Wunderlich <frank-w@public-files.de>
Patch applied to wireless-next.git, thanks.
89aca45f2687 wifi: mt76: mt7996: fix invalid interface combinations
--
https://patchwork.kernel.org/project/linux-wireless/patch/20241007135133.5336-1-shayne.chen@mediatek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-01-10 13:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 13:51 [PATCH wireless] wifi: mt76: mt7996: fix invalid interface combinations Shayne Chen
2024-10-07 13:51 ` Shayne Chen
2024-10-09 17:23 ` Aw: " Frank Wunderlich
2025-01-04 11:39 ` Aw: " Frank Wunderlich
2025-01-08 9:46 ` Kalle Valo
2025-01-10 12:49 ` Kalle Valo
2025-01-10 12:49 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.