[PATCH] powerpc: remove dead config options for MPC85xx platform support

[PATCH] powerpc: remove dead config options for MPC85xx platform support

[Lukas Bulwahn]

From: Lukas Bulwahn <lukas.bulwahn@redhat.com>

Commit 384e338a9187 ("powerpc: drop MPC8540_ADS and MPC8560_ADS platform
support") and commit b751ed04bc5e ("powerpc: drop MPC85xx_CDS platform
support") removes the platform support for MPC8540_ADS, MPC8560_ADS and
MPC85xx_CDS in the source tree, but misses to remove the config options in
the Kconfig file. Hence, these three config options are without any effect
since then.

Drop these three dead config options.

Fixes: 384e338a9187 ("powerpc: drop MPC8540_ADS and MPC8560_ADS platform support")
Fixes: b751ed04bc5e ("powerpc: drop MPC85xx_CDS platform support")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
 arch/powerpc/platforms/85xx/Kconfig | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
index 9315a3b69d6d..604c1b4b6d45 100644
--- a/arch/powerpc/platforms/85xx/Kconfig
+++ b/arch/powerpc/platforms/85xx/Kconfig
@@ -40,27 +40,6 @@ config BSC9132_QDS
 	  and dual StarCore SC3850 DSP cores.
 	  Manufacturer : Freescale Semiconductor, Inc
 
-config MPC8540_ADS
-	bool "Freescale MPC8540 ADS"
-	select DEFAULT_UIMAGE
-	help
-	  This option enables support for the MPC 8540 ADS board
-
-config MPC8560_ADS
-	bool "Freescale MPC8560 ADS"
-	select DEFAULT_UIMAGE
-	select CPM2
-	help
-	  This option enables support for the MPC 8560 ADS board
-
-config MPC85xx_CDS
-	bool "Freescale MPC85xx CDS"
-	select DEFAULT_UIMAGE
-	select PPC_I8259
-	select HAVE_RAPIDIO
-	help
-	  This option enables support for the MPC85xx CDS board
-
 config MPC85xx_MDS
 	bool "Freescale MPC8568 MDS / MPC8569 MDS / P1021 MDS"
 	select DEFAULT_UIMAGE
-- 
2.46.1

Re: [PATCH] powerpc: remove dead config options for MPC85xx platform support

[Ritesh Harjani]

Lukas Bulwahn <lbulwahn@redhat.com> writes:

> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> Commit 384e338a9187 ("powerpc: drop MPC8540_ADS and MPC8560_ADS platform
> support") and commit b751ed04bc5e ("powerpc: drop MPC85xx_CDS platform
> support") removes the platform support for MPC8540_ADS, MPC8560_ADS and
> MPC85xx_CDS in the source tree, but misses to remove the config options in
> the Kconfig file. Hence, these three config options are without any effect
> since then.
>
> Drop these three dead config options.
>

Indeed these looks to be dead config remaining.

> Fixes: 384e338a9187 ("powerpc: drop MPC8540_ADS and MPC8560_ADS platform support")
> Fixes: b751ed04bc5e ("powerpc: drop MPC85xx_CDS platform support")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
>  arch/powerpc/platforms/85xx/Kconfig | 21 ---------------------
>  1 file changed, 21 deletions(-)

I couldn't find any relevant reference of MPC8540_ADS, MPC8560_ADS or MPC85xx_CDS
after this patch

So please feel free to add - 

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

>
> diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
> index 9315a3b69d6d..604c1b4b6d45 100644
> --- a/arch/powerpc/platforms/85xx/Kconfig
> +++ b/arch/powerpc/platforms/85xx/Kconfig
> @@ -40,27 +40,6 @@ config BSC9132_QDS
>  	  and dual StarCore SC3850 DSP cores.
>  	  Manufacturer : Freescale Semiconductor, Inc
>  
> -config MPC8540_ADS
> -	bool "Freescale MPC8540 ADS"
> -	select DEFAULT_UIMAGE
> -	help
> -	  This option enables support for the MPC 8540 ADS board
> -
> -config MPC8560_ADS
> -	bool "Freescale MPC8560 ADS"
> -	select DEFAULT_UIMAGE
> -	select CPM2
> -	help
> -	  This option enables support for the MPC 8560 ADS board
> -
> -config MPC85xx_CDS
> -	bool "Freescale MPC85xx CDS"
> -	select DEFAULT_UIMAGE
> -	select PPC_I8259
> -	select HAVE_RAPIDIO
> -	help
> -	  This option enables support for the MPC85xx CDS board
> -
>  config MPC85xx_MDS
>  	bool "Freescale MPC8568 MDS / MPC8569 MDS / P1021 MDS"
>  	select DEFAULT_UIMAGE
> -- 
> 2.46.1

Re: [PATCH] powerpc: remove dead config options for MPC85xx platform support

[Michael Ellerman]

On Fri, 27 Sep 2024 11:52:03 +0200, Lukas Bulwahn wrote:
> Commit 384e338a9187 ("powerpc: drop MPC8540_ADS and MPC8560_ADS platform
> support") and commit b751ed04bc5e ("powerpc: drop MPC85xx_CDS platform
> support") removes the platform support for MPC8540_ADS, MPC8560_ADS and
> MPC85xx_CDS in the source tree, but misses to remove the config options in
> the Kconfig file. Hence, these three config options are without any effect
> since then.
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc: remove dead config options for MPC85xx platform support
      https://git.kernel.org/powerpc/c/f20b0a03674cef555a5f48b65f81b82868b17cdd

cheers