[PATCH] drm/tegra: fix potential uninitialized variable use

[PATCH] drm/tegra: fix potential uninitialized variable use

[Jani Nikula]

It's likely either output->drm_edid or output->ddc is non-NULL, but
avoid the uninitialized variable usage anyway.

Reported-by: kernel test robot <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/ZtXLyXxew7z6H2bD@stanley.mountain
Fixes: 98365ca74cbf ("drm/tegra: convert to struct drm_edid")
Cc: Thierry Reding <treding@nvidia.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/tegra/output.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c
index e6b5863fec71..49e4f63a5550 100644
--- a/drivers/gpu/drm/tegra/output.c
+++ b/drivers/gpu/drm/tegra/output.c
@@ -21,7 +21,7 @@
 int tegra_output_connector_get_modes(struct drm_connector *connector)
 {
 	struct tegra_output *output = connector_to_output(connector);
-	const struct drm_edid *drm_edid;
+	const struct drm_edid *drm_edid = NULL;
 	int err = 0;
 
 	/*
-- 
2.39.2

Re: [PATCH] drm/tegra: fix potential uninitialized variable use

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

On Mon, Sep 02, 2024 at 07:13:17PM GMT, Jani Nikula wrote:
> It's likely either output->drm_edid or output->ddc is non-NULL, but
> avoid the uninitialized variable usage anyway.
> 
> Reported-by: kernel test robot <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/ZtXLyXxew7z6H2bD@stanley.mountain
> Fixes: 98365ca74cbf ("drm/tegra: convert to struct drm_edid")
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/tegra/output.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Do you want to apply this or should I? In the former case:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] drm/tegra: fix potential uninitialized variable use

[Jani Nikula]

On Tue, 03 Sep 2024, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Sep 02, 2024 at 07:13:17PM GMT, Jani Nikula wrote:
>> It's likely either output->drm_edid or output->ddc is non-NULL, but
>> avoid the uninitialized variable usage anyway.
>> 
>> Reported-by: kernel test robot <dan.carpenter@linaro.org>
>> Closes: https://lore.kernel.org/r/ZtXLyXxew7z6H2bD@stanley.mountain
>> Fixes: 98365ca74cbf ("drm/tegra: convert to struct drm_edid")
>> Cc: Thierry Reding <treding@nvidia.com>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: linux-tegra@vger.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/tegra/output.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Do you want to apply this or should I? In the former case:
>
> Acked-by: Thierry Reding <treding@nvidia.com>

Thanks, pushed to drm-misc-next.

BR,
Jani.

-- 
Jani Nikula, Intel