All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: <ath11k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] wifi: ath11k: fix CAC running state during virtual interface start
Date: Thu, 14 Sep 2023 16:16:21 +0300	[thread overview]
Message-ID: <87fs3gdhei.fsf@kernel.org> (raw)
In-Reply-To: <a7ba84fe-4ac8-4842-8e46-093ebc4e7014@quicinc.com> (Aditya Kumar Singh's message of "Wed, 13 Sep 2023 18:55:02 +0530")

Aditya Kumar Singh <quic_adisi@quicinc.com> writes:

> On 6/7/23 18:16, Aditya Kumar Singh wrote:
>> Currently channel definition's primary channel's DFS CAC time
>> as well as primary channel's state i.e usable are used to set
>> the CAC_RUNNING flag for the ath11k radio structure. However,
>> this is wrong since certain channel definition are possbile
>> where primary channel may not be a DFS channel but, secondary
>> channel is a DFS channel. For example - channel 36 with 160 MHz
>> bandwidth.
>> In such cases, the flag will not be set which is wrong.
>> Fix this issue by using cfg80211_chandef_dfs_usable() function
>> from cfg80211 which return trues if at least one channel is in
>> usable state.
>> While at it, modify the CAC running debug log message to print
>> the CAC time as well in milli-seconds.
>> Tested-on: QCN9074 hw1.0 PCI
>> WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> Hi Kalle,
>
> The upstream dependency got merged today. I have sent [v2] of this
> series which was just rebased on latest ToT and the [PATCH v2 1/3] got
> merged. With this, [PATCH v2 2/3] and [PATCH v2 3/3] are unblocked
> now.

Thanks, this is helpful. I still need to merge wireless-next into
ath-next but hopefully that happens next week.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] wifi: ath11k: fix CAC running state during virtual interface start
Date: Thu, 14 Sep 2023 16:16:21 +0300	[thread overview]
Message-ID: <87fs3gdhei.fsf@kernel.org> (raw)
In-Reply-To: <a7ba84fe-4ac8-4842-8e46-093ebc4e7014@quicinc.com> (Aditya Kumar Singh's message of "Wed, 13 Sep 2023 18:55:02 +0530")

Aditya Kumar Singh <quic_adisi@quicinc.com> writes:

> On 6/7/23 18:16, Aditya Kumar Singh wrote:
>> Currently channel definition's primary channel's DFS CAC time
>> as well as primary channel's state i.e usable are used to set
>> the CAC_RUNNING flag for the ath11k radio structure. However,
>> this is wrong since certain channel definition are possbile
>> where primary channel may not be a DFS channel but, secondary
>> channel is a DFS channel. For example - channel 36 with 160 MHz
>> bandwidth.
>> In such cases, the flag will not be set which is wrong.
>> Fix this issue by using cfg80211_chandef_dfs_usable() function
>> from cfg80211 which return trues if at least one channel is in
>> usable state.
>> While at it, modify the CAC running debug log message to print
>> the CAC time as well in milli-seconds.
>> Tested-on: QCN9074 hw1.0 PCI
>> WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> Hi Kalle,
>
> The upstream dependency got merged today. I have sent [v2] of this
> series which was just rebased on latest ToT and the [PATCH v2 1/3] got
> merged. With this, [PATCH v2 2/3] and [PATCH v2 3/3] are unblocked
> now.

Thanks, this is helpful. I still need to merge wireless-next into
ath-next but hopefully that happens next week.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-09-14 13:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07 12:46 [PATCH 0/3] wifi: ath11k: fix CAC running state Aditya Kumar Singh
2023-06-07 12:46 ` Aditya Kumar Singh
2023-06-07 12:46 ` [PATCH 1/3] wifi: cfg80211: export DFS CAC time and usable state helper functions Aditya Kumar Singh
2023-06-07 12:46   ` Aditya Kumar Singh
2023-07-27 12:05   ` Aditya Kumar Singh
2023-07-27 12:05     ` Aditya Kumar Singh
2023-07-27 16:29     ` Kalle Valo
2023-07-27 16:29       ` Kalle Valo
2023-08-22 15:01   ` Jeff Johnson
2023-08-22 15:01     ` Jeff Johnson
2023-06-07 12:46 ` [PATCH 2/3] wifi: ath11k: fix CAC running state during virtual interface start Aditya Kumar Singh
2023-06-07 12:46   ` Aditya Kumar Singh
2023-08-22 15:02   ` Jeff Johnson
2023-08-22 15:02     ` Jeff Johnson
2023-09-13 13:25   ` Aditya Kumar Singh
2023-09-13 13:25     ` Aditya Kumar Singh
2023-09-14 13:16     ` Kalle Valo [this message]
2023-09-14 13:16       ` Kalle Valo
2023-06-07 12:46 ` [PATCH 3/3] wifi: ath11k: fix Tx power value during active CAC Aditya Kumar Singh
2023-06-07 12:46   ` Aditya Kumar Singh
2023-08-22 15:03   ` Jeff Johnson
2023-08-22 15:03     ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs3gdhei.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_adisi@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.