From: Thomas Gleixner <tglx@linutronix.de>
To: "Mika Penttilä" <mika.penttila@mbosol.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Ashok Raj <ashok.raj@linux.intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Tony Luck <tony.luck@intel.com>,
Arjan van de Veen <arjan@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [patch 5/6] x86/smp: Split sending INIT IPI out into a helper function
Date: Mon, 05 Jun 2023 09:54:54 +0200 [thread overview]
Message-ID: <87fs768htd.ffs@tglx> (raw)
In-Reply-To: <b9cef72f-0bcf-5bd6-e828-f11bd822fe33@mbosol.com>
On Sun, Jun 04 2023 at 07:02, Mika Penttilä wrote:
> On 3.6.2023 23.07, Thomas Gleixner wrote:
>> +/*
>> + * Wake up AP by INIT, INIT, STARTUP sequence.
>> + */
>> +static int wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
>> +{
>> + unsigned long send_status = 0, accept_status = 0;
>> + int maxlvt, num_starts, j;
>> +
>> + preempt_disable();
>
> This seems like an unbalanced preempt disable..
Right. I screwed up a rebase completely....
next prev parent reply other threads:[~2023-06-05 7:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 20:06 [patch 0/6] Cure kexec() vs. mwait_play_dead() troubles Thomas Gleixner
2023-06-03 20:06 ` [patch 1/6] x86/smp: Remove pointless wmb() from native_stop_other_cpus() Thomas Gleixner
2023-06-03 20:06 ` [patch 2/6] x86/smp: Acquire stopping_cpu unconditionally Thomas Gleixner
2023-06-03 20:07 ` [patch 3/6] x86/smp: Use dedicated cache-line for mwait_play_dead() Thomas Gleixner
2023-06-03 20:07 ` [patch 4/6] x86/smp: Cure kexec() vs. mwait_play_dead() breakage Thomas Gleixner
2023-06-03 20:54 ` Ashok Raj
2023-06-04 3:19 ` Ashok Raj
2023-06-05 7:41 ` Thomas Gleixner
2023-06-03 20:07 ` [patch 5/6] x86/smp: Split sending INIT IPI out into a helper function Thomas Gleixner
2023-06-04 4:02 ` Mika Penttilä
2023-06-04 10:24 ` Ashok Raj
2023-06-05 7:54 ` Thomas Gleixner [this message]
2023-06-05 8:23 ` [patch v2 " Thomas Gleixner
2023-06-03 20:07 ` [patch 6/6] x86/smp: Put CPUs into INIT on shutdown if possible Thomas Gleixner
2023-06-03 20:57 ` Ashok Raj
2023-06-05 17:41 ` [patch 0/6] Cure kexec() vs. mwait_play_dead() troubles Sean Christopherson
2023-06-05 22:41 ` Thomas Gleixner
2023-06-05 23:08 ` Sean Christopherson
2023-06-06 7:20 ` Thomas Gleixner
2023-06-07 16:21 ` Ashok Raj
2023-06-07 17:33 ` Sean Christopherson
2023-06-07 22:19 ` Ashok Raj
2023-06-08 3:46 ` Sean Christopherson
2023-06-08 4:03 ` Ashok Raj
2023-06-16 15:07 ` Ashok Raj
2023-06-16 19:00 ` Sean Christopherson
2023-06-16 19:03 ` Ashok Raj
2023-06-16 19:08 ` Sean Christopherson
2023-06-09 8:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs768htd.ffs@tglx \
--to=tglx@linutronix.de \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@mbosol.com \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.