From: Kalle Valo <kvalo@kernel.org>
To: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
Subject: Re: [PATCH] wifi: ath11k: Add tx ack signal support for mgmt packets
Date: Wed, 18 Jan 2023 08:33:14 +0200 [thread overview]
Message-ID: <87fsc8xsgl.fsf@kernel.org> (raw)
In-Reply-To: <20221219053844.4084486-1-quic_mkenna@quicinc.com> (Maharaja Kennadyrajan's message of "Mon, 19 Dec 2022 11:08:44 +0530")
Maharaja Kennadyrajan <quic_mkenna@quicinc.com> writes:
> From: Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
>
> Add support to notify tx ack signal values for mgmt
> packets to userspace through NL interface.
>
> Advertise NL80211_EXT_FEATURE_ACK_SIGNAL_SUPPORT flag
> to enable this feature and it will be used for data
> packets as well.
>
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
> Signed-off-by: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>
[...]
> --- a/drivers/net/wireless/ath/ath11k/wmi.h
> +++ b/drivers/net/wireless/ath/ath11k/wmi.h
> @@ -2309,6 +2309,7 @@ struct wmi_init_cmd {
> } __packed;
>
> #define WMI_RSRC_CFG_FLAG1_BSS_CHANNEL_INFO_64 BIT(5)
> +#define WMI_RSRC_CFG_FLAG1_ACK_RSSI BIT(18)
>
> struct wmi_resource_config {
> u32 tlv_header;
> @@ -4541,6 +4542,8 @@ struct wmi_mgmt_tx_compl_event {
> u32 desc_id;
> u32 status;
> u32 pdev_id;
> + u32 ppdu_id;
> + u32 ack_rssi;
> } __packed;
Adding these two fields increases the minimum length for
WMI_TAG_MGMT_TX_COMPL_EVENT:
[WMI_TAG_MGMT_TX_COMPL_EVENT]
= { .min_len = sizeof(struct wmi_mgmt_tx_compl_event) },
If we have a firmware version which doesn't include ppdu_id and ack_rssi
in WMI_TAG_MGMT_TX_COMPL_EVENT ath11k will drop those events. Not sure
what to do.
Is it certain that all ath11k firmware versions have ppdu_id and
ack_rssi? Or should handle so in ath11k that ppdu_id and ack_rssi can be
optional in the event?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
Subject: Re: [PATCH] wifi: ath11k: Add tx ack signal support for mgmt packets
Date: Wed, 18 Jan 2023 08:33:14 +0200 [thread overview]
Message-ID: <87fsc8xsgl.fsf@kernel.org> (raw)
In-Reply-To: <20221219053844.4084486-1-quic_mkenna@quicinc.com> (Maharaja Kennadyrajan's message of "Mon, 19 Dec 2022 11:08:44 +0530")
Maharaja Kennadyrajan <quic_mkenna@quicinc.com> writes:
> From: Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
>
> Add support to notify tx ack signal values for mgmt
> packets to userspace through NL interface.
>
> Advertise NL80211_EXT_FEATURE_ACK_SIGNAL_SUPPORT flag
> to enable this feature and it will be used for data
> packets as well.
>
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Abinaya Kalaiselvan <quic_akalaise@quicinc.com>
> Signed-off-by: Maharaja Kennadyrajan <quic_mkenna@quicinc.com>
[...]
> --- a/drivers/net/wireless/ath/ath11k/wmi.h
> +++ b/drivers/net/wireless/ath/ath11k/wmi.h
> @@ -2309,6 +2309,7 @@ struct wmi_init_cmd {
> } __packed;
>
> #define WMI_RSRC_CFG_FLAG1_BSS_CHANNEL_INFO_64 BIT(5)
> +#define WMI_RSRC_CFG_FLAG1_ACK_RSSI BIT(18)
>
> struct wmi_resource_config {
> u32 tlv_header;
> @@ -4541,6 +4542,8 @@ struct wmi_mgmt_tx_compl_event {
> u32 desc_id;
> u32 status;
> u32 pdev_id;
> + u32 ppdu_id;
> + u32 ack_rssi;
> } __packed;
Adding these two fields increases the minimum length for
WMI_TAG_MGMT_TX_COMPL_EVENT:
[WMI_TAG_MGMT_TX_COMPL_EVENT]
= { .min_len = sizeof(struct wmi_mgmt_tx_compl_event) },
If we have a firmware version which doesn't include ppdu_id and ack_rssi
in WMI_TAG_MGMT_TX_COMPL_EVENT ath11k will drop those events. Not sure
what to do.
Is it certain that all ath11k firmware versions have ppdu_id and
ack_rssi? Or should handle so in ath11k that ppdu_id and ack_rssi can be
optional in the event?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-01-18 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 5:38 [PATCH] wifi: ath11k: Add tx ack signal support for mgmt packets Maharaja Kennadyrajan
2022-12-19 5:38 ` Maharaja Kennadyrajan
2023-01-18 6:33 ` Kalle Valo [this message]
2023-01-18 6:33 ` Kalle Valo
2023-01-23 12:31 ` Maharaja Kennadyrajan
2023-01-23 12:31 ` Maharaja Kennadyrajan
2023-03-01 14:10 ` Kalle Valo
2023-03-01 14:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsc8xsgl.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_akalaise@quicinc.com \
--cc=quic_mkenna@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.