All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Machata <petrm@nvidia.com>
To: <Daniel.Machon@microchip.com>
Cc: <petrm@nvidia.com>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>, <maxime.chevallier@bootlin.com>,
	<thomas.petazzoni@bootlin.com>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>,
	<Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
	<UNGLinuxDriver@microchip.com>, <joe@perches.com>,
	<linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
	<Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [net-next v3 2/6] net: dcb: add new apptrust attribute
Date: Wed, 26 Oct 2022 16:55:31 +0200	[thread overview]
Message-ID: <87fsfazkm2.fsf@nvidia.com> (raw)
In-Reply-To: <Y1kmBMXluPI1Wmu/@DEN-LT-70577>


<Daniel.Machon@microchip.com> writes:

>> > +     if (ops->dcbnl_getapptrust) {
>> > +             u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] = {0};
>> > +             int nselectors;
>> > +
>> > +             apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE);
>> > +             if (!app)
>> > +                     return -EMSGSIZE;
>> > +
>> > +             err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors);
>> > +             if (err)
>> > +                     return -EMSGSIZE;
>> 
>> This should return the error coming from the driver instead of
>> -EMSGSIZE.
>
> Hmm. The question is whether we should return at all if dcbnl_getapptrust()
> fails, or just continue to fill whatever other ieee information is available?
> Seems to be like the rest of the code in ieee_fill() just ignore that error.

I see. I guess the reasoning is that one broken callback shouldn't lead
to dropping the whole query. So yeah, let's do what the rest of the code
does. But it seems rather cavalier to disregard error codes like this.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Petr Machata <petrm@nvidia.com>
To: <Daniel.Machon@microchip.com>
Cc: <petrm@nvidia.com>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>, <maxime.chevallier@bootlin.com>,
	<thomas.petazzoni@bootlin.com>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>,
	<Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
	<UNGLinuxDriver@microchip.com>, <joe@perches.com>,
	<linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
	<Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [net-next v3 2/6] net: dcb: add new apptrust attribute
Date: Wed, 26 Oct 2022 16:55:31 +0200	[thread overview]
Message-ID: <87fsfazkm2.fsf@nvidia.com> (raw)
In-Reply-To: <Y1kmBMXluPI1Wmu/@DEN-LT-70577>


<Daniel.Machon@microchip.com> writes:

>> > +     if (ops->dcbnl_getapptrust) {
>> > +             u8 selectors[IEEE_8021QAZ_APP_SEL_MAX + 1] = {0};
>> > +             int nselectors;
>> > +
>> > +             apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE);
>> > +             if (!app)
>> > +                     return -EMSGSIZE;
>> > +
>> > +             err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors);
>> > +             if (err)
>> > +                     return -EMSGSIZE;
>> 
>> This should return the error coming from the driver instead of
>> -EMSGSIZE.
>
> Hmm. The question is whether we should return at all if dcbnl_getapptrust()
> fails, or just continue to fill whatever other ieee information is available?
> Seems to be like the rest of the code in ieee_fill() just ignore that error.

I see. I guess the reasoning is that one broken callback shouldn't lead
to dropping the whole query. So yeah, let's do what the rest of the code
does. But it seems rather cavalier to disregard error codes like this.

  reply	other threads:[~2022-10-26 15:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  9:13 [net-next v3 0/6] Add new PCP and APPTRUST attributes to dcbnl Daniel Machon
2022-10-24  9:13 ` Daniel Machon
2022-10-24  9:13 ` [net-next v3 1/6] net: dcb: add new pcp selector to app object Daniel Machon
2022-10-24  9:13   ` Daniel Machon
2022-10-26 10:11   ` Petr Machata
2022-10-26 10:11     ` Petr Machata
2022-10-26 11:19     ` Daniel.Machon
2022-10-26 11:19       ` Daniel.Machon
2022-10-26 14:51       ` Petr Machata
2022-10-26 14:51         ` Petr Machata
2022-10-27  9:00         ` Daniel.Machon
2022-10-27  9:00           ` Daniel.Machon
2022-10-27  9:59           ` Petr Machata
2022-10-27  9:59             ` Petr Machata
2022-10-24  9:13 ` [net-next v3 2/6] net: dcb: add new apptrust attribute Daniel Machon
2022-10-24  9:13   ` Daniel Machon
2022-10-26 11:06   ` Petr Machata
2022-10-26 11:06     ` Petr Machata
2022-10-26 12:10     ` Daniel.Machon
2022-10-26 12:10       ` Daniel.Machon
2022-10-26 14:55       ` Petr Machata [this message]
2022-10-26 14:55         ` Petr Machata
2022-10-24  9:13 ` [net-next v3 3/6] net: microchip: sparx5: add support for offloading pcp table Daniel Machon
2022-10-24  9:13   ` Daniel Machon
2022-10-24  9:13 ` [net-next v3 4/6] net: microchip: sparx5: add support for apptrust Daniel Machon
2022-10-24  9:13   ` Daniel Machon
2022-10-24  9:13 ` [net-next v3 5/6] net: microchip: sparx5: add support for offloading dscp table Daniel Machon
2022-10-24  9:13   ` Daniel Machon
2022-10-24  9:13 ` [net-next v3 6/6] net: microchip: sparx5: add support for offloading default prio Daniel Machon
2022-10-24  9:13   ` Daniel Machon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsfazkm2.fsf@nvidia.com \
    --to=petrm@nvidia.com \
    --cc=Daniel.Machon@microchip.com \
    --cc=Horatiu.Vultur@microchip.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=Lars.Povlsen@microchip.com \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=joe@perches.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.