* dovetail/x86: Redundant oob_trap_notify in kernelmode_fixup_or_oops?
@ 2022-02-17 20:11 Jan Kiszka
2022-02-18 8:51 ` Philippe Gerum
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2022-02-17 20:11 UTC (permalink / raw)
To: Philippe Gerum; +Cc: Xenomai
Hi Philippe,
oob_trap_notify() only notifies if running oob [1]. But at [2], we are
always in-band due to the check at [3], no? What was the idea behind
placing a hook here?
Jan
[1]
https://source.denx.de/Xenomai/linux-dovetail/-/blob/a1536285c0e15b7d49f772922477077794bfdcfd/include/linux/dovetail.h#L67
[2]
https://source.denx.de/Xenomai/linux-dovetail/-/blob/a1536285c0e15b7d49f772922477077794bfdcfd/arch/x86/mm/fault.c#L743
[3]
https://source.denx.de/Xenomai/linux-dovetail/-/blob/a1536285c0e15b7d49f772922477077794bfdcfd/arch/x86/mm/fault.c#L731
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dovetail/x86: Redundant oob_trap_notify in kernelmode_fixup_or_oops?
2022-02-17 20:11 dovetail/x86: Redundant oob_trap_notify in kernelmode_fixup_or_oops? Jan Kiszka
@ 2022-02-18 8:51 ` Philippe Gerum
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Gerum @ 2022-02-18 8:51 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Xenomai
Jan Kiszka <jan.kiszka@siemens.com> writes:
> Hi Philippe,
>
> oob_trap_notify() only notifies if running oob [1]. But at [2], we are
> always in-band due to the check at [3], no? What was the idea behind
> placing a hook here?
>
As you noticed, [2] and its counterpart notifying about the end-of-trap
condition are superfluous.
> Jan
>
> [1]
> https://source.denx.de/Xenomai/linux-dovetail/-/blob/a1536285c0e15b7d49f772922477077794bfdcfd/include/linux/dovetail.h#L67
> [2]
> https://source.denx.de/Xenomai/linux-dovetail/-/blob/a1536285c0e15b7d49f772922477077794bfdcfd/arch/x86/mm/fault.c#L743
> [3]
> https://source.denx.de/Xenomai/linux-dovetail/-/blob/a1536285c0e15b7d49f772922477077794bfdcfd/arch/x86/mm/fault.c#L731
--
Philippe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-18 8:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-17 20:11 dovetail/x86: Redundant oob_trap_notify in kernelmode_fixup_or_oops? Jan Kiszka
2022-02-18 8:51 ` Philippe Gerum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.