From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
Nick Kossifidis <mickflemm@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
kbuild-all@lists.01.org, Arnd Bergmann <arnd@arndb.de>,
Jakub Kicinski <kuba@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bob Copeland <me@bobcopeland.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath5k: fix building with LEDS=m
Date: Sun, 01 Aug 2021 14:40:10 +0300 [thread overview]
Message-ID: <87fsvte6lh.fsf@codeaurora.org> (raw)
In-Reply-To: <CAK8P3a2RJOxX5884A1bfzDzzF-n48YdQ=zu7yS=LnBB5vAEYeg@mail.gmail.com> (Arnd Bergmann's message of "Fri, 23 Jul 2021 10:58:05 +0200")
(oddly linux-wireless was dropped, adding it back in hopes that
patchwork sees this)
Arnd Bergmann <arnd@kernel.org> writes:
> On Fri, Jul 23, 2021 at 10:41 AM kernel test robot <lkp@intel.com> wrote:
>>
>> All errors (new ones prefixed by >>):
>>
>> mips-linux-ld: drivers/net/wireless/ath/ath5k/led.o: in function
>> `ath5k_register_led.constprop.0':
>> >> led.c:(.text+0x58): undefined reference to `led_classdev_register_ext'
>> mips-linux-ld: drivers/net/wireless/ath/ath5k/led.o: in function
>> `ath5k_unregister_leds':
>> >> led.c:(.text+0x1d8): undefined reference to `led_classdev_unregister'
>> >> mips-linux-ld: led.c:(.text+0x208): undefined reference to
>> >> `led_classdev_unregister'
>
> Ok, nevermind then, please ignore my patch. I don't see this
> particular build failure on
> my randconfig test box, which probably means I have some other patch
> applied that
> avoids this. I may get back to this in the future but can't figure it
> out at the moment.
>
> My feeling now is that the 'select' should just be removed entirely, and then
> we can have an 'if (!IS_ENABLED(CONFIG_MAC80211_LEDS)) return 0;'
> in ath5k_register_led().
>
> Arnd
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ath5k: fix building with LEDS=m
Date: Sun, 01 Aug 2021 14:40:10 +0300 [thread overview]
Message-ID: <87fsvte6lh.fsf@codeaurora.org> (raw)
In-Reply-To: <CAK8P3a2RJOxX5884A1bfzDzzF-n48YdQ=zu7yS=LnBB5vAEYeg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]
(oddly linux-wireless was dropped, adding it back in hopes that
patchwork sees this)
Arnd Bergmann <arnd@kernel.org> writes:
> On Fri, Jul 23, 2021 at 10:41 AM kernel test robot <lkp@intel.com> wrote:
>>
>> All errors (new ones prefixed by >>):
>>
>> mips-linux-ld: drivers/net/wireless/ath/ath5k/led.o: in function
>> `ath5k_register_led.constprop.0':
>> >> led.c:(.text+0x58): undefined reference to `led_classdev_register_ext'
>> mips-linux-ld: drivers/net/wireless/ath/ath5k/led.o: in function
>> `ath5k_unregister_leds':
>> >> led.c:(.text+0x1d8): undefined reference to `led_classdev_unregister'
>> >> mips-linux-ld: led.c:(.text+0x208): undefined reference to
>> >> `led_classdev_unregister'
>
> Ok, nevermind then, please ignore my patch. I don't see this
> particular build failure on
> my randconfig test box, which probably means I have some other patch
> applied that
> avoids this. I may get back to this in the future but can't figure it
> out at the moment.
>
> My feeling now is that the 'select' should just be removed entirely, and then
> we can have an 'if (!IS_ENABLED(CONFIG_MAC80211_LEDS)) return 0;'
> in ath5k_register_led().
>
> Arnd
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-08-01 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 10:54 [PATCH] ath5k: fix building with LEDS=m Arnd Bergmann
2021-07-23 8:41 ` kernel test robot
2021-07-23 8:58 ` Arnd Bergmann
2021-08-01 11:40 ` Kalle Valo [this message]
2021-08-01 11:40 ` Kalle Valo
2021-09-20 12:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsvte6lh.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jirislaby@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.