All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	marcan@marcan.st, kernel-team@android.com
Subject: Re: [PATCH] irqchip: Do not blindly select CONFIG_GENERIC_IRQ_MULTI_HANDLER
Date: Wed, 17 Feb 2021 19:10:45 +0000	[thread overview]
Message-ID: <87ft1upl1m.wl-maz@kernel.org> (raw)
In-Reply-To: <20210217142800.2547737-1-maz@kernel.org>

On Wed, 17 Feb 2021 14:28:00 +0000,
Marc Zyngier <maz@kernel.org> wrote:
> 
> Implementing CONFIG_GENERIC_IRQ_MULTI_HANDLER is a decision that is
> made at the architecture level, and shouldn't involve the irqchip
> at all (we even provide a fallback helper when the option isn't
> selected).
> 
> Drop all instances of such selection from non-arch code.
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>  drivers/irqchip/Kconfig | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index da7b3cf63b07..1e3dba80ff0b 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig

[...]

> @@ -64,7 +62,6 @@ config ARM_NVIC
>  config ARM_VIC
>  	bool
>  	select IRQ_DOMAIN
> -	select GENERIC_IRQ_MULTI_HANDLER
>  

Mark pointed out that ep93xx doesn't select GENERIC_IRQ_MULTI_HANDLER,
and that this removal breaks it. I've added the patch below before
this one to address the issue.

Thanks,

	M.

From c14dc142dd97708d53566efafd7ef7c4e8354f8d Mon Sep 17 00:00:00 2001
From: Marc Zyngier <maz@kernel.org>
Date: Wed, 17 Feb 2021 18:10:35 +0000
Subject: [PATCH] ARM: ep93xx: Select GENERIC_IRQ_MULTI_HANDLER directly

ep93xx currently relies of CONFIG_ARM_VIC to select
GENERIC_IRQ_MULTI_HANDLER. Given that this is logically a platform
architecture property, add the selection of GENERIC_IRQ_MULTI_HANDLER
at the platform level.

Further patches will remove the selection from the irqchip side.

Reported-by: Marc Rutland <mark.rutland@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 138248999df7..8efa01363da3 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -348,6 +348,7 @@ config ARCH_EP93XX
 	select ARM_AMBA
 	imply ARM_PATCH_PHYS_VIRT
 	select ARM_VIC
+	select GENERIC_IRQ_MULTI_HANDLER
 	select AUTO_ZRELADDR
 	select CLKDEV_LOOKUP
 	select CLKSRC_MMIO
-- 
2.30.0


-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	marcan@marcan.st, kernel-team@android.com
Subject: Re: [PATCH] irqchip: Do not blindly select CONFIG_GENERIC_IRQ_MULTI_HANDLER
Date: Wed, 17 Feb 2021 19:10:45 +0000	[thread overview]
Message-ID: <87ft1upl1m.wl-maz@kernel.org> (raw)
In-Reply-To: <20210217142800.2547737-1-maz@kernel.org>

On Wed, 17 Feb 2021 14:28:00 +0000,
Marc Zyngier <maz@kernel.org> wrote:
> 
> Implementing CONFIG_GENERIC_IRQ_MULTI_HANDLER is a decision that is
> made at the architecture level, and shouldn't involve the irqchip
> at all (we even provide a fallback helper when the option isn't
> selected).
> 
> Drop all instances of such selection from non-arch code.
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>  drivers/irqchip/Kconfig | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index da7b3cf63b07..1e3dba80ff0b 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig

[...]

> @@ -64,7 +62,6 @@ config ARM_NVIC
>  config ARM_VIC
>  	bool
>  	select IRQ_DOMAIN
> -	select GENERIC_IRQ_MULTI_HANDLER
>  

Mark pointed out that ep93xx doesn't select GENERIC_IRQ_MULTI_HANDLER,
and that this removal breaks it. I've added the patch below before
this one to address the issue.

Thanks,

	M.

From c14dc142dd97708d53566efafd7ef7c4e8354f8d Mon Sep 17 00:00:00 2001
From: Marc Zyngier <maz@kernel.org>
Date: Wed, 17 Feb 2021 18:10:35 +0000
Subject: [PATCH] ARM: ep93xx: Select GENERIC_IRQ_MULTI_HANDLER directly

ep93xx currently relies of CONFIG_ARM_VIC to select
GENERIC_IRQ_MULTI_HANDLER. Given that this is logically a platform
architecture property, add the selection of GENERIC_IRQ_MULTI_HANDLER
at the platform level.

Further patches will remove the selection from the irqchip side.

Reported-by: Marc Rutland <mark.rutland@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 138248999df7..8efa01363da3 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -348,6 +348,7 @@ config ARCH_EP93XX
 	select ARM_AMBA
 	imply ARM_PATCH_PHYS_VIRT
 	select ARM_VIC
+	select GENERIC_IRQ_MULTI_HANDLER
 	select AUTO_ZRELADDR
 	select CLKDEV_LOOKUP
 	select CLKSRC_MMIO
-- 
2.30.0


-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2021-02-17 19:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 14:28 [PATCH] irqchip: Do not blindly select CONFIG_GENERIC_IRQ_MULTI_HANDLER Marc Zyngier
2021-02-17 14:28 ` Marc Zyngier
2021-02-17 19:10 ` Marc Zyngier [this message]
2021-02-17 19:10   ` Marc Zyngier
2021-03-08 20:25 ` [irqchip: irq/irqchip-next] " irqchip-bot for Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft1upl1m.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.