From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Lukas Straub" <lukasstraub2@web.de>,
"Daniel P. Berrangé\\" <berrange@redhat.com>,
qemu-block <qemu-block@nongnu.org>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v14 1/7] Introduce yank feature
Date: Mon, 11 Jan 2021 14:33:55 +0100 [thread overview]
Message-ID: <87ft374myk.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAJ+F1CLLiHca4Lf_nL7p2+Q3MT5JA0Qn9W6g14q0MYtYoROOdA@mail.gmail.com> ("Marc-André Lureau"'s message of "Mon, 4 Jan 2021 17:56:20 +0400")
Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> Hi
>
> On Mon, Dec 28, 2020 at 7:08 PM Lukas Straub <lukasstraub2@web.de> wrote:
>
>> The yank feature allows to recover from hanging qemu by "yanking"
>> at various parts. Other qemu systems can register themselves and
>> multiple yank functions. Then all yank functions for selected
>> instances can be called by the 'yank' out-of-band qmp command.
>> Available instances can be queried by a 'query-yank' oob command.
>>
>
> Looking at the changes and API usage, I wonder if it wouldn't have been
> simpler to associate the yank function directly with the YankInstance
> (removing the need for register/unregister functions - tracking the state
> left to the callback). Have you tried that approach? If not, I could check
> if this idea would work.
Considering we're at v14... would it make sense to commit the current
approach, then explore the alternative approach on top?
If yes, is v14 committable as is?
next prev parent reply other threads:[~2021-01-11 13:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 15:08 [PATCH v14 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu Lukas Straub
2020-12-28 15:08 ` [PATCH v14 1/7] Introduce yank feature Lukas Straub
2021-01-04 13:56 ` Marc-André Lureau
2021-01-11 13:33 ` Markus Armbruster [this message]
2021-01-11 14:09 ` Marc-André Lureau
2021-01-12 14:17 ` Markus Armbruster
2021-01-12 14:27 ` Marc-André Lureau
2020-12-28 15:08 ` [PATCH v14 2/7] block/nbd.c: Add " Lukas Straub
2020-12-28 15:08 ` [PATCH v14 3/7] chardev/char-socket.c: " Lukas Straub
2021-01-12 14:29 ` Marc-André Lureau
2020-12-28 15:08 ` [PATCH v14 4/7] migration: " Lukas Straub
2020-12-28 15:08 ` [PATCH v14 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe Lukas Straub
2020-12-28 15:08 ` [PATCH v14 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown Lukas Straub
2020-12-28 15:09 ` [PATCH v14 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test Lukas Straub
2021-01-12 16:20 ` [PATCH v14 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu Markus Armbruster
2021-01-13 10:08 ` Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft374myk.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=lukasstraub2@web.de \
--cc=marcandre.lureau@gmail.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.