From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Wei Liu <wei.liu@kernel.org>,
Linux on Hyper-V List <linux-hyperv@vger.kernel.org>
Cc: virtualization@lists.linux-foundation.org,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
Vineeth Pillai <viremana@linux.microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Joerg Roedel <jroedel@suse.de>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Joerg Roedel <joro@8bytes.org>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root
Date: Thu, 12 Nov 2020 16:27:14 +0100 [thread overview]
Message-ID: <87ft5ey4rx.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20201105165814.29233-5-wei.liu@kernel.org>
Wei Liu <wei.liu@kernel.org> writes:
> The IOMMU code needs more work. We're sure for now the IRQ remapping
> hooks are not applicable when Linux is the root.
Super-nitpick: I would suggest we always say 'root partition' as 'root'
has a 'slightly different' meaning in Linux and this commit message may
sound confusing to an unprepared reader.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> Acked-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/hyperv-iommu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> index e09e2d734c57..8d3ce3add57d 100644
> --- a/drivers/iommu/hyperv-iommu.c
> +++ b/drivers/iommu/hyperv-iommu.c
> @@ -20,6 +20,7 @@
> #include <asm/io_apic.h>
> #include <asm/irq_remapping.h>
> #include <asm/hypervisor.h>
> +#include <asm/mshyperv.h>
>
> #include "irq_remapping.h"
>
> @@ -143,7 +144,7 @@ static int __init hyperv_prepare_irq_remapping(void)
> int i;
>
> if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
> - !x2apic_supported())
> + !x2apic_supported() || hv_root_partition)
> return -ENODEV;
>
> fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Wei Liu <wei.liu@kernel.org>,
Linux on Hyper-V List <linux-hyperv@vger.kernel.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Joerg Roedel <jroedel@suse.de>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
virtualization@lists.linux-foundation.org,
Vineeth Pillai <viremana@linux.microsoft.com>
Subject: Re: [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root
Date: Thu, 12 Nov 2020 16:27:14 +0100 [thread overview]
Message-ID: <87ft5ey4rx.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20201105165814.29233-5-wei.liu@kernel.org>
Wei Liu <wei.liu@kernel.org> writes:
> The IOMMU code needs more work. We're sure for now the IRQ remapping
> hooks are not applicable when Linux is the root.
Super-nitpick: I would suggest we always say 'root partition' as 'root'
has a 'slightly different' meaning in Linux and this commit message may
sound confusing to an unprepared reader.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> Acked-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/hyperv-iommu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> index e09e2d734c57..8d3ce3add57d 100644
> --- a/drivers/iommu/hyperv-iommu.c
> +++ b/drivers/iommu/hyperv-iommu.c
> @@ -20,6 +20,7 @@
> #include <asm/io_apic.h>
> #include <asm/irq_remapping.h>
> #include <asm/hypervisor.h>
> +#include <asm/mshyperv.h>
>
> #include "irq_remapping.h"
>
> @@ -143,7 +144,7 @@ static int __init hyperv_prepare_irq_remapping(void)
> int i;
>
> if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
> - !x2apic_supported())
> + !x2apic_supported() || hv_root_partition)
> return -ENODEV;
>
> fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Wei Liu <wei.liu@kernel.org>,
Linux on Hyper-V List <linux-hyperv@vger.kernel.org>
Cc: Wei Liu <wei.liu@kernel.org>, Joerg Roedel <jroedel@suse.de>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Michael Kelley <mikelley@microsoft.com>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
virtualization@lists.linux-foundation.org,
Vineeth Pillai <viremana@linux.microsoft.com>,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root
Date: Thu, 12 Nov 2020 16:27:14 +0100 [thread overview]
Message-ID: <87ft5ey4rx.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20201105165814.29233-5-wei.liu@kernel.org>
Wei Liu <wei.liu@kernel.org> writes:
> The IOMMU code needs more work. We're sure for now the IRQ remapping
> hooks are not applicable when Linux is the root.
Super-nitpick: I would suggest we always say 'root partition' as 'root'
has a 'slightly different' meaning in Linux and this commit message may
sound confusing to an unprepared reader.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> Acked-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/hyperv-iommu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> index e09e2d734c57..8d3ce3add57d 100644
> --- a/drivers/iommu/hyperv-iommu.c
> +++ b/drivers/iommu/hyperv-iommu.c
> @@ -20,6 +20,7 @@
> #include <asm/io_apic.h>
> #include <asm/irq_remapping.h>
> #include <asm/hypervisor.h>
> +#include <asm/mshyperv.h>
>
> #include "irq_remapping.h"
>
> @@ -143,7 +144,7 @@ static int __init hyperv_prepare_irq_remapping(void)
> int i;
>
> if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
> - !x2apic_supported())
> + !x2apic_supported() || hv_root_partition)
> return -ENODEV;
>
> fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-11-12 15:27 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 16:57 [PATCH v2 00/17] Introducing Linux root partition support for Microsoft Hypervisor Wei Liu
2020-11-05 16:57 ` [PATCH v2 01/17] asm-generic/hyperv: change HV_CPU_POWER_MANAGEMENT to HV_CPU_MANAGEMENT Wei Liu
2020-11-12 15:14 ` Vitaly Kuznetsov
2020-11-12 15:14 ` Vitaly Kuznetsov
2020-11-05 16:57 ` [PATCH v2 02/17] x86/hyperv: detect if Linux is the root partition Wei Liu
2020-11-05 19:16 ` kernel test robot
2020-11-05 19:16 ` kernel test robot
2020-11-05 19:16 ` kernel test robot
2020-11-12 11:42 ` Wei Liu
2020-11-12 11:42 ` Wei Liu
2020-11-12 11:46 ` Wei Liu
2020-11-12 11:46 ` Wei Liu
2020-11-12 12:22 ` Wei Liu
2020-11-12 12:22 ` Wei Liu
2020-11-05 20:23 ` kernel test robot
2020-11-05 20:23 ` kernel test robot
2020-11-05 20:23 ` kernel test robot
2020-11-12 15:16 ` Vitaly Kuznetsov
2020-11-12 15:16 ` Vitaly Kuznetsov
2020-11-12 15:51 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 03/17] Drivers: hv: vmbus: skip VMBus initialization if Linux is root Wei Liu
2020-11-12 15:24 ` Vitaly Kuznetsov
2020-11-12 15:24 ` Vitaly Kuznetsov
2020-11-13 14:51 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root Wei Liu
2020-11-05 16:58 ` Wei Liu
2020-11-12 15:27 ` Vitaly Kuznetsov [this message]
2020-11-12 15:27 ` Vitaly Kuznetsov
2020-11-12 15:27 ` Vitaly Kuznetsov
2020-11-13 14:53 ` Wei Liu
2020-11-13 14:53 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 05/17] clocksource/hyperv: use MSR-based access if " Wei Liu
2020-11-12 9:56 ` Daniel Lezcano
2020-11-12 9:56 ` Daniel Lezcano
2020-11-12 11:24 ` Wei Liu
2020-11-12 11:40 ` Daniel Lezcano
2020-11-12 11:40 ` Daniel Lezcano
2020-11-12 11:42 ` Wei Liu
2020-11-12 15:30 ` Vitaly Kuznetsov
2020-11-12 15:30 ` Vitaly Kuznetsov
2020-11-12 15:52 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 06/17] x86/hyperv: allocate output arg pages if required Wei Liu
2020-11-12 15:35 ` Vitaly Kuznetsov
2020-11-12 15:35 ` Vitaly Kuznetsov
2020-11-13 15:05 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 07/17] x86/hyperv: extract partition ID from Microsoft Hypervisor if necessary Wei Liu
2020-11-05 20:07 ` kernel test robot
2020-11-05 20:07 ` kernel test robot
2020-11-05 20:07 ` kernel test robot
2020-11-12 11:54 ` Wei Liu
2020-11-12 11:54 ` Wei Liu
2020-11-05 20:20 ` kernel test robot
2020-11-05 20:20 ` kernel test robot
2020-11-05 20:20 ` kernel test robot
2020-11-12 15:44 ` Vitaly Kuznetsov
2020-11-12 15:44 ` Vitaly Kuznetsov
2020-11-13 15:21 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 08/17] x86/hyperv: handling hypercall page setup for root Wei Liu
2020-11-12 15:51 ` Vitaly Kuznetsov
2020-11-12 15:51 ` Vitaly Kuznetsov
2020-11-13 15:33 ` Wei Liu
2020-11-13 16:09 ` Wei Liu
2020-11-13 16:16 ` Vitaly Kuznetsov
2020-11-13 16:16 ` Vitaly Kuznetsov
2020-11-05 16:58 ` [PATCH v2 09/17] x86/hyperv: provide a bunch of helper functions Wei Liu
2020-11-12 15:57 ` Vitaly Kuznetsov
2020-11-12 15:57 ` Vitaly Kuznetsov
2020-11-13 15:51 ` Wei Liu
2020-11-13 16:13 ` Vitaly Kuznetsov
2020-11-13 16:13 ` Vitaly Kuznetsov
2020-11-16 11:41 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 10/17] x86/hyperv: implement and use hv_smp_prepare_cpus Wei Liu
2020-11-12 16:44 ` Vitaly Kuznetsov
2020-11-12 16:44 ` Vitaly Kuznetsov
2020-11-13 15:56 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 11/17] asm-generic/hyperv: update hv_msi_entry Wei Liu
2020-11-05 16:58 ` [PATCH v2 12/17] asm-generic/hyperv: update hv_interrupt_entry Wei Liu
2020-11-05 16:58 ` [PATCH v2 13/17] asm-generic/hyperv: introduce hv_device_id and auxiliary structures Wei Liu
2020-11-05 16:58 ` [PATCH v2 14/17] asm-generic/hyperv: import data structures for mapping device interrupts Wei Liu
2020-11-05 16:58 ` [PATCH v2 15/17] x86/hyperv: implement an MSI domain for root partition Wei Liu
2020-11-12 13:50 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 16/17] x86/ioapic: export a few functions and data structures via io_apic.h Wei Liu
2020-11-12 11:39 ` Wei Liu
2020-11-05 16:58 ` [PATCH v2 17/17] x86/hyperv: handle IO-APIC when running as root Wei Liu
2020-11-12 16:56 ` Vitaly Kuznetsov
2020-11-12 16:56 ` Vitaly Kuznetsov
2020-11-13 16:01 ` Wei Liu
2020-11-13 16:04 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft5ey4rx.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=haiyangz@microsoft.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=viremana@linux.microsoft.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.