All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Govind Singh <govinds@codeaurora.org>,
	Rakesh Pillai <pillair@qti.qualcomm.com>,
	Brian Norris <briannorris@chromium.org>,
	lkml <linux-kernel@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	John Stultz <john.stultz@linaro.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Niklas Cassel <niklas.cassel@linaro.org>
Subject: Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot
Date: Fri, 28 Aug 2020 15:52:49 +0300	[thread overview]
Message-ID: <87ft876ify.fsf@codeaurora.org> (raw)
In-Reply-To: <CAMi1Hd3FBRrwysMX6NLhKzjDukm-YPooR7LX64i=HJHDD8_Dvw@mail.gmail.com> (Amit Pundir's message of "Mon, 17 Aug 2020 14:36:09 +0530")

Amit Pundir <amit.pundir@linaro.org> writes:

> On Mon, 8 Jun 2020 at 17:07, Kalle Valo <kvalo@codeaurora.org> wrote:
>> > I don't agree with this. If you read through the replies to the bug report,
>> > it is clear that NS migration uncovered a corner case or even a bug. So we
>> > should try to fix that indeed.
>>
>> I'm with Mani, we should try to fix ath10k instead. Hopefully we can
>> find a fix soon.
>
> Hi Team,
>
> Any updates on this? I can reproduce this hard crash on v5.9-rc1 as well.
>
> It is not a blocker for us because we switched to a userspace
> workaround, where we do not wait for modem to shutdown gracefully and
> SIGKILL it instead, during the shutdown/reboot process. But I'm happy
> to take a swing at any intermediate/in-progress solution available.

Govind submitted this patch and later he asked to drop it, but I think
it would be a good idea to test it anyway:

ath10k: Move msa region map/unmap to init/deinit path

https://lkml.kernel.org/r/1591191231-31917-1-git-send-email-govinds@codeaurora.org

(patchwork is down so I cannot give a patchwork link)

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Govind Singh <govinds@codeaurora.org>,
	Rakesh Pillai <pillair@qti.qualcomm.com>,
	Brian Norris <briannorris@chromium.org>,
	lkml <linux-kernel@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	John Stultz <john.stultz@linaro.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Niklas Cassel <niklas.cassel@linaro.org>
Subject: Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot
Date: Fri, 28 Aug 2020 15:52:49 +0300	[thread overview]
Message-ID: <87ft876ify.fsf@codeaurora.org> (raw)
In-Reply-To: <CAMi1Hd3FBRrwysMX6NLhKzjDukm-YPooR7LX64i=HJHDD8_Dvw@mail.gmail.com> (Amit Pundir's message of "Mon, 17 Aug 2020 14:36:09 +0530")

Amit Pundir <amit.pundir@linaro.org> writes:

> On Mon, 8 Jun 2020 at 17:07, Kalle Valo <kvalo@codeaurora.org> wrote:
>> > I don't agree with this. If you read through the replies to the bug report,
>> > it is clear that NS migration uncovered a corner case or even a bug. So we
>> > should try to fix that indeed.
>>
>> I'm with Mani, we should try to fix ath10k instead. Hopefully we can
>> find a fix soon.
>
> Hi Team,
>
> Any updates on this? I can reproduce this hard crash on v5.9-rc1 as well.
>
> It is not a blocker for us because we switched to a userspace
> workaround, where we do not wait for modem to shutdown gracefully and
> SIGKILL it instead, during the shutdown/reboot process. But I'm happy
> to take a swing at any intermediate/in-progress solution available.

Govind submitted this patch and later he asked to drop it, but I think
it would be a good idea to test it anyway:

ath10k: Move msa region map/unmap to init/deinit path

https://lkml.kernel.org/r/1591191231-31917-1-git-send-email-govinds@codeaurora.org

(patchwork is down so I cannot give a patchwork link)

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-08-28 12:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02  5:25 [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot John Stultz
2020-06-02  5:25 ` John Stultz
2020-06-02 19:16 ` Brian Norris
2020-06-02 19:16   ` Brian Norris
2020-06-02 19:40   ` John Stultz
2020-06-02 19:40     ` John Stultz
2020-06-02 20:04     ` Brian Norris
2020-06-02 20:04       ` Brian Norris
2020-06-03  0:27       ` Manivannan Sadhasivam
2020-06-03  0:27         ` Manivannan Sadhasivam
2020-06-03 10:07         ` govinds
2020-06-03 10:07           ` govinds
2020-06-04 18:17           ` Sibi Sankar
2020-06-04 18:17             ` Sibi Sankar
2020-06-08 11:37         ` Kalle Valo
2020-06-08 11:37           ` Kalle Valo
2020-08-17  9:06           ` Amit Pundir
2020-08-17  9:06             ` Amit Pundir
2020-08-28 12:52             ` Kalle Valo [this message]
2020-08-28 12:52               ` Kalle Valo
2020-08-28 13:07               ` Govind Singh
2020-08-28 13:07                 ` Govind Singh
2020-09-07 16:12                 ` Kalle Valo
2020-09-07 16:12                 ` Kalle Valo
2020-06-08 11:17 ` Kalle Valo
2020-06-08 11:17   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft876ify.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=amit.pundir@linaro.org \
    --cc=ath10k@lists.infradead.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=briannorris@chromium.org \
    --cc=govinds@codeaurora.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=niklas.cassel@linaro.org \
    --cc=pillair@qti.qualcomm.com \
    --cc=sibis@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.