From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: Maharaja Kennadyrajan <mkenna@codeaurora.org>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Avoid override CE5 configuration for QCA99X0 chipsets
Date: Fri, 29 May 2020 18:36:48 +0300 [thread overview]
Message-ID: <87ftbisqgf.fsf@codeaurora.org> (raw)
In-Reply-To: <63ec6f30-ee3b-c412-7c56-46d447b17c8e@dd-wrt.com> (Sebastian Gottschall's message of "Tue, 26 May 2020 17:29:24 +0200")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> Am 05.05.2020 um 09:34 schrieb Kalle Valo:
>
>> Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:
>>
>>> As the exisiting CE configurations are defined in global, there
>>> are the chances of QCA99X0 family chipsets CE configurations
>>> are getting changed by the ath10k_pci_override_ce_config()
>>> function.
>>>
>>> The override will be hit and CE5 configurations will be changed,
>>> when the user bring up the QCA99X0 chipsets along with QCA6174
>>> or QCA9377 chipset. (Bring up QCA99X0 family chipsets after
>>> QCA6174 or QCA9377).
>>>
>>> Hence, fixing this issue by moving the global CE configuration
>>> to radio specific CE configuration.
>>>
>>> Tested hardware: QCA9888 & QCA6174
>>> Tested firmware: 10.4-3.10-00047 & WLAN.RM.4.4.1.c3-00058
>>>
>>> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
>> Patch applied to ath-next branch of ath.git, thanks.
>>
>> 521fc37be3d8 ath10k: Avoid override CE5 configuration for QCA99X0 chipsets
>
> this patch will crash on ipq4019 devices. i reverted it and it worked again
Yeah, that patch is buggy but this should fix it:
commit 32221df6765b3773ff1af37c77f8531ebc48f246
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Sat May 9 14:06:33 2020 +0200
Commit: Kalle Valo <kvalo@codeaurora.org>
CommitDate: Tue May 12 10:33:13 2020 +0300
ath10k: fix ath10k_pci struct layout
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: Maharaja Kennadyrajan <mkenna@codeaurora.org>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Avoid override CE5 configuration for QCA99X0 chipsets
Date: Fri, 29 May 2020 18:36:48 +0300 [thread overview]
Message-ID: <87ftbisqgf.fsf@codeaurora.org> (raw)
In-Reply-To: <63ec6f30-ee3b-c412-7c56-46d447b17c8e@dd-wrt.com> (Sebastian Gottschall's message of "Tue, 26 May 2020 17:29:24 +0200")
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> Am 05.05.2020 um 09:34 schrieb Kalle Valo:
>
>> Maharaja Kennadyrajan <mkenna@codeaurora.org> wrote:
>>
>>> As the exisiting CE configurations are defined in global, there
>>> are the chances of QCA99X0 family chipsets CE configurations
>>> are getting changed by the ath10k_pci_override_ce_config()
>>> function.
>>>
>>> The override will be hit and CE5 configurations will be changed,
>>> when the user bring up the QCA99X0 chipsets along with QCA6174
>>> or QCA9377 chipset. (Bring up QCA99X0 family chipsets after
>>> QCA6174 or QCA9377).
>>>
>>> Hence, fixing this issue by moving the global CE configuration
>>> to radio specific CE configuration.
>>>
>>> Tested hardware: QCA9888 & QCA6174
>>> Tested firmware: 10.4-3.10-00047 & WLAN.RM.4.4.1.c3-00058
>>>
>>> Signed-off-by: Maharaja Kennadyrajan <mkenna@codeaurora.org>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>
>> Patch applied to ath-next branch of ath.git, thanks.
>>
>> 521fc37be3d8 ath10k: Avoid override CE5 configuration for QCA99X0 chipsets
>
> this patch will crash on ipq4019 devices. i reverted it and it worked again
Yeah, that patch is buggy but this should fix it:
commit 32221df6765b3773ff1af37c77f8531ebc48f246
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Sat May 9 14:06:33 2020 +0200
Commit: Kalle Valo <kvalo@codeaurora.org>
CommitDate: Tue May 12 10:33:13 2020 +0300
ath10k: fix ath10k_pci struct layout
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-29 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 13:49 [PATCH] ath10k: Avoid override CE5 configuration for QCA99X0 chipsets Maharaja Kennadyrajan
2020-04-23 13:49 ` Maharaja Kennadyrajan
2020-05-05 7:34 ` Kalle Valo
2020-05-26 15:29 ` Sebastian Gottschall
2020-05-26 15:29 ` Sebastian Gottschall
2020-05-29 15:36 ` Kalle Valo [this message]
2020-05-29 15:36 ` Kalle Valo
2020-05-29 17:18 ` Sebastian Gottschall
2020-05-29 17:18 ` Sebastian Gottschall
2020-05-30 7:26 ` Sebastian Gottschall
2020-06-08 11:12 ` Kalle Valo
2020-05-05 7:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftbisqgf.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mkenna@codeaurora.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.