From: Thomas Gleixner <tglx@linutronix.de>
To: Dmitry Safonov <0x7f454c46@gmail.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
clang-built-linux@googlegroups.com, x86@kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Paul Burton <paul.burton@mips.com>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Stephen Boyd <sboyd@kernel.org>,
Mark Salyzyn <salyzyn@android.com>,
Kees Cook <keescook@chromium.org>,
Peter Collingbourne <pcc@google.com>,
Andrei Vagin <avagin@openvz.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>
Subject: Re: [PATCH v3 00/26] Introduce common headers for vDSO
Date: Sun, 15 Mar 2020 11:02:45 +0100 [thread overview]
Message-ID: <87fteadjga.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <693b6a61-b5f6-2744-1579-b356e6510547@gmail.com>
Dmitry Safonov <0x7f454c46@gmail.com> writes:
> I like the idea, but I'm wondering if we could have less-grained
> headers? Like, AFAICS the patches create headers < 10 lines and even
> mostly < 5 lines.. I like that header's names perfectly describe what's
> inside, but I'm not sure how effective to have a lot of extra-small
> includes.
If that goes all into a big header then the headers from where the bits and
pieces are split out would have all to include this big header which
might result in other include dependency nightmares.
>> create mode 100644 include/vdso/time.h
>> create mode 100644 include/vdso/time32.h
>> create mode 100644 include/vdso/time64.h
>
> Maybe we could made them less-grained?
>
> I.e, time32 + time64 + time.h => time.h?
Then you end up with ifdeffery. I like the clear separation.
Thanks,
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dmitry Safonov <0x7f454c46@gmail.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
clang-built-linux@googlegroups.com, x86@kernel.org
Cc: Mark Rutland <Mark.Rutland@arm.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Stephen Boyd <sboyd@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Mark Salyzyn <salyzyn@android.com>,
Paul Burton <paul.burton@mips.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>, Marc Zyngier <maz@kernel.org>,
Peter Collingbourne <pcc@google.com>,
Andrei Vagin <avagin@openvz.org>
Subject: Re: [PATCH v3 00/26] Introduce common headers for vDSO
Date: Sun, 15 Mar 2020 11:02:45 +0100 [thread overview]
Message-ID: <87fteadjga.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <693b6a61-b5f6-2744-1579-b356e6510547@gmail.com>
Dmitry Safonov <0x7f454c46@gmail.com> writes:
> I like the idea, but I'm wondering if we could have less-grained
> headers? Like, AFAICS the patches create headers < 10 lines and even
> mostly < 5 lines.. I like that header's names perfectly describe what's
> inside, but I'm not sure how effective to have a lot of extra-small
> includes.
If that goes all into a big header then the headers from where the bits and
pieces are split out would have all to include this big header which
might result in other include dependency nightmares.
>> create mode 100644 include/vdso/time.h
>> create mode 100644 include/vdso/time32.h
>> create mode 100644 include/vdso/time64.h
>
> Maybe we could made them less-grained?
>
> I.e, time32 + time64 + time.h => time.h?
Then you end up with ifdeffery. I like the clear separation.
Thanks,
tglx
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-15 10:02 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:43 [PATCH v3 00/26] Introduce common headers for vDSO Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 01/26] linux/const.h: Extract common header " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 02/26] linux/bits.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 03/26] linux/limits.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 04/26] x86:Introduce asm/vdso/clocksource.h Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 05/26] arm: Introduce asm/vdso/clocksource.h Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 06/26] arm64: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-15 18:29 ` Catalin Marinas
2020-03-15 18:29 ` Catalin Marinas
2020-03-15 18:29 ` Catalin Marinas
2020-03-13 15:43 ` [PATCH v3 07/26] mips: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 08/26] linux/clocksource.h: Extract common header for vDSO Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 09/26] linux/math64.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 10/26] linux/time.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 11/26] linux/time32.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 12/26] linux/time64.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 13/26] linux/jiffies.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 14/26] linux/ktime.h: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 15/26] common: Introduce processor.h Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 16/26] scripts: Fix the inclusion order in modpost Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 17/26] linux/elfnote.h: Replace elf.h with UAPI equivalent Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 18/26] arm64: Introduce asm/vdso/processor.h Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-15 18:30 ` Catalin Marinas
2020-03-15 18:30 ` Catalin Marinas
2020-03-15 18:30 ` Catalin Marinas
2020-03-16 9:42 ` Vincenzo Frascino
2020-03-16 9:42 ` Vincenzo Frascino
2020-03-16 9:42 ` Vincenzo Frascino
2020-03-16 10:22 ` Mark Rutland
2020-03-16 10:22 ` Mark Rutland
2020-03-16 10:22 ` Mark Rutland
2020-03-16 10:26 ` Catalin Marinas
2020-03-16 10:26 ` Catalin Marinas
2020-03-16 10:26 ` Catalin Marinas
2020-03-16 10:29 ` Mark Rutland
2020-03-16 10:29 ` Mark Rutland
2020-03-16 10:29 ` Mark Rutland
2020-03-16 10:30 ` Vincenzo Frascino
2020-03-16 10:30 ` Vincenzo Frascino
2020-03-16 10:30 ` Vincenzo Frascino
2020-03-16 10:29 ` Vincenzo Frascino
2020-03-16 10:29 ` Vincenzo Frascino
2020-03-16 10:29 ` Vincenzo Frascino
2020-03-16 10:34 ` Catalin Marinas
2020-03-16 10:34 ` Catalin Marinas
2020-03-16 10:34 ` Catalin Marinas
2020-03-16 10:55 ` Vincenzo Frascino
2020-03-16 10:55 ` Vincenzo Frascino
2020-03-16 10:55 ` Vincenzo Frascino
2020-03-16 11:22 ` Catalin Marinas
2020-03-16 11:22 ` Catalin Marinas
2020-03-16 11:22 ` Catalin Marinas
2020-03-16 13:35 ` Vincenzo Frascino
2020-03-16 13:35 ` Vincenzo Frascino
2020-03-16 13:35 ` Vincenzo Frascino
2020-03-16 14:43 ` Catalin Marinas
2020-03-16 14:43 ` Catalin Marinas
2020-03-16 14:43 ` Catalin Marinas
2020-03-16 15:33 ` Vincenzo Frascino
2020-03-16 15:33 ` Vincenzo Frascino
2020-03-16 15:33 ` Vincenzo Frascino
2020-03-16 15:49 ` Catalin Marinas
2020-03-16 15:49 ` Catalin Marinas
2020-03-16 15:49 ` Catalin Marinas
2020-03-16 16:05 ` Vincenzo Frascino
2020-03-16 16:05 ` Vincenzo Frascino
2020-03-16 16:05 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 19/26] arm64: vdso: Include common headers in the vdso library Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-15 18:30 ` Catalin Marinas
2020-03-15 18:30 ` Catalin Marinas
2020-03-15 18:30 ` Catalin Marinas
2020-03-13 15:43 ` [PATCH v3 20/26] arm64: vdso32: " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-15 18:30 ` Catalin Marinas
2020-03-15 18:30 ` Catalin Marinas
2020-03-15 18:30 ` Catalin Marinas
2020-03-13 15:43 ` [PATCH v3 21/26] arm64: Introduce asm/vdso/arch_timer.h Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-15 18:32 ` Catalin Marinas
2020-03-15 18:32 ` Catalin Marinas
2020-03-15 18:32 ` Catalin Marinas
2020-03-16 15:37 ` Vincenzo Frascino
2020-03-16 15:37 ` Vincenzo Frascino
2020-03-16 15:37 ` Vincenzo Frascino
2020-04-09 13:26 ` Will Deacon
2020-04-09 13:26 ` Will Deacon
2020-04-09 13:26 ` Will Deacon
2020-04-09 13:36 ` Vincenzo Frascino
2020-04-09 13:36 ` Vincenzo Frascino
2020-04-09 13:36 ` Vincenzo Frascino
2020-03-16 10:28 ` Mark Rutland
2020-03-16 10:28 ` Mark Rutland
2020-03-16 10:28 ` Mark Rutland
2020-03-13 15:43 ` [PATCH v3 22/26] mips: vdso: Enable mips to use common headers Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 23/26] x86: vdso: Enable x86 " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 24/26] arm: vdso: Enable arm " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 25/26] lib: vdso: Enable " Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` [PATCH v3 26/26] arm64: vdso32: Enable Clang Compilation Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-13 15:43 ` Vincenzo Frascino
2020-03-16 9:17 ` Catalin Marinas
2020-03-16 9:17 ` Catalin Marinas
2020-03-16 9:17 ` Catalin Marinas
2020-03-13 16:19 ` [PATCH v3 00/26] Introduce common headers for vDSO Dmitry Safonov
2020-03-13 16:19 ` Dmitry Safonov
2020-03-15 10:02 ` Thomas Gleixner [this message]
2020-03-15 10:02 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fteadjga.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=0x7f454c46@gmail.com \
--cc=Mark.Rutland@arm.com \
--cc=arnd@arndb.de \
--cc=avagin@openvz.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=paul.burton@mips.com \
--cc=pcc@google.com \
--cc=salyzyn@android.com \
--cc=sboyd@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.