All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Show guilty context name on GPU reset
Date: Mon, 11 Nov 2019 12:28:27 +0200	[thread overview]
Message-ID: <87ftiu671w.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20191108190107.25417-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> We mention that we are resetting the GPU, and dump the device state for
> post mortem debugging. However, while that dump contains the active
> processes and the one flagged as causing the error, we do not always
> include that information in dmesg. Include the name of the guilty
> process in dmesg for reference.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_reset.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
> index f03e000051c1..86d52383bf9d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -87,6 +87,10 @@ static bool context_mark_guilty(struct i915_gem_context *ctx)
>  	if (!i915_gem_context_is_bannable(ctx))
>  		return false;
>  
> +	dev_notice(ctx->i915->drm.dev,
> +		   "%s context reset due to GPU hang\n",
> +		   ctx->name);
> +
>  	/* Record the timestamp for the last N hangs */
>  	prev_hang = ctx->hang_timestamp[0];
>  	for (i = 0; i < ARRAY_SIZE(ctx->hang_timestamp) - 1; i++)
> -- 
> 2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Show guilty context name on GPU reset
Date: Mon, 11 Nov 2019 12:28:27 +0200	[thread overview]
Message-ID: <87ftiu671w.fsf@gaia.fi.intel.com> (raw)
Message-ID: <20191111102827.32lUTmmae0h0Kxdb3FBbrHmi3ze4zryoF9WEnkd4E0A@z> (raw)
In-Reply-To: <20191108190107.25417-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> We mention that we are resetting the GPU, and dump the device state for
> post mortem debugging. However, while that dump contains the active
> processes and the one flagged as causing the error, we do not always
> include that information in dmesg. Include the name of the guilty
> process in dmesg for reference.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_reset.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
> index f03e000051c1..86d52383bf9d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -87,6 +87,10 @@ static bool context_mark_guilty(struct i915_gem_context *ctx)
>  	if (!i915_gem_context_is_bannable(ctx))
>  		return false;
>  
> +	dev_notice(ctx->i915->drm.dev,
> +		   "%s context reset due to GPU hang\n",
> +		   ctx->name);
> +
>  	/* Record the timestamp for the last N hangs */
>  	prev_hang = ctx->hang_timestamp[0];
>  	for (i = 0; i < ARRAY_SIZE(ctx->hang_timestamp) - 1; i++)
> -- 
> 2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-11 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 19:01 [PATCH] drm/i915: Show guilty context name on GPU reset Chris Wilson
2019-11-08 19:01 ` [Intel-gfx] " Chris Wilson
2019-11-08 19:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-08 19:50   ` [Intel-gfx] " Patchwork
2019-11-10 15:59 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-10 15:59   ` [Intel-gfx] " Patchwork
2019-11-11 10:28 ` Mika Kuoppala [this message]
2019-11-11 10:28   ` [Intel-gfx] [PATCH] " Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftiu671w.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.