* [PATCH] drm/i915: Only apply a rmw mmio update if the value changes
@ 2019-09-17 8:00 Chris Wilson
2019-09-17 8:37 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-09-17 8:00 UTC (permalink / raw)
To: intel-gfx
If we try to clear, or even set, a bit in the register that doesn't
change the register state; skip the write. There's a slight danger in
that the register acts as a latch-on-write, but I do not think we use a
rmw cycle with any such latch registers.
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/intel_uncore.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uncore.h b/drivers/gpu/drm/i915/intel_uncore.h
index 414fc2cb0459..dcfa243892c6 100644
--- a/drivers/gpu/drm/i915/intel_uncore.h
+++ b/drivers/gpu/drm/i915/intel_uncore.h
@@ -378,23 +378,23 @@ intel_uncore_read64_2x32(struct intel_uncore *uncore,
static inline void intel_uncore_rmw(struct intel_uncore *uncore,
i915_reg_t reg, u32 clear, u32 set)
{
- u32 val;
+ u32 old, val;
- val = intel_uncore_read(uncore, reg);
- val &= ~clear;
- val |= set;
- intel_uncore_write(uncore, reg, val);
+ old = intel_uncore_read(uncore, reg);
+ val = (old & ~clear) | set;
+ if (val != old)
+ intel_uncore_write(uncore, reg, val);
}
static inline void intel_uncore_rmw_fw(struct intel_uncore *uncore,
i915_reg_t reg, u32 clear, u32 set)
{
- u32 val;
+ u32 old, val;
- val = intel_uncore_read_fw(uncore, reg);
- val &= ~clear;
- val |= set;
- intel_uncore_write_fw(uncore, reg, val);
+ old = intel_uncore_read_fw(uncore, reg);
+ val = (old & ~clear) | set;
+ if (val != old)
+ intel_uncore_write_fw(uncore, reg, val);
}
static inline int intel_uncore_write_and_verify(struct intel_uncore *uncore,
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Only apply a rmw mmio update if the value changes 2019-09-17 8:00 [PATCH] drm/i915: Only apply a rmw mmio update if the value changes Chris Wilson @ 2019-09-17 8:37 ` Patchwork 2019-09-17 12:29 ` ✓ Fi.CI.IGT: " Patchwork 2019-09-17 13:49 ` [PATCH] " Mika Kuoppala 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2019-09-17 8:37 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Only apply a rmw mmio update if the value changes URL : https://patchwork.freedesktop.org/series/66800/ State : success == Summary == CI Bug Log - changes from CI_DRM_6906 -> Patchwork_14427 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/ Known issues ------------ Here are the changes found in Patchwork_14427 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_switch@legacy-render: - fi-icl-u2: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#111381]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-icl-u2/igt@gem_ctx_switch@legacy-render.html * igt@gem_exec_suspend@basic-s3: - fi-ilk-650: [PASS][3] -> [DMESG-WARN][4] ([fdo#106387]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-ilk-650/igt@gem_exec_suspend@basic-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-ilk-650/igt@gem_exec_suspend@basic-s3.html * igt@gem_mmap_gtt@basic-short: - fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-icl-u3/igt@gem_mmap_gtt@basic-short.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-icl-u3/igt@gem_mmap_gtt@basic-short.html * igt@i915_selftest@live_hangcheck: - fi-icl-u3: [PASS][7] -> [INCOMPLETE][8] ([fdo#107713] / [fdo#108569]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-icl-u3/igt@i915_selftest@live_hangcheck.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-icl-u3/igt@i915_selftest@live_hangcheck.html #### Possible fixes #### * igt@gem_ctx_create@basic-files: - fi-bxt-dsi: [INCOMPLETE][9] ([fdo#103927]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html * igt@gem_exec_fence@nb-await-default: - {fi-tgl-u}: [FAIL][11] ([fdo#111562] / [fdo#111597]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-tgl-u/igt@gem_exec_fence@nb-await-default.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-tgl-u/igt@gem_exec_fence@nb-await-default.html * igt@gem_mmap_gtt@basic-read-write: - fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-icl-u3/igt@gem_mmap_gtt@basic-read-write.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-icl-u3/igt@gem_mmap_gtt@basic-read-write.html * igt@i915_module_load@reload: - fi-icl-u3: [DMESG-WARN][15] ([fdo#107724] / [fdo#111214]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-icl-u3/igt@i915_module_load@reload.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-icl-u3/igt@i915_module_load@reload.html * igt@kms_busy@basic-flip-c: - fi-skl-6770hq: [SKIP][17] ([fdo#109271] / [fdo#109278]) -> [PASS][18] +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-skl-6770hq/igt@kms_busy@basic-flip-c.html * igt@kms_flip@basic-flip-vs-dpms: - fi-skl-6770hq: [SKIP][19] ([fdo#109271]) -> [PASS][20] +23 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214 [fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381 [fdo#111562]: https://bugs.freedesktop.org/show_bug.cgi?id=111562 [fdo#111597]: https://bugs.freedesktop.org/show_bug.cgi?id=111597 Participating hosts (55 -> 46) ------------------------------ Missing (9): fi-ilk-m540 fi-hsw-4200u fi-tgl-u2 fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6906 -> Patchwork_14427 CI-20190529: 20190529 CI_DRM_6906: 72e400c2b824ab108907631fcf896d3d2020e7d5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5186: 0008b3e1b2cf7a73b1e995031c9a73fc97b35aad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14427: 46b03ccb25cb648165b93fe94efe9506cc2bddc3 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 46b03ccb25cb drm/i915: Only apply a rmw mmio update if the value changes == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Only apply a rmw mmio update if the value changes 2019-09-17 8:00 [PATCH] drm/i915: Only apply a rmw mmio update if the value changes Chris Wilson 2019-09-17 8:37 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-09-17 12:29 ` Patchwork 2019-09-17 13:49 ` [PATCH] " Mika Kuoppala 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2019-09-17 12:29 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Only apply a rmw mmio update if the value changes URL : https://patchwork.freedesktop.org/series/66800/ State : success == Summary == CI Bug Log - changes from CI_DRM_6906_full -> Patchwork_14427_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_14427_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110841]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110854]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb4/igt@gem_exec_balancer@smoke.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb5/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +7 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@i915_pm_backlight@fade_with_suspend: - shard-skl: [PASS][7] -> [INCOMPLETE][8] ([fdo#104108]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl9/igt@i915_pm_backlight@fade_with_suspend.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl10/igt@i915_pm_backlight@fade_with_suspend.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-snb: [PASS][9] -> [SKIP][10] ([fdo#109271]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +4 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-skl: [PASS][13] -> [INCOMPLETE][14] ([fdo#110741]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_flip@dpms-vs-vblank-race: - shard-glk: [PASS][15] -> [FAIL][16] ([fdo#111609]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-glk4/igt@kms_flip@dpms-vs-vblank-race.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-glk3/igt@kms_flip@dpms-vs-vblank-race.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-kbl: [PASS][17] -> [FAIL][18] ([fdo#105363]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-kbl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-panning: - shard-apl: [PASS][19] -> [INCOMPLETE][20] ([fdo#103927]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-apl1/igt@kms_flip@flip-vs-panning.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-apl6/igt@kms_flip@flip-vs-panning.html * igt@kms_flip@plain-flip-fb-recreate-interruptible: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#100368]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103166]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#108341]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb8/igt@kms_psr@no_drrs.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb7/igt@kms_psr@psr2_sprite_blt.html * igt@kms_setmode@basic: - shard-skl: [PASS][31] -> [FAIL][32] ([fdo#99912]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl1/igt@kms_setmode@basic.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl1/igt@kms_setmode@basic.html - shard-kbl: [PASS][33] -> [FAIL][34] ([fdo#99912]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-kbl2/igt@kms_setmode@basic.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-kbl2/igt@kms_setmode@basic.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109276]) +18 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html #### Possible fixes #### * igt@gem_exec_schedule@preempt-queue-bsd1: - shard-iclb: [SKIP][37] ([fdo#109276]) -> [PASS][38] +29 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [SKIP][39] ([fdo#111325]) -> [PASS][40] +7 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb7/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@i915_suspend@sysfs-reader: - shard-apl: [DMESG-WARN][41] ([fdo#108566]) -> [PASS][42] +3 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-apl2/igt@i915_suspend@sysfs-reader.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-apl3/igt@i915_suspend@sysfs-reader.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-snb: [INCOMPLETE][43] ([fdo#105411]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-snb1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled: - shard-skl: [FAIL][45] ([fdo#103184] / [fdo#103232] / [fdo#108472]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl8/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl6/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html * igt@kms_flip@plain-flip-ts-check: - shard-glk: [FAIL][47] ([fdo#100368]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-glk7/igt@kms_flip@plain-flip-ts-check.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-glk2/igt@kms_flip@plain-flip-ts-check.html * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-iclb: [FAIL][49] ([fdo#103167]) -> [PASS][50] +4 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [FAIL][51] ([fdo#108145]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][53] ([fdo#108145] / [fdo#110403]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@perf@blocking: - shard-skl: [FAIL][57] ([fdo#110728]) -> [PASS][58] +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-skl5/igt@perf@blocking.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-skl5/igt@perf@blocking.html #### Warnings #### * igt@gem_mocs_settings@mocs-reset-bsd2: - shard-iclb: [SKIP][59] ([fdo#109276]) -> [FAIL][60] ([fdo#111330]) +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb2/igt@gem_mocs_settings@mocs-reset-bsd2.html * igt@i915_suspend@fence-restore-untiled: - shard-apl: [DMESG-WARN][61] ([fdo#108566]) -> [INCOMPLETE][62] ([fdo#103927]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-apl7/igt@i915_suspend@fence-restore-untiled.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-apl1/igt@i915_suspend@fence-restore-untiled.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][63] ([fdo#109349]) -> [DMESG-WARN][64] ([fdo#107724]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 [fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (9 -> 10) ------------------------------ Additional (1): pig-hsw-4770r Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6906 -> Patchwork_14427 CI-20190529: 20190529 CI_DRM_6906: 72e400c2b824ab108907631fcf896d3d2020e7d5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5186: 0008b3e1b2cf7a73b1e995031c9a73fc97b35aad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14427: 46b03ccb25cb648165b93fe94efe9506cc2bddc3 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14427/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Only apply a rmw mmio update if the value changes 2019-09-17 8:00 [PATCH] drm/i915: Only apply a rmw mmio update if the value changes Chris Wilson 2019-09-17 8:37 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-09-17 12:29 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-09-17 13:49 ` Mika Kuoppala 2 siblings, 0 replies; 4+ messages in thread From: Mika Kuoppala @ 2019-09-17 13:49 UTC (permalink / raw) To: Chris Wilson, intel-gfx Chris Wilson <chris@chris-wilson.co.uk> writes: > If we try to clear, or even set, a bit in the register that doesn't > change the register state; skip the write. There's a slight danger in > that the register acts as a latch-on-write, but I do not think we use a > rmw cycle with any such latch registers. > > Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> My stance was that with clear ~0, user should be notified. But I guess on this level of tooling, you should be free to do the useless read. Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_uncore.h | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_uncore.h b/drivers/gpu/drm/i915/intel_uncore.h > index 414fc2cb0459..dcfa243892c6 100644 > --- a/drivers/gpu/drm/i915/intel_uncore.h > +++ b/drivers/gpu/drm/i915/intel_uncore.h > @@ -378,23 +378,23 @@ intel_uncore_read64_2x32(struct intel_uncore *uncore, > static inline void intel_uncore_rmw(struct intel_uncore *uncore, > i915_reg_t reg, u32 clear, u32 set) > { > - u32 val; > + u32 old, val; > > - val = intel_uncore_read(uncore, reg); > - val &= ~clear; > - val |= set; > - intel_uncore_write(uncore, reg, val); > + old = intel_uncore_read(uncore, reg); > + val = (old & ~clear) | set; > + if (val != old) > + intel_uncore_write(uncore, reg, val); > } > > static inline void intel_uncore_rmw_fw(struct intel_uncore *uncore, > i915_reg_t reg, u32 clear, u32 set) > { > - u32 val; > + u32 old, val; > > - val = intel_uncore_read_fw(uncore, reg); > - val &= ~clear; > - val |= set; > - intel_uncore_write_fw(uncore, reg, val); > + old = intel_uncore_read_fw(uncore, reg); > + val = (old & ~clear) | set; > + if (val != old) > + intel_uncore_write_fw(uncore, reg, val); > } > > static inline int intel_uncore_write_and_verify(struct intel_uncore *uncore, > -- > 2.23.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-17 13:50 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-17 8:00 [PATCH] drm/i915: Only apply a rmw mmio update if the value changes Chris Wilson 2019-09-17 8:37 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-09-17 12:29 ` ✓ Fi.CI.IGT: " Patchwork 2019-09-17 13:49 ` [PATCH] " Mika Kuoppala
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.