From: Markus Armbruster <armbru@redhat.com>
To: Pino Toscano <ptoscano@redhat.com>
Cc: kwolf@redhat.com, pkrempa@redhat.com, qemu-block@nongnu.org,
rjones@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication
Date: Mon, 29 Jul 2019 12:57:40 +0200 [thread overview]
Message-ID: <87ftmprtuj.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <28464409.aSG18riZGY@lindworm.usersys.redhat.com> (Pino Toscano's message of "Mon, 29 Jul 2019 10:00:08 +0200")
Pino Toscano <ptoscano@redhat.com> writes:
> On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote:
>> On 7/26/19 9:09 AM, Pino Toscano wrote:
>> > Add a 'private-key' option which represents the path of a private key
>> > to use for authentication, and 'private-key-secret' as the name of an
>> > object with its passphrase.
>> >
>> > Signed-off-by: Pino Toscano <ptoscano@redhat.com>
>>
>> > +++ b/qapi/block-core.json
>> > @@ -3226,6 +3226,11 @@
>> > # @password-secret: ID of a QCryptoSecret object providing a password
>> > # for authentication (since 4.2)
>> > #
>> > +# @private-key: path to the private key (since 4.2)
>> > +#
>> > +# @private-key-secret: ID of a QCryptoSecret object providing the passphrase
>> > +# for 'private-key' (since 4.2)
>>
>> Is password-secret intended to be mutually-exclusive with
>> private-key/private-key-secret?
>
> My initial thought was to allow users to specify data for all the
> authentication methods possible. Either ways (all of them, or a single
> one) are fine for me.
How does this work at the libssh level? Can you configure multiple
authentication methods, and let negotiation pick the one to be used?
next prev parent reply other threads:[~2019-07-29 10:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 14:09 [Qemu-devel] [PATCH 0/2] ssh: add password and privkey auth methods Pino Toscano
2019-07-26 14:09 ` [Qemu-devel] [PATCH 1/2] ssh: implement password authentication Pino Toscano
2019-07-26 14:09 ` [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication Pino Toscano
2019-07-26 14:24 ` Eric Blake
2019-07-26 14:29 ` Richard W.M. Jones
2019-07-29 8:00 ` Pino Toscano
2019-07-29 10:57 ` Markus Armbruster [this message]
2019-07-29 11:21 ` Pino Toscano
2019-07-29 15:10 ` Markus Armbruster
2019-07-29 11:08 ` Kevin Wolf
2019-08-12 21:08 ` Max Reitz
2019-08-12 21:22 ` Eric Blake
2019-07-26 14:27 ` [Qemu-devel] [PATCH 0/2] ssh: add password and privkey auth methods Richard W.M. Jones
2019-07-26 14:45 ` Pino Toscano
2019-07-26 14:50 ` Richard W.M. Jones
2019-07-26 15:06 ` Eric Blake
2019-07-26 15:35 ` Richard W.M. Jones
2019-07-26 15:43 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftmprtuj.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=ptoscano@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.