[PATCH v7 1/2] Define SMBIOS3 entry point structures for EFI

[PATCH v7 1/2] Define SMBIOS3 entry point structures for EFI

[David Michael]

This adds the GUID, and includes it in lsefisystab output.

Signed-off-by: David Michael <fedora.dm0@gmail.com>
---

No changes since v6, just rebased onto 2.04

 grub-core/commands/efi/lsefisystab.c | 1 +
 include/grub/efi/api.h               | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/grub-core/commands/efi/lsefisystab.c b/grub-core/commands/efi/lsefisystab.c
index df1030221..7c039c509 100644
--- a/grub-core/commands/efi/lsefisystab.c
+++ b/grub-core/commands/efi/lsefisystab.c
@@ -48,6 +48,7 @@ static const struct guid_mapping guid_mappings[] =
     { GRUB_EFI_MPS_TABLE_GUID, "MPS"},
     { GRUB_EFI_SAL_TABLE_GUID, "SAL"},
     { GRUB_EFI_SMBIOS_TABLE_GUID, "SMBIOS"},
+    { GRUB_EFI_SMBIOS3_TABLE_GUID, "SMBIOS3"},
     { GRUB_EFI_SYSTEM_RESOURCE_TABLE_GUID, "SYSTEM RESOURCE TABLE"},
     { GRUB_EFI_TIANO_CUSTOM_DECOMPRESS_GUID, "TIANO CUSTOM DECOMPRESS"},
     { GRUB_EFI_TSC_FREQUENCY_GUID, "TSC FREQUENCY"},
diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h
index addcbfa8f..576074384 100644
--- a/include/grub/efi/api.h
+++ b/include/grub/efi/api.h
@@ -314,6 +314,11 @@
     { 0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d } \
   }
 
+#define GRUB_EFI_SMBIOS3_TABLE_GUID	\
+  { 0xf2fd1544, 0x9794, 0x4a2c, \
+    { 0x99, 0x2e, 0xe5, 0xbb, 0xcf, 0x20, 0xe3, 0x94 } \
+  }
+
 #define GRUB_EFI_SAL_TABLE_GUID \
   { 0xeb9d2d32, 0x2d88, 0x11d3, \
       { 0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d } \
-- 
2.20.1

Re: [PATCH v7 1/2] Define SMBIOS3 entry point structures for EFI

[Leif Lindholm]

On Fri, Jul 05, 2019 at 08:47:02AM -0400, David Michael wrote:
> This adds the GUID, and includes it in lsefisystab output.
> 
> Signed-off-by: David Michael <fedora.dm0@gmail.com>

Oh, and here we already have the SMBIOS 3.0 entry, splendid.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Daniel: please consider merging this one independently on 2/2, if that
isn't going in straightaway.

> ---
> 
> No changes since v6, just rebased onto 2.04
> 
>  grub-core/commands/efi/lsefisystab.c | 1 +
>  include/grub/efi/api.h               | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/grub-core/commands/efi/lsefisystab.c b/grub-core/commands/efi/lsefisystab.c
> index df1030221..7c039c509 100644
> --- a/grub-core/commands/efi/lsefisystab.c
> +++ b/grub-core/commands/efi/lsefisystab.c
> @@ -48,6 +48,7 @@ static const struct guid_mapping guid_mappings[] =
>      { GRUB_EFI_MPS_TABLE_GUID, "MPS"},
>      { GRUB_EFI_SAL_TABLE_GUID, "SAL"},
>      { GRUB_EFI_SMBIOS_TABLE_GUID, "SMBIOS"},
> +    { GRUB_EFI_SMBIOS3_TABLE_GUID, "SMBIOS3"},
>      { GRUB_EFI_SYSTEM_RESOURCE_TABLE_GUID, "SYSTEM RESOURCE TABLE"},
>      { GRUB_EFI_TIANO_CUSTOM_DECOMPRESS_GUID, "TIANO CUSTOM DECOMPRESS"},
>      { GRUB_EFI_TSC_FREQUENCY_GUID, "TSC FREQUENCY"},
> diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h
> index addcbfa8f..576074384 100644
> --- a/include/grub/efi/api.h
> +++ b/include/grub/efi/api.h
> @@ -314,6 +314,11 @@
>      { 0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d } \
>    }
>  
> +#define GRUB_EFI_SMBIOS3_TABLE_GUID	\
> +  { 0xf2fd1544, 0x9794, 0x4a2c, \
> +    { 0x99, 0x2e, 0xe5, 0xbb, 0xcf, 0x20, 0xe3, 0x94 } \
> +  }
> +
>  #define GRUB_EFI_SAL_TABLE_GUID \
>    { 0xeb9d2d32, 0x2d88, 0x11d3, \
>        { 0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d } \
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v7 1/2] Define SMBIOS3 entry point structures for EFI

[Daniel Kiper]

On Sat, Jul 06, 2019 at 12:17:11PM +0100, Leif Lindholm wrote:
> On Fri, Jul 05, 2019 at 08:47:02AM -0400, David Michael wrote:
> > This adds the GUID, and includes it in lsefisystab output.
> >
> > Signed-off-by: David Michael <fedora.dm0@gmail.com>
>
> Oh, and here we already have the SMBIOS 3.0 entry, splendid.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

> Daniel: please consider merging this one independently on 2/2, if that
> isn't going in straightaway.

I will take both. 2/2 is in quite good shape.

Daniel