All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
	Govind Singh <govinds@codeaurora.org>,
	Rakesh Pillai <pillair@codeaurora.org>
Subject: Re: [PATCH v2] ath10k: skip sending quiet mode cmd for WCN3990
Date: Fri, 14 Dec 2018 13:56:54 +0200	[thread overview]
Message-ID: <87ftv0xqwp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1544782666-24837-1-git-send-email-kvalo@codeaurora.org> (Kalle Valo's message of "Fri, 14 Dec 2018 12:17:46 +0200")

Kalle Valo <kvalo@codeaurora.org> writes:

> From: Rakesh Pillai <pillair@codeaurora.org>
>
> HL2.0 firmware does not support setting quiet mode.  If the host driver sends
> the quiet mode setting command to the HL2.0 firmware, it crashes with the below
> signature.
>
> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0
>
> The quiet mode command support is exposed by the firmware via thermal throttle
> wmi service. Enable ath10k thermal support if thermal throttle wmi service bit
> is set.  10.x firmware versions support this feature by default, but
> unfortunately do not advertise the support via service flags, hence have to
> manually set the service flag in ath10k_core_compat_services().
>
> Compile tested only.

I'm planning to queue this for 4.20 as wcn3990 support won't work
otherwise. But I wasn't able to test this so can someone help, please?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: ath10k@lists.infradead.org
Cc: Rakesh Pillai <pillair@codeaurora.org>,
	Govind Singh <govinds@codeaurora.org>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: skip sending quiet mode cmd for WCN3990
Date: Fri, 14 Dec 2018 13:56:54 +0200	[thread overview]
Message-ID: <87ftv0xqwp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1544782666-24837-1-git-send-email-kvalo@codeaurora.org> (Kalle Valo's message of "Fri, 14 Dec 2018 12:17:46 +0200")

Kalle Valo <kvalo@codeaurora.org> writes:

> From: Rakesh Pillai <pillair@codeaurora.org>
>
> HL2.0 firmware does not support setting quiet mode.  If the host driver sends
> the quiet mode setting command to the HL2.0 firmware, it crashes with the below
> signature.
>
> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0
>
> The quiet mode command support is exposed by the firmware via thermal throttle
> wmi service. Enable ath10k thermal support if thermal throttle wmi service bit
> is set.  10.x firmware versions support this feature by default, but
> unfortunately do not advertise the support via service flags, hence have to
> manually set the service flag in ath10k_core_compat_services().
>
> Compile tested only.

I'm planning to queue this for 4.20 as wcn3990 support won't work
otherwise. But I wasn't able to test this so can someone help, please?

-- 
Kalle Valo

  reply	other threads:[~2018-12-14 11:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 10:17 [PATCH v2] ath10k: skip sending quiet mode cmd for WCN3990 Kalle Valo
2018-12-14 10:17 ` Kalle Valo
2018-12-14 11:56 ` Kalle Valo [this message]
2018-12-14 11:56   ` Kalle Valo
2018-12-14 12:59   ` Rakesh Pillai
2018-12-14 12:59     ` Rakesh Pillai
2018-12-19 13:32     ` Kalle Valo
2018-12-19 13:32       ` Kalle Valo
2018-12-19 13:37 ` Kalle Valo
2018-12-19 13:37 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftv0xqwp.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=govinds@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pillair@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.