From: Michael Ellerman <mpe@ellerman.id.au>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"David S. Miller" <davem@davemloft.net>,
linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] tty: Use of_node_name_{eq,prefix} for node name comparisons
Date: Thu, 06 Dec 2018 14:34:56 +1100 [thread overview]
Message-ID: <87ftvbl44f.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181205195050.4759-27-robh@kernel.org>
Rob Herring <robh@kernel.org> writes:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> For hvc, the code can also be simplified by using of_stdout pointer
> instead of searching again for the stdout node.
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-serial@vger.kernel.org
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/tty/hvc/hvc_opal.c | 2 +-
> drivers/tty/hvc/hvc_vio.c | 11 +----------
> drivers/tty/serial/pmac_zilog.c | 4 ++--
LGTM.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Paul Mackerras <paulus@samba.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] tty: Use of_node_name_{eq, prefix} for node name comparisons
Date: Thu, 06 Dec 2018 14:34:56 +1100 [thread overview]
Message-ID: <87ftvbl44f.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181205195050.4759-27-robh@kernel.org>
Rob Herring <robh@kernel.org> writes:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> For hvc, the code can also be simplified by using of_stdout pointer
> instead of searching again for the stdout node.
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-serial@vger.kernel.org
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/tty/hvc/hvc_opal.c | 2 +-
> drivers/tty/hvc/hvc_vio.c | 11 +----------
> drivers/tty/serial/pmac_zilog.c | 4 ++--
LGTM.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"David S. Miller" <davem@davemloft.net>,
linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] tty: Use of_node_name_{eq,prefix} for node name comparisons
Date: Thu, 06 Dec 2018 03:34:56 +0000 [thread overview]
Message-ID: <87ftvbl44f.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20181205195050.4759-27-robh@kernel.org>
Rob Herring <robh@kernel.org> writes:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> For hvc, the code can also be simplified by using of_stdout pointer
> instead of searching again for the stdout node.
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-serial@vger.kernel.org
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/tty/hvc/hvc_opal.c | 2 +-
> drivers/tty/hvc/hvc_vio.c | 11 +----------
> drivers/tty/serial/pmac_zilog.c | 4 ++--
LGTM.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
next prev parent reply other threads:[~2018-12-06 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:50 [PATCH] tty: Use of_node_name_{eq,prefix} for node name comparisons Rob Herring
2018-12-05 19:50 ` Rob Herring
2018-12-05 19:50 ` Rob Herring
2018-12-05 19:55 ` David Miller
2018-12-05 19:55 ` David Miller
2018-12-05 19:55 ` David Miller
2018-12-06 3:34 ` Michael Ellerman [this message]
2018-12-06 3:34 ` Michael Ellerman
2018-12-06 3:34 ` [PATCH] tty: Use of_node_name_{eq, prefix} " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftvbl44f.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=robh@kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.