From: Markus Armbruster <armbru@redhat.com>
To: Li Qiang <liq3ea@163.com>
Cc: pbonzini@redhat.com, kraxel@redhat.com, lersek@redhat.com,
philmd@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] fw_cfg: make qemu_extra_params_fw locally
Date: Tue, 20 Nov 2018 20:33:09 +0100 [thread overview]
Message-ID: <87ftvv8ryi.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181119154737.9840-4-liq3ea@163.com> (Li Qiang's message of "Mon, 19 Nov 2018 07:47:37 -0800")
Li Qiang <liq3ea@163.com> writes:
> qemu_extra_params_fw[] has external linkage, but is used
> only in fw_cfg_bootsplash(), it makes sense to make it
> locally.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2018-11-20 19:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 15:47 [Qemu-devel] [PATCH 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking Li Qiang
2018-11-19 15:47 ` [Qemu-devel] [PATCH 1/3] fw_cfg: fix -boot bootsplash " Li Qiang
2018-11-20 19:30 ` Markus Armbruster
2018-11-19 15:47 ` [Qemu-devel] [PATCH 2/3] fw_cfg: fix -boot reboot-timeout " Li Qiang
2018-11-20 19:32 ` Markus Armbruster
2018-11-19 15:47 ` [Qemu-devel] [PATCH 3/3] fw_cfg: make qemu_extra_params_fw locally Li Qiang
2018-11-20 19:33 ` Markus Armbruster [this message]
2018-11-20 19:34 ` [Qemu-devel] [PATCH 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking Markus Armbruster
2018-11-20 19:59 ` Philippe Mathieu-Daudé
2018-11-21 3:31 ` 李强
2018-11-21 17:11 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftvv8ryi.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=liq3ea@163.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.