From: Eric Anholt <eric@anholt.net>
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Stefan Schake <stschake@gmail.com>
Subject: Re: [PATCH v4 1/2] drm/vc4: Add CTM support
Date: Mon, 23 Apr 2018 11:54:49 -0700 [thread overview]
Message-ID: <87fu3l4uti.fsf@anholt.net> (raw)
In-Reply-To: <20180420122545.40014-1-stschake@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 550 bytes --]
Stefan Schake <stschake@gmail.com> writes:
> The hardware has a single block for applying a CTM prior to gamma lut.
> It can be fed with pixels from one of our CRTC at a time and uses a
> matrix with S0.9 scalars. Use private atomic state to reject attempts
> from userland to apply CTM for more than one CRTC at a time and reject
> matrices with scalars that we can't approximate without integer bits.
Looks good! I think you got all the transition cases we were concerned
about before.
Reviewed and applied these two to drm-misc-next. Thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Stefan Schake <stschake@gmail.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Stefan Schake <stschake@gmail.com>
Subject: Re: [PATCH v4 1/2] drm/vc4: Add CTM support
Date: Mon, 23 Apr 2018 11:54:49 -0700 [thread overview]
Message-ID: <87fu3l4uti.fsf@anholt.net> (raw)
In-Reply-To: <20180420122545.40014-1-stschake@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
Stefan Schake <stschake@gmail.com> writes:
> The hardware has a single block for applying a CTM prior to gamma lut.
> It can be fed with pixels from one of our CRTC at a time and uses a
> matrix with S0.9 scalars. Use private atomic state to reject attempts
> from userland to apply CTM for more than one CRTC at a time and reject
> matrices with scalars that we can't approximate without integer bits.
Looks good! I think you got all the transition cases we were concerned
about before.
Reviewed and applied these two to drm-misc-next. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-04-23 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 12:25 [PATCH v4 1/2] drm/vc4: Add CTM support Stefan Schake
2018-04-20 12:25 ` Stefan Schake
2018-04-20 12:25 ` [PATCH v4 2/2] drm/vc4: Add CTM registers to debugfs Stefan Schake
2018-04-20 12:25 ` Stefan Schake
2018-04-23 18:54 ` Eric Anholt [this message]
2018-04-23 18:54 ` [PATCH v4 1/2] drm/vc4: Add CTM support Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu3l4uti.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stschake@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.