From: ebiederm@xmission.com (Eric W. Biederman)
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Deepa Dinamani <deepa.kernel@gmail.com>,
y2038@lists.linaro.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc: compat: allow including asm/compat.h for 32-bit
Date: Wed, 11 Apr 2018 19:32:04 +0000 [thread overview]
Message-ID: <87fu41ilor.fsf@xmission.com> (raw)
In-Reply-To: <20180411150829.3881900-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 11 Apr 2018 17:07:58 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> We have several files on sparc that include linux/compat.h and expect
> asm/compat.h not to be included, otherwise we get a build failure.
Should this say: "We have several files on sparc that include
linux/compat.h and expect asm/compat.h not be included when
!CONFIG_COMPAT." ?
I don't have your tree and I see asm/compat.h included from
linux/compat.h already so the description above seems wrong.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Deepa Dinamani <deepa.kernel@gmail.com>,
y2038@lists.linaro.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc: compat: allow including asm/compat.h for 32-bit
Date: Wed, 11 Apr 2018 14:32:04 -0500 [thread overview]
Message-ID: <87fu41ilor.fsf@xmission.com> (raw)
In-Reply-To: <20180411150829.3881900-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 11 Apr 2018 17:07:58 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> We have several files on sparc that include linux/compat.h and expect
> asm/compat.h not to be included, otherwise we get a build failure.
Should this say: "We have several files on sparc that include
linux/compat.h and expect asm/compat.h not be included when
!CONFIG_COMPAT." ?
I don't have your tree and I see asm/compat.h included from
linux/compat.h already so the description above seems wrong.
Eric
next prev parent reply other threads:[~2018-04-11 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 15:07 [PATCH] sparc: compat: allow including asm/compat.h for 32-bit Arnd Bergmann
2018-04-11 15:07 ` Arnd Bergmann
2018-04-11 19:32 ` Eric W. Biederman [this message]
2018-04-11 19:32 ` Eric W. Biederman
2018-04-11 20:25 ` Arnd Bergmann
2018-04-11 20:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu41ilor.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.