[PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Biju Das]

This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
(R8A7743/5) usbhs is identical to the R-Car Gen2 family.

This doesn't change the driver, so it does nothing by itself.  But it does
mean that checkpatch won't complain about a future patch that adds
"renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which helps
ensure that shipped DTs use documented compatibility strings.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
This patch is tested against Linux next tag next-20170929

 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 9e18e00..479215b 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -3,6 +3,8 @@ Renesas Electronics USBHS driver
 Required properties:
   - compatible: Must contain one or more of the following:
 
+	- "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device
+	- "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
 	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
 	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
 	- "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
@@ -10,7 +12,7 @@ Required properties:
 	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
 	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
 	- "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device
-	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
+	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible device
 	- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
 
 	When compatible with the generic version, nodes must list the
-- 
1.9.1

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Yoshihiro Shimoda]

Hi Biju-san,
(+ Felipe-san)

Thank you for the patch!

> From: Biju Das, Sent: Friday, October 6, 2017 12:13 AM
> 
> This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
> 
> This doesn't change the driver, so it does nothing by itself.  But it does
> mean that checkpatch won't complain about a future patch that adds
> "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which helps
> ensure that shipped DTs use documented compatibility strings.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> This patch is tested against Linux next tag next-20170929
> 
>  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 9e18e00..479215b 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -3,6 +3,8 @@ Renesas Electronics USBHS driver
>  Required properties:
>    - compatible: Must contain one or more of the following:
> 
> +	- "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device
> +	- "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
>  	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>  	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>  	- "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> @@ -10,7 +12,7 @@ Required properties:
>  	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>  	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>  	- "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device
> -	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
> +	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible device
>  	- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device

This will be conflict with my R-Car D3 support patch.
https://patchwork.kernel.org/patch/9982267/
The R-Car D3 patch is not applied into usb.git yet though...

Hi Felipe-san,

Could you resolve this conflict on your side?
Or, should this r8a7743/5 patch be rebased on the R-Car D3 patch?

When after resolved the conflict:

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

>  	When compatible with the generic version, nodes must list the
> --
> 1.9.1

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Yoshihiro Shimoda]

Hi Biju-san,
(+ Felipe-san)

Thank you for the patch!

> From: Biju Das, Sent: Friday, October 6, 2017 12:13 AM
> 
> This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
> 
> This doesn't change the driver, so it does nothing by itself.  But it does
> mean that checkpatch won't complain about a future patch that adds
> "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which helps
> ensure that shipped DTs use documented compatibility strings.
> 
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> ---
> This patch is tested against Linux next tag next-20170929
> 
>  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 9e18e00..479215b 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -3,6 +3,8 @@ Renesas Electronics USBHS driver
>  Required properties:
>    - compatible: Must contain one or more of the following:
> 
> +	- "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device
> +	- "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
>  	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>  	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>  	- "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> @@ -10,7 +12,7 @@ Required properties:
>  	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>  	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>  	- "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device
> -	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
> +	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible device
>  	- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device

This will be conflict with my R-Car D3 support patch.
https://patchwork.kernel.org/patch/9982267/
The R-Car D3 patch is not applied into usb.git yet though...

Hi Felipe-san,

Could you resolve this conflict on your side?
Or, should this r8a7743/5 patch be rebased on the R-Car D3 patch?

When after resolved the conflict:

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Best regards,
Yoshihiro Shimoda

>  	When compatible with the generic version, nodes must list the
> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Geert Uytterhoeven]

Hi Biju,

On Thu, Oct 5, 2017 at 5:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
>
> This doesn't change the driver, so it does nothing by itself.  But it does

Wording it like this may give the wrong impression to the casual reader
that a driver change will be submitted separately.
No driver change is needed due to the fallback compatible value
"renesas,rcar-gen2-usbhs".

> mean that checkpatch won't complain about a future patch that adds
> "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which helps
> ensure that shipped DTs use documented compatibility strings.

Adding the SoC-specific compatible values here has two purposes:
  1. Document which SoCs have this hardware module,
  2. Allow checkpatch to validate compatible values.

> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -3,6 +3,8 @@ Renesas Electronics USBHS driver
>  Required properties:
>    - compatible: Must contain one or more of the following:
>
> +       - "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device
> +       - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device
>         - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>         - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>         - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
> @@ -10,7 +12,7 @@ Required properties:
>         - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>         - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>         - "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device
> -       - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
> +       - "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible device
>         - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Biju Das]

> -----Original Message-----
> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 06 October 2017 08:34
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Simon
> Horman <horms@verge.net.au>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>; devicetree@vger.kernel.org; Linux-Renesas
> <linux-renesas-soc@vger.kernel.org>; USB list <linux-usb@vger.kernel.org>
> Subject: Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5
>
> Hi Biju,
>
> On Thu, Oct 5, 2017 at 5:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> > (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
> >
> > This doesn't change the driver, so it does nothing by itself.  But it
> > does
>
> Wording it like this may give the wrong impression to the casual reader that a
> driver change will be submitted separately.
> No driver change is needed due to the fallback compatible value "renesas,rcar-
> gen2-usbhs".
>
> > mean that checkpatch won't complain about a future patch that adds
> > "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which
> > helps ensure that shipped DTs use documented compatibility strings.
>
> Adding the SoC-specific compatible values here has two purposes:
>   1. Document which SoCs have this hardware module,
>   2. Allow checkpatch to validate compatible values.

Thanks. I will send  v2 with above changes
 +
Will rebase on the below R-Car D3 patch
https://patchwork.kernel.org/patch/9982267/

regards,
Biju






Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Biju Das]

> -----Original Message-----
> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 06 October 2017 08:34
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Simon
> Horman <horms@verge.net.au>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>; devicetree@vger.kernel.org; Linux-Renesas
> <linux-renesas-soc@vger.kernel.org>; USB list <linux-usb@vger.kernel.org>
> Subject: Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5
>
> Hi Biju,
>
> On Thu, Oct 5, 2017 at 5:12 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> > (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
> >
> > This doesn't change the driver, so it does nothing by itself.  But it
> > does
>
> Wording it like this may give the wrong impression to the casual reader that a
> driver change will be submitted separately.
> No driver change is needed due to the fallback compatible value "renesas,rcar-
> gen2-usbhs".
>
> > mean that checkpatch won't complain about a future patch that adds
> > "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which
> > helps ensure that shipped DTs use documented compatibility strings.
>
> Adding the SoC-specific compatible values here has two purposes:
>   1. Document which SoCs have this hardware module,
>   2. Allow checkpatch to validate compatible values.

Thanks. I will send  v2 with above changes
 +
Will rebase on the below R-Car D3 patch
https://patchwork.kernel.org/patch/9982267/

regards,
Biju






Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]


Hi,

Biju Das <biju.das@bp.renesas.com> writes:
> This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
>
> This doesn't change the driver, so it does nothing by itself.  But it does
> mean that checkpatch won't complain about a future patch that adds
> "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which helps
> ensure that shipped DTs use documented compatibility strings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> This patch is tested against Linux next tag next-20170929

care to rebase on my testing/next? It fails to apply.

While doing that, please collect all Acks given.

8<------------------------------------------------------------------------

checking file Documentation/devicetree/bindings/usb/renesas_usbhs.txt
Hunk #2 FAILED at 12.
1 out of 2 hunks FAILED

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]


Hi,

Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> writes:
> This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
>
> This doesn't change the driver, so it does nothing by itself.  But it does
> mean that checkpatch won't complain about a future patch that adds
> "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which helps
> ensure that shipped DTs use documented compatibility strings.
>
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> ---
> This patch is tested against Linux next tag next-20170929

care to rebase on my testing/next? It fails to apply.

While doing that, please collect all Acks given.

8<------------------------------------------------------------------------

checking file Documentation/devicetree/bindings/usb/renesas_usbhs.txt
Hunk #2 FAILED at 12.
1 out of 2 hunks FAILED

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Biju Das]

Hi,

> -----Original Message-----
> From: devicetree-owner@vger.kernel.org [mailto:devicetree-
> owner@vger.kernel.org] On Behalf Of Felipe Balbi
> Sent: 17 October 2017 09:26
> To: Biju Das <biju.das@bp.renesas.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>
> Cc: Simon Horman <horms@verge.net.au>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>; devicetree@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; linux-usb@vger.kernel.org; Biju Das
> <biju.das@bp.renesas.com>
> Subject: Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5
>
>
> Hi,
>
> Biju Das <biju.das@bp.renesas.com> writes:
> > This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> > (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
> >
> > This doesn't change the driver, so it does nothing by itself.  But it
> > does mean that checkpatch won't complain about a future patch that
> > adds "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which
> > helps ensure that shipped DTs use documented compatibility strings.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > This patch is tested against Linux next tag next-20170929

> care to rebase on my testing/next? It fails to apply.

Sorry for the trouble.

I have already send a V2 for fixing this.

[v2] usb: renesas_usbhs: Add compatible string for r8a7743/5
https://patchwork.kernel.org/patch/9990063/

I have rebased this patch on my testing/next and confirms it apply cleanly.

Regds,
Biju








Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Biju Das]

Hi,

> -----Original Message-----
> From: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:devicetree-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Felipe Balbi
> Sent: 17 October 2017 09:26
> To: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>; Greg Kroah-Hartman
> <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>; Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Mark
> Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>; Chris Paterson
> <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>; Fabrizio Castro
> <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-renesas-
> soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Biju Das
> <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Subject: Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5
>
>
> Hi,
>
> Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> writes:
> > This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
> > (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
> >
> > This doesn't change the driver, so it does nothing by itself.  But it
> > does mean that checkpatch won't complain about a future patch that
> > adds "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which
> > helps ensure that shipped DTs use documented compatibility strings.
> >
> > Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > ---
> > This patch is tested against Linux next tag next-20170929

> care to rebase on my testing/next? It fails to apply.

Sorry for the trouble.

I have already send a V2 for fixing this.

[v2] usb: renesas_usbhs: Add compatible string for r8a7743/5
https://patchwork.kernel.org/patch/9990063/

I have rebased this patch on my testing/next and confirms it apply cleanly.

Regds,
Biju








Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]


Hi,

Biju Das <biju.das@bp.renesas.com> writes:
> Hi,
>
>> -----Original Message-----
>> From: devicetree-owner@vger.kernel.org [mailto:devicetree-
>> owner@vger.kernel.org] On Behalf Of Felipe Balbi
>> Sent: 17 October 2017 09:26
>> To: Biju Das <biju.das@bp.renesas.com>; Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>; Mark
>> Rutland <mark.rutland@arm.com>
>> Cc: Simon Horman <horms@verge.net.au>; Chris Paterson
>> <Chris.Paterson2@renesas.com>; Fabrizio Castro
>> <fabrizio.castro@bp.renesas.com>; devicetree@vger.kernel.org; linux-renesas-
>> soc@vger.kernel.org; linux-usb@vger.kernel.org; Biju Das
>> <biju.das@bp.renesas.com>
>> Subject: Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5
>>
>>
>> Hi,
>>
>> Biju Das <biju.das@bp.renesas.com> writes:
>> > This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
>> > (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
>> >
>> > This doesn't change the driver, so it does nothing by itself.  But it
>> > does mean that checkpatch won't complain about a future patch that
>> > adds "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which
>> > helps ensure that shipped DTs use documented compatibility strings.
>> >
>> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>> > ---
>> > This patch is tested against Linux next tag next-20170929
>
>> care to rebase on my testing/next? It fails to apply.
>
> Sorry for the trouble.
>
> I have already send a V2 for fixing this.
>
> [v2] usb: renesas_usbhs: Add compatible string for r8a7743/5
> https://patchwork.kernel.org/patch/9990063/
>
> I have rebased this patch on my testing/next and confirms it apply cleanly.

thank you, now applied :-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 2202 bytes --]


Hi,

Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> writes:
> Hi,
>
>> -----Original Message-----
>> From: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:devicetree-
>> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Felipe Balbi
>> Sent: 17 October 2017 09:26
>> To: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>; Greg Kroah-Hartman
>> <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>; Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Mark
>> Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
>> Cc: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>; Chris Paterson
>> <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>; Fabrizio Castro
>> <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-renesas-
>> soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Biju Das
>> <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
>> Subject: Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5
>>
>>
>> Hi,
>>
>> Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> writes:
>> > This patch adds support for r8a7743/5 SoC.  The Renesas RZ/G1[ME]
>> > (R8A7743/5) usbhs is identical to the R-Car Gen2 family.
>> >
>> > This doesn't change the driver, so it does nothing by itself.  But it
>> > does mean that checkpatch won't complain about a future patch that
>> > adds "renesas,usbhs-r8a7743" or "renesas,usbhs-r8a7745" to a DT, which
>> > helps ensure that shipped DTs use documented compatibility strings.
>> >
>> > Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
>> > ---
>> > This patch is tested against Linux next tag next-20170929
>
>> care to rebase on my testing/next? It fails to apply.
>
> Sorry for the trouble.
>
> I have already send a V2 for fixing this.
>
> [v2] usb: renesas_usbhs: Add compatible string for r8a7743/5
> https://patchwork.kernel.org/patch/9990063/
>
> I have rebased this patch on my testing/next and confirms it apply cleanly.

thank you, now applied :-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]