From: Jani Nikula <jani.nikula@linux.intel.com>
To: imre.deak@intel.com, "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>,
"Kuoppala, Mika" <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: Move bxt exclusive workarounds from gen9 func to bxt one.
Date: Fri, 03 Mar 2017 17:37:45 +0200 [thread overview]
Message-ID: <87fuiue5h2.fsf@intel.com> (raw)
In-Reply-To: <20170303133428.GC31076@ideak-desk.fi.intel.com>
On Fri, 03 Mar 2017, Imre Deak <imre.deak@intel.com> wrote:
> On Thu, Mar 02, 2017 at 08:27:28PM +0000, Vivi, Rodrigo wrote:
>> On Thu, 2017-03-02 at 21:20 +0200, Ville Syrjälä wrote:
>> > On Thu, Mar 02, 2017 at 11:15:29AM -0800, Rodrigo Vivi wrote:
>> > > + /* WaDisableDgMirrorFixInHalfSliceChicken5:bxt */
>> > > + if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
>> >
>> > Hmm. I thought someone had already nuked all BXT pre-production
>> > workarounds. I wonder why these still exist...
>>
>> Well, now that they are organized by the REVID I believe it doesn't hurt
>> to keep them here. In case someone internally end up using a pre-prod
>> hardware for something...
>
> This won't work anyway, since we removed the rest of the BTX pre-prod WAs.
>
>> or for future reference when adding next platforms.
>
> No strong opinion on this, but we removed the pre-prod WAs on other
> platforms too. I'd follow the rule not to keep any unused code around,
> it can be found from git if needed.
Strong opinion, nuke 'em. When there's production hardware available,
pretending to support early steppings is a waste of time.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-03 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 19:15 [PATCH] drm/i915: Move bxt exclusive workarounds from gen9 func to bxt one Rodrigo Vivi
2017-03-02 19:20 ` Ville Syrjälä
2017-03-02 20:27 ` Vivi, Rodrigo
2017-03-03 13:34 ` Imre Deak
2017-03-03 15:37 ` Jani Nikula [this message]
2017-03-02 20:18 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuiue5h2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.