From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: fabf@skynet.be, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()
Date: Mon, 14 Nov 2016 12:56:08 +0200 [thread overview]
Message-ID: <87fumu2uuv.fsf@intel.com> (raw)
In-Reply-To: <1478940498-2804-1-git-send-email-fabf@skynet.be>
On Sat, 12 Nov 2016, Fabian Frederick <fabf@skynet.be> wrote:
> -#if defined(CONFIG_HWMON) || (defined(MODULE) && defined(CONFIG_HWMON_MODULE))
> +#if IS_REACHABLE(CONFIG_HWMON)
The changes seem to make sense per se, but I'd be interested in hearing
the rationale for not expressing this dependency in terms of Kconfig to
begin with. With this, it's hidden in code, and the hwmon stuff gets
used if the conditions for "nouveau depends on hwmon" are met, by
chance, but it's not enforced.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Fabian Frederick <fabf@skynet.be>, Ben Skeggs <bskeggs@redhat.com>
Cc: fabf@skynet.be, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()
Date: Mon, 14 Nov 2016 12:56:08 +0200 [thread overview]
Message-ID: <87fumu2uuv.fsf@intel.com> (raw)
In-Reply-To: <1478940498-2804-1-git-send-email-fabf@skynet.be>
On Sat, 12 Nov 2016, Fabian Frederick <fabf@skynet.be> wrote:
> -#if defined(CONFIG_HWMON) || (defined(MODULE) && defined(CONFIG_HWMON_MODULE))
> +#if IS_REACHABLE(CONFIG_HWMON)
The changes seem to make sense per se, but I'd be interested in hearing
the rationale for not expressing this dependency in terms of Kconfig to
begin with. With this, it's hidden in code, and the hwmon stuff gets
used if the conditions for "nouveau depends on hwmon" are met, by
chance, but it's not enforced.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2016-11-14 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 8:48 [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE() Fabian Frederick
2016-11-14 10:56 ` Jani Nikula [this message]
2016-11-14 10:56 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fumu2uuv.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.