All of lore.kernel.org
 help / color / mirror / Atom feed
From: holgerschurig@gmail.com (Holger Schurig)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent
Date: Fri, 26 Feb 2016 08:24:15 +0100	[thread overview]
Message-ID: <87fuwg9bog.fsf@gmail.com> (raw)
In-Reply-To: <1456454309-25037-1-git-send-email-pankaj.dev@st.com> (Pankaj Dev's message of "Fri, 26 Feb 2016 08:08:29 +0530")

Pankaj Dev <pankaj.dev@st.com> writes:

> 1. clk_set_rate : Set new rate to value. Reading returns the
> current rate

If you can use this to set *and* read it, then "_set_" shouldn't be in
the name.

What is wrong with using the existing "clk_rate" for reading/setting the
rate?

WARNING: multiple messages have this Message-ID (diff)
From: Holger Schurig <holgerschurig@gmail.com>
To: Pankaj Dev <pankaj.dev@st.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	mturquette@linaro.org, kernel@stlinux.com, sboyd@codeaurora.org,
	laurent.meunier@st.com, lee.jones@linaro.org,
	maxime.coquelin@st.com
Subject: Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent
Date: Fri, 26 Feb 2016 08:24:15 +0100	[thread overview]
Message-ID: <87fuwg9bog.fsf@gmail.com> (raw)
In-Reply-To: <1456454309-25037-1-git-send-email-pankaj.dev@st.com> (Pankaj Dev's message of "Fri, 26 Feb 2016 08:08:29 +0530")

Pankaj Dev <pankaj.dev@st.com> writes:

> 1. clk_set_rate : Set new rate to value. Reading returns the
> current rate

If you can use this to set *and* read it, then "_set_" shouldn't be in
the name.

What is wrong with using the existing "clk_rate" for reading/setting the
rate?

WARNING: multiple messages have this Message-ID (diff)
From: Holger Schurig <holgerschurig@gmail.com>
To: Pankaj Dev <pankaj.dev@st.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, mturquette@linaro.org,
	kernel@stlinux.com, sboyd@codeaurora.org, laurent.meunier@st.com,
	lee.jones@linaro.org, maxime.coquelin@st.com
Subject: Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent
Date: Fri, 26 Feb 2016 08:24:15 +0100	[thread overview]
Message-ID: <87fuwg9bog.fsf@gmail.com> (raw)
In-Reply-To: <1456454309-25037-1-git-send-email-pankaj.dev@st.com> (Pankaj Dev's message of "Fri, 26 Feb 2016 08:08:29 +0530")

Pankaj Dev <pankaj.dev@st.com> writes:

> 1. clk_set_rate : Set new rate to value. Reading returns the
> current rate

If you can use this to set *and* read it, then "_set_" shouldn't be in
the name.

What is wrong with using the existing "clk_rate" for reading/setting the
rate?

  reply	other threads:[~2016-02-26  7:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  2:38 [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent Pankaj Dev
2016-02-26  2:38 ` Pankaj Dev
2016-02-26  2:38 ` Pankaj Dev
2016-02-26  7:24 ` Holger Schurig [this message]
2016-02-26  7:24   ` Holger Schurig
2016-02-26  7:24   ` Holger Schurig
2016-02-26  8:06   ` Pankaj DEV
2016-02-26  8:06     ` Pankaj DEV
2016-02-26  8:22     ` Holger Schurig
2016-02-26  8:22       ` Holger Schurig
2016-02-26  8:22       ` Holger Schurig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuwg9bog.fsf@gmail.com \
    --to=holgerschurig@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.