* [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings
@ 2016-01-14 14:53 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-01-14 14:53 UTC (permalink / raw)
To: qemu-devel; +Cc: patches, qemu-arm, Alex Bennée, Franz-Josef Haider
Commit 8acc216b956 attempted to silence some sign-compare
warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
for the relevant objects. Unfortunately it was ineffective
because it was placed before $(QEMU_CFLAGS), so the -Wall in
the general flags overrode -Wno-sign-compare rather than
vice-versa. Reorder the flags so the warning suppression works.
Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
for pointing out what was wrong with the original patch.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Alex, is there a way to test this patch against Travis before
we commit it to master?
disas/libvixl/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/libvixl/Makefile.objs b/disas/libvixl/Makefile.objs
index d1e801a..bbe7695 100644
--- a/disas/libvixl/Makefile.objs
+++ b/disas/libvixl/Makefile.objs
@@ -6,6 +6,6 @@ libvixl_OBJS = vixl/utils.o \
# The -Wno-sign-compare is needed only for gcc 4.6, which complains about
# some signed-unsigned equality comparisons which later gcc versions do not.
-$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS)
+$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS) -Wno-sign-compare
common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings
@ 2016-01-14 14:53 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-01-14 14:53 UTC (permalink / raw)
To: qemu-devel; +Cc: Franz-Josef Haider, qemu-arm, Alex Bennée, patches
Commit 8acc216b956 attempted to silence some sign-compare
warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
for the relevant objects. Unfortunately it was ineffective
because it was placed before $(QEMU_CFLAGS), so the -Wall in
the general flags overrode -Wno-sign-compare rather than
vice-versa. Reorder the flags so the warning suppression works.
Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
for pointing out what was wrong with the original patch.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Alex, is there a way to test this patch against Travis before
we commit it to master?
disas/libvixl/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/libvixl/Makefile.objs b/disas/libvixl/Makefile.objs
index d1e801a..bbe7695 100644
--- a/disas/libvixl/Makefile.objs
+++ b/disas/libvixl/Makefile.objs
@@ -6,6 +6,6 @@ libvixl_OBJS = vixl/utils.o \
# The -Wno-sign-compare is needed only for gcc 4.6, which complains about
# some signed-unsigned equality comparisons which later gcc versions do not.
-$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS)
+$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS) -Wno-sign-compare
common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings
2016-01-14 14:53 ` [Qemu-devel] " Peter Maydell
@ 2016-01-14 15:21 ` Alex Bennée
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2016-01-14 15:21 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, patches, qemu-arm, Franz-Josef Haider
Peter Maydell <peter.maydell@linaro.org> writes:
> Commit 8acc216b956 attempted to silence some sign-compare
> warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
> for the relevant objects. Unfortunately it was ineffective
> because it was placed before $(QEMU_CFLAGS), so the -Wall in
> the general flags overrode -Wno-sign-compare rather than
> vice-versa. Reorder the flags so the warning suppression works.
>
> Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
> for pointing out what was wrong with the original patch.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Alex, is there a way to test this patch against Travis before
> we commit it to master?
Mea culpa:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
and a conditional:
Tested-by: Alex Bennée <alex.bennee@linaro.org>
when:
https://travis-ci.org/stsquad/qemu/builds/102371704
completes.
>
> disas/libvixl/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disas/libvixl/Makefile.objs b/disas/libvixl/Makefile.objs
> index d1e801a..bbe7695 100644
> --- a/disas/libvixl/Makefile.objs
> +++ b/disas/libvixl/Makefile.objs
> @@ -6,6 +6,6 @@ libvixl_OBJS = vixl/utils.o \
>
> # The -Wno-sign-compare is needed only for gcc 4.6, which complains about
> # some signed-unsigned equality comparisons which later gcc versions do not.
> -$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS)
> +$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS) -Wno-sign-compare
>
> common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS)
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings
@ 2016-01-14 15:21 ` Alex Bennée
0 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2016-01-14 15:21 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-arm, Franz-Josef Haider, qemu-devel, patches
Peter Maydell <peter.maydell@linaro.org> writes:
> Commit 8acc216b956 attempted to silence some sign-compare
> warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
> for the relevant objects. Unfortunately it was ineffective
> because it was placed before $(QEMU_CFLAGS), so the -Wall in
> the general flags overrode -Wno-sign-compare rather than
> vice-versa. Reorder the flags so the warning suppression works.
>
> Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
> for pointing out what was wrong with the original patch.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Alex, is there a way to test this patch against Travis before
> we commit it to master?
Mea culpa:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
and a conditional:
Tested-by: Alex Bennée <alex.bennee@linaro.org>
when:
https://travis-ci.org/stsquad/qemu/builds/102371704
completes.
>
> disas/libvixl/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disas/libvixl/Makefile.objs b/disas/libvixl/Makefile.objs
> index d1e801a..bbe7695 100644
> --- a/disas/libvixl/Makefile.objs
> +++ b/disas/libvixl/Makefile.objs
> @@ -6,6 +6,6 @@ libvixl_OBJS = vixl/utils.o \
>
> # The -Wno-sign-compare is needed only for gcc 4.6, which complains about
> # some signed-unsigned equality comparisons which later gcc versions do not.
> -$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS)
> +$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS) -Wno-sign-compare
>
> common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS)
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings
2016-01-14 15:21 ` [Qemu-devel] " Alex Bennée
@ 2016-01-14 18:27 ` Peter Maydell
-1 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-01-14 18:27 UTC (permalink / raw)
To: Alex Bennée
Cc: QEMU Developers, Patch Tracking, qemu-arm, Franz-Josef Haider
On 14 January 2016 at 15:21, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> Commit 8acc216b956 attempted to silence some sign-compare
>> warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
>> for the relevant objects. Unfortunately it was ineffective
>> because it was placed before $(QEMU_CFLAGS), so the -Wall in
>> the general flags overrode -Wno-sign-compare rather than
>> vice-versa. Reorder the flags so the warning suppression works.
>>
>> Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
>> for pointing out what was wrong with the original patch.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> Alex, is there a way to test this patch against Travis before
>> we commit it to master?
>
> Mea culpa:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> and a conditional:
>
> Tested-by: Alex Bennée <alex.bennee@linaro.org>
>
> when:
>
> https://travis-ci.org/stsquad/qemu/builds/102371704
Test travis build completed OK, so I have pushed this fix to master.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings
@ 2016-01-14 18:27 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-01-14 18:27 UTC (permalink / raw)
To: Alex Bennée
Cc: qemu-arm, Franz-Josef Haider, QEMU Developers, Patch Tracking
On 14 January 2016 at 15:21, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> Commit 8acc216b956 attempted to silence some sign-compare
>> warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
>> for the relevant objects. Unfortunately it was ineffective
>> because it was placed before $(QEMU_CFLAGS), so the -Wall in
>> the general flags overrode -Wno-sign-compare rather than
>> vice-versa. Reorder the flags so the warning suppression works.
>>
>> Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
>> for pointing out what was wrong with the original patch.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> Alex, is there a way to test this patch against Travis before
>> we commit it to master?
>
> Mea culpa:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> and a conditional:
>
> Tested-by: Alex Bennée <alex.bennee@linaro.org>
>
> when:
>
> https://travis-ci.org/stsquad/qemu/builds/102371704
Test travis build completed OK, so I have pushed this fix to master.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-14 18:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-14 14:53 [PATCH] disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings Peter Maydell
2016-01-14 14:53 ` [Qemu-devel] " Peter Maydell
2016-01-14 15:21 ` Alex Bennée
2016-01-14 15:21 ` [Qemu-devel] " Alex Bennée
2016-01-14 18:27 ` Peter Maydell
2016-01-14 18:27 ` [Qemu-devel] " Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.