All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Peter Oh <poh@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Peter Oh <poh@qca.qualcomm.com>,
	Zefir Kurtisi <zefir.kurtisi@neratec.com>
Subject: Re: [PATCH] ath: use PRI value given by spec for fixed PRI
Date: Wed, 15 Apr 2015 15:41:58 +0300	[thread overview]
Message-ID: <87fv817ecp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <551C5C51.8010109@codeaurora.org> (Peter Oh's message of "Wed, 01 Apr 2015 14:00:01 -0700")

Peter Oh <poh@codeaurora.org> writes:

>> As for your patch at hand, I tested it for ETSI and it does not
>> change detector performance,
>
> The patch is useful when there are many missing pulses within a burst.
> It happens almost every time when channel loading rate is higher than
> 40%, but around 30% channel loading does not miss pulses that much.
>
>> therefore (please replace 16 with PRI_TOLERANCE in the macro)
>
> I'll do.
>
>> Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>

So what's the conclusion? Should I wait for v2 or is this good to
commit? I didn't quite get Zefir's comment about PRI_TOLERANCE above.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Peter Oh <poh@codeaurora.org>
Cc: Zefir Kurtisi <zefir.kurtisi@neratec.com>,
	Peter Oh <poh@qca.qualcomm.com>, <ath10k@lists.infradead.org>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath: use PRI value given by spec for fixed PRI
Date: Wed, 15 Apr 2015 15:41:58 +0300	[thread overview]
Message-ID: <87fv817ecp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <551C5C51.8010109@codeaurora.org> (Peter Oh's message of "Wed, 01 Apr 2015 14:00:01 -0700")

Peter Oh <poh@codeaurora.org> writes:

>> As for your patch at hand, I tested it for ETSI and it does not
>> change detector performance,
>
> The patch is useful when there are many missing pulses within a burst.
> It happens almost every time when channel loading rate is higher than
> 40%, but around 30% channel loading does not miss pulses that much.
>
>> therefore (please replace 16 with PRI_TOLERANCE in the macro)
>
> I'll do.
>
>> Acked-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>

So what's the conclusion? Should I wait for v2 or is this good to
commit? I didn't quite get Zefir's comment about PRI_TOLERANCE above.

-- 
Kalle Valo

  reply	other threads:[~2015-04-15 12:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 16:59 [PATCH] ath: use PRI value given by spec for fixed PRI Peter Oh
2015-03-27 16:59 ` Peter Oh
2015-03-30  9:55 ` Zefir Kurtisi
2015-03-30  9:55   ` Zefir Kurtisi
2015-03-30 17:57   ` Peter Oh
2015-03-30 17:57     ` Peter Oh
2015-04-01 10:04     ` Zefir Kurtisi
2015-04-01 10:04       ` Zefir Kurtisi
2015-04-01 21:00       ` Peter Oh
2015-04-01 21:00         ` Peter Oh
2015-04-15 12:41         ` Kalle Valo [this message]
2015-04-15 12:41           ` Kalle Valo
2015-04-15 17:10           ` Peter Oh
2015-04-15 17:10             ` Peter Oh
2015-09-03 18:04       ` Peter Oh
2015-09-03 18:04         ` Peter Oh
2015-09-04 10:55         ` Zefir Kurtisi
2015-09-04 10:55           ` Zefir Kurtisi
2015-09-04 12:55           ` Kalle Valo
2015-09-04 12:55             ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fv817ecp.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=poh@codeaurora.org \
    --cc=poh@qca.qualcomm.com \
    --cc=zefir.kurtisi@neratec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.