From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: improve vdev map handling.
Date: Fri, 16 May 2014 16:18:11 +0300 [thread overview]
Message-ID: <87fvk96ewc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1398882179-17100-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Wed, 30 Apr 2014 11:22:59 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Check vdev map has space before calling ffs,
> fix invalid cleanup in failure to create vdev
> case.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Why? What motivated you to write this? If you saw a bug, it would be
good to document the bug in the commit log.
> This is compile-tested only.
It's two weeks since you posted this, sorry for taking so long. But have
you managed to test this by now?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: improve vdev map handling.
Date: Fri, 16 May 2014 16:18:11 +0300 [thread overview]
Message-ID: <87fvk96ewc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1398882179-17100-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Wed, 30 Apr 2014 11:22:59 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Check vdev map has space before calling ffs,
> fix invalid cleanup in failure to create vdev
> case.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Why? What motivated you to write this? If you saw a bug, it would be
good to document the bug in the commit log.
> This is compile-tested only.
It's two weeks since you posted this, sorry for taking so long. But have
you managed to test this by now?
--
Kalle Valo
next prev parent reply other threads:[~2014-05-16 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 18:22 [PATCH] ath10k: improve vdev map handling greearb
2014-04-30 18:22 ` greearb
2014-05-16 13:18 ` Kalle Valo [this message]
2014-05-16 13:18 ` Kalle Valo
2014-05-16 13:26 ` Ben Greear
2014-05-16 13:26 ` Ben Greear
2014-05-16 13:37 ` Kalle Valo
2014-05-16 13:37 ` Kalle Valo
2014-05-16 14:01 ` Ben Greear
2014-05-16 14:01 ` Ben Greear
2014-05-16 14:06 ` Kalle Valo
2014-05-16 14:06 ` Kalle Valo
2014-05-16 14:11 ` Ben Greear
2014-05-16 14:11 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvk96ewc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.