From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 4/7] ath10k: wake up everything on core restart
Date: Thu, 15 May 2014 16:21:18 +0300 [thread overview]
Message-ID: <87fvkb89f5.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1399638957-20449-5-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 9 May 2014 14:35:54 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> It makes sense to finish completions as they may
> be waited for while holding conf_mutex thus
> delaying hw restart.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
> drivers/net/wireless/ath/ath10k/core.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 3f4d28f..bf7c323 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -709,6 +709,18 @@ void ath10k_core_restart(struct ath10k *ar)
> spin_lock_bh(&ar->data_lock);
> ar->wmi.drop = true;
> wake_up(&ar->wmi.tx_credits_wq);
> +
> + complete(&ar->target_suspend);
> + complete(&ar->debug.event_stats_compl);
We dropped this patchset already, but for the future, this patch
introduces a new warning:
drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_core_restart':
>> drivers/net/wireless/ath/ath10k/core.c:714:14: error: 'struct ath10k'
>> has no member named 'debug'
complete(&ar->debug.event_stats_compl);
^
Maybe that complete call should be in debug.c?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/7] ath10k: wake up everything on core restart
Date: Thu, 15 May 2014 16:21:18 +0300 [thread overview]
Message-ID: <87fvkb89f5.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1399638957-20449-5-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 9 May 2014 14:35:54 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> It makes sense to finish completions as they may
> be waited for while holding conf_mutex thus
> delaying hw restart.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
> drivers/net/wireless/ath/ath10k/core.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 3f4d28f..bf7c323 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -709,6 +709,18 @@ void ath10k_core_restart(struct ath10k *ar)
> spin_lock_bh(&ar->data_lock);
> ar->wmi.drop = true;
> wake_up(&ar->wmi.tx_credits_wq);
> +
> + complete(&ar->target_suspend);
> + complete(&ar->debug.event_stats_compl);
We dropped this patchset already, but for the future, this patch
introduces a new warning:
drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_core_restart':
>> drivers/net/wireless/ath/ath10k/core.c:714:14: error: 'struct ath10k'
>> has no member named 'debug'
complete(&ar->debug.event_stats_compl);
^
Maybe that complete call should be in debug.c?
--
Kalle Valo
next prev parent reply other threads:[~2014-05-15 13:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 12:35 [PATCH 0/7] ath10k: recovery improvements 2014-05-09 Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-09 12:35 ` [PATCH 1/7] ath10k: move restart_work call Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-09 12:35 ` [PATCH 2/7] ath10k: introduce core restart symbol Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-09 12:35 ` [PATCH 3/7] ath10k: drain wmi quickly upon hw restart Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-09 12:35 ` [PATCH 4/7] ath10k: wake up everything on core restart Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-15 13:21 ` Kalle Valo [this message]
2014-05-15 13:21 ` Kalle Valo
2014-05-19 6:17 ` Michal Kazior
2014-05-19 6:17 ` Michal Kazior
2014-05-09 12:35 ` [PATCH 5/7] ath10k: reduce timeout values Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-09 12:35 ` [PATCH 6/7] ath10k: make wmi timeout trigger hw restart Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-09 12:35 ` [PATCH 7/7] ath10k: remove old unused defines Michal Kazior
2014-05-09 12:35 ` Michal Kazior
2014-05-12 7:34 ` [PATCH 0/7] ath10k: recovery improvements 2014-05-09 Michal Kazior
2014-05-12 7:34 ` Michal Kazior
2014-05-14 13:34 ` Kalle Valo
2014-05-14 13:34 ` Kalle Valo
2014-05-14 13:43 ` Michal Kazior
2014-05-14 13:43 ` Michal Kazior
2014-05-14 13:54 ` Kalle Valo
2014-05-14 13:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvkb89f5.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.