Re: [Qemu-devel] [PATCH 7/8] trace: [simple] Bump up log version number

["Lluís Vilanova" <vilanova@ac.upc.edu>]

Stefan Hajnoczi writes:

> On Sun, Feb 23, 2014 at 08:37:35PM +0100, Lluís Vilanova wrote:
>> The following tracetool cleanup changes the event numbering policy.
>> 
>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>> ---
>> scripts/simpletrace.py |   10 +++++-----
>> trace/simple.c         |    2 +-
>> 2 files changed, 6 insertions(+), 6 deletions(-)

> I would also like to add a change to the simpletrace binary format.  The
> 32-bit reserved field will take the pid of QEMU.  I will also submit a
> SystemTap script that produces simpletrace binary format output - this
> allows us to produce simpletrace-compatible data with a QEMU binary that
> only has SystemTap support.  Since SystemTap is global it sees all QEMU
> processes and we need to distinguish between them using the pid.

> Your series will be merged into qemu.git at the start of the QEMU 2.1
> release cycle.  My patch can follow during the release cycle.  End-users
> will not see the changes until QEMU 2.1 is released.

Sounds excellent, but note that I also wrote a patch for multi-backend tracing
based on Kazuya's idea (must be applied on top of this series). Not sure if that
would influence your decision about SystemTap's format (since you could then
have both compiled into QEMU).

I will later send the latest version (rebased on this series).


Thanks,
  Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth