All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary
Date: Fri, 31 Jan 2014 08:42:22 +0100	[thread overview]
Message-ID: <87fvo4y4v5.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <52EA8866.6050302@suse.de> ("Andreas Färber"'s message of "Thu, 30 Jan 2014 18:14:14 +0100")

Andreas Färber <afaerber@suse.de> writes:

> Am 30.01.2014 15:07, schrieb Markus Armbruster:
>> error_is_set(&var) is the same as var != NULL, but it takes
>> whole-program analysis to figure that out.  Unnecessarily hard for
>> optimizers, static checkers, and human readers.  Dumb it down to
>> obvious.
>> 
>> Gets rid of several dozen Coverity false positives.
>> 
>> Note that the obvious form is already used in many places.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks!

> I don't suppose you used a Coccinelle script that we could re-run in the
> future? ;)

Perhaps I should've, but since the job was simple enough for
M-x tags-query-replace...

> Via QMP queue?

Yes, please.

  reply	other threads:[~2014-01-31  7:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 14:07 [Qemu-devel] [PATCH] Use error_is_set() only when necessary Markus Armbruster
2014-01-30 15:45 ` Eric Blake
2014-01-30 16:02   ` Markus Armbruster
2014-01-30 17:14 ` Andreas Färber
2014-01-31  7:42   ` Markus Armbruster [this message]
2014-02-10 20:54 ` Luiz Capitulino
2014-02-11  1:24   ` Fam Zheng
2014-02-11  8:25     ` Markus Armbruster
2014-02-21 11:01 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvo4y4v5.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.