[PATCH] trivial: support cscope in Makefile and gitignore

[PATCH] trivial: support cscope in Makefile and gitignore

[Hitoshi Mitake]

After applying this patch, "make cscope" can generate cscope files for
tag jump. The generated files are ignored by the .gitignore file.

Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
---
 .gitignore |    3 ++-
 Makefile   |    5 +++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index ca1c5d3..8c28cb7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,4 +31,5 @@ usr/tgtd
 usr/tgtadm
 usr/tgtimg
 
-
+# cscope files
+cscope.*
diff --git a/Makefile b/Makefile
index b71ad7b..ad1f12f 100644
--- a/Makefile
+++ b/Makefile
@@ -93,3 +93,8 @@ check32:
 check64: override ARCH=-m64
 check64:
 	CC=$(CHECK_CC_FLAGS) $(MAKE) all
+
+cscope:
+	find -name '*.[ch]' > cscope.files
+	cscope -bq
+
-- 
1.7.10.4

Re: [PATCH] trivial: support cscope in Makefile and gitignore

[Hitoshi Mitake]

At Tue, 29 Oct 2013 11:28:52 +0900,
Hitoshi Mitake wrote:
> 
> After applying this patch, "make cscope" can generate cscope files for
> tag jump. The generated files are ignored by the .gitignore file.
> 
> Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> ---
>  .gitignore |    3 ++-
>  Makefile   |    5 +++++
>  2 files changed, 7 insertions(+), 1 deletion(-)

ping? This is a trivial one, but would be useful for tgt developers.

Thanks,
Hitoshi

> 
> diff --git a/.gitignore b/.gitignore
> index ca1c5d3..8c28cb7 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -31,4 +31,5 @@ usr/tgtd
>  usr/tgtadm
>  usr/tgtimg
>  
> -
> +# cscope files
> +cscope.*
> diff --git a/Makefile b/Makefile
> index b71ad7b..ad1f12f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -93,3 +93,8 @@ check32:
>  check64: override ARCH=-m64
>  check64:
>  	CC=$(CHECK_CC_FLAGS) $(MAKE) all
> +
> +cscope:
> +	find -name '*.[ch]' > cscope.files
> +	cscope -bq
> +
> -- 
> 1.7.10.4
> 

Re: [PATCH] trivial: support cscope in Makefile and gitignore

[FUJITA Tomonori]

On Sun, 24 Nov 2013 23:23:02 +0900
Hitoshi Mitake <mitake.hitoshi@gmail.com> wrote:

> At Tue, 29 Oct 2013 11:28:52 +0900,
> Hitoshi Mitake wrote:
> > 
> > After applying this patch, "make cscope" can generate cscope files for
> > tag jump. The generated files are ignored by the .gitignore file.
> > 
> > Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> > ---
> >  .gitignore |    3 ++-
> >  Makefile   |    5 +++++
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> ping? This is a trivial one, but would be useful for tgt developers.

Can you fix the following warning?

/home/fujita/git/tgt/.git/rebase-apply/patch:21: new blank line at
EOF.
+
warning: 1 line adds whitespace errors.

I don't fancy to add a particular source code tool stuff for Makefile
much though (I don't use cscope).

Re: [PATCH] trivial: support cscope in Makefile and gitignore

[Hitoshi Mitake]

At Mon, 25 Nov 2013 04:29:57 +0900,
FUJITA Tomonori wrote:
> 
> On Sun, 24 Nov 2013 23:23:02 +0900
> Hitoshi Mitake <mitake.hitoshi@gmail.com> wrote:
> 
> > At Tue, 29 Oct 2013 11:28:52 +0900,
> > Hitoshi Mitake wrote:
> > > 
> > > After applying this patch, "make cscope" can generate cscope files for
> > > tag jump. The generated files are ignored by the .gitignore file.
> > > 
> > > Signed-off-by: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
> > > ---
> > >  .gitignore |    3 ++-
> > >  Makefile   |    5 +++++
> > >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > ping? This is a trivial one, but would be useful for tgt developers.
> 
> Can you fix the following warning?
> 
> /home/fujita/git/tgt/.git/rebase-apply/patch:21: new blank line at
> EOF.
> +
> warning: 1 line adds whitespace errors.

Sorry for the style warning. I'll send v2 later.

Thanks,
Hitoshi