All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: "David S. Miller" <davem@davemloft.net>,
	Rusty Russel <rusty@ruscorp.com.au>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
	netdev <netdev@vger.kernel.org>,
	Erwan Yvin <erwan.yvin@stericsson.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	Sjur Braendeland <sjur.brandeland@stericsson.com>
Subject: Re: [PATCHv3 vringh] caif_virtio: Introduce caif over virtio
Date: Mon, 18 Mar 2013 14:16:17 +1030	[thread overview]
Message-ID: <87fvzts73q.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1363340537-16011-1-git-send-email-erwan.yvin@stericsson.com>

Erwan Yvin <erwan.yvin@stericsson.com> writes:
> From: Erwan Yvin <erwan.yvin@stericsson.com>
>
> Add the CAIF Virtio shared memory driver for talking
> to a modem.

I've added a minor build fix:

caif_virtio: fix compilation

ERROR: "gen_pool_add_virt" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_create" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_destroy" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_free" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_alloc" [drivers/net/caif/caif_virtio.ko] undefined!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/drivers/net/caif/Kconfig b/drivers/net/caif/Kconfig
index 676cfff..893f915 100644
--- a/drivers/net/caif/Kconfig
+++ b/drivers/net/caif/Kconfig
@@ -53,6 +53,7 @@ config CAIF_VIRTIO
 	depends on CAIF
 	select VHOST_RING
 	select VIRTIO
+	select GENERIC_ALLOCATOR
 	default n
 	---help---
 	The caif driver for CAIF over Virtio.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Erwan Yvin <erwan.yvin@stericsson.com>,
	"David S. Miller" <davem@davemloft.net>,
	Rusty Russel <rusty@ruscorp.com.au>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
	netdev <netdev@vger.kernel.org>,
	Erwan Yvin <erwan.yvin@stericsson.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	Sjur Braendeland <sjur.brandeland@stericsson.com>
Subject: Re: [PATCHv3 vringh] caif_virtio: Introduce caif over virtio
Date: Mon, 18 Mar 2013 14:16:17 +1030	[thread overview]
Message-ID: <87fvzts73q.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1363340537-16011-1-git-send-email-erwan.yvin@stericsson.com>

Erwan Yvin <erwan.yvin@stericsson.com> writes:
> From: Erwan Yvin <erwan.yvin@stericsson.com>
>
> Add the CAIF Virtio shared memory driver for talking
> to a modem.

I've added a minor build fix:

caif_virtio: fix compilation

ERROR: "gen_pool_add_virt" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_create" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_destroy" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_free" [drivers/net/caif/caif_virtio.ko] undefined!
ERROR: "gen_pool_alloc" [drivers/net/caif/caif_virtio.ko] undefined!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/drivers/net/caif/Kconfig b/drivers/net/caif/Kconfig
index 676cfff..893f915 100644
--- a/drivers/net/caif/Kconfig
+++ b/drivers/net/caif/Kconfig
@@ -53,6 +53,7 @@ config CAIF_VIRTIO
 	depends on CAIF
 	select VHOST_RING
 	select VIRTIO
+	select GENERIC_ALLOCATOR
 	default n
 	---help---
 	The caif driver for CAIF over Virtio.

  parent reply	other threads:[~2013-03-18  3:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15  9:42 [PATCHv3 vringh] caif_virtio: Introduce caif over virtio Erwan Yvin
2013-03-17 16:14 ` David Miller
2013-03-18  3:38   ` Rusty Russell
2013-03-18  3:38   ` Rusty Russell
2013-03-17 16:14 ` David Miller
2013-03-17 22:52 ` Ohad Ben-Cohen
2013-03-18  3:45   ` Rusty Russell
2013-03-18  3:45   ` Rusty Russell
2013-03-17 22:52 ` Ohad Ben-Cohen
2013-03-18  3:46 ` Rusty Russell [this message]
2013-03-18  3:46   ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2013-03-15  9:42 Erwan Yvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvzts73q.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=davem@davemloft.net \
    --cc=erwan.yvin@stericsson.com \
    --cc=linus.walleij@stericsson.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@ruscorp.com.au \
    --cc=sjur.brandeland@stericsson.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.