All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Mike Turquette <mturquette@ti.com>
Cc: paul@pwsan.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Mike Turquette <mturquette@linaro.org>
Subject: Re: [RFC][PATCH 0/5] Introduce .get_voltage callback into voltdm
Date: Fri, 26 Oct 2012 11:17:51 -0700	[thread overview]
Message-ID: <87fw51hzcg.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1349313365-5262-1-git-send-email-mturquette@ti.com> (Mike Turquette's message of "Wed, 3 Oct 2012 18:16:00 -0700")

Hi Mike,

Mike Turquette <mturquette@ti.com> writes:

> From: Mike Turquette <mturquette@linaro.org>
>
> This series creates a new callback for struct voltagedomain,
> .get_voltage.  This fetches the voltage from hardware, if possible, and
> returns it to the caller.  We use this call to populate
> voltdm->nominal_volt at boot time.

I pointed out a couple nitpicky things on individual patches, but
otherwise this direction and motiviation for this series looks OK by me.

Just some minor comments about the structure of the series.  I tend to
prefer combining the introduction of a new function with it's usage.  It
makes review and understanding much easier, IMO.  If there are reasons
to keep them separate, that's fine too.  Just describe the reasons in
the cover letter.

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 0/5] Introduce .get_voltage callback into voltdm
Date: Fri, 26 Oct 2012 11:17:51 -0700	[thread overview]
Message-ID: <87fw51hzcg.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1349313365-5262-1-git-send-email-mturquette@ti.com> (Mike Turquette's message of "Wed, 3 Oct 2012 18:16:00 -0700")

Hi Mike,

Mike Turquette <mturquette@ti.com> writes:

> From: Mike Turquette <mturquette@linaro.org>
>
> This series creates a new callback for struct voltagedomain,
> .get_voltage.  This fetches the voltage from hardware, if possible, and
> returns it to the caller.  We use this call to populate
> voltdm->nominal_volt at boot time.

I pointed out a couple nitpicky things on individual patches, but
otherwise this direction and motiviation for this series looks OK by me.

Just some minor comments about the structure of the series.  I tend to
prefer combining the introduction of a new function with it's usage.  It
makes review and understanding much easier, IMO.  If there are reasons
to keep them separate, that's fine too.  Just describe the reasons in
the cover letter.

Thanks,

Kevin

  parent reply	other threads:[~2012-10-26 18:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04  1:16 [RFC][PATCH 0/5] Introduce .get_voltage callback into voltdm Mike Turquette
2012-10-04  1:16 ` Mike Turquette
2012-10-04  1:16 ` [PATCH 1/5] ARM: omap: vc: replace data_shift with data_mask Mike Turquette
2012-10-04  1:16   ` Mike Turquette
2012-10-26 17:27   ` Kevin Hilman
2012-10-26 17:27     ` Kevin Hilman
2012-10-04  1:16 ` [PATCH 2/5] ARM: omap: introduce .get_voltage callback Mike Turquette
2012-10-04  1:16   ` Mike Turquette
2012-10-04  1:16 ` [PATCH 3/5] ARM: omap: vc: " Mike Turquette
2012-10-04  1:16   ` Mike Turquette
2012-10-26 18:13   ` Kevin Hilman
2012-10-26 18:13     ` Kevin Hilman
2012-10-04  1:16 ` [PATCH 4/5] ARM: omap: vp: " Mike Turquette
2012-10-04  1:16   ` Mike Turquette
2012-10-04  1:16 ` [PATCH 5/5] ARM: omap: initialize voltdm->nominal_volt Mike Turquette
2012-10-04  1:16   ` Mike Turquette
2012-10-26 18:17 ` Kevin Hilman [this message]
2012-10-26 18:17   ` [RFC][PATCH 0/5] Introduce .get_voltage callback into voltdm Kevin Hilman
2012-10-26 19:40   ` Mike Turquette
2012-10-26 19:40     ` Mike Turquette
2013-03-31  2:35 ` Paul Walmsley
2013-03-31  2:35   ` Paul Walmsley
2013-04-01 21:56   ` Mike Turquette
2013-04-01 21:56     ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw51hzcg.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=mturquette@ti.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.