From: Kevin Hilman <khilman@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: PRM: fix compile for OMAP4-only build
Date: Thu, 05 Apr 2012 17:07:31 -0700 [thread overview]
Message-ID: <87fwchhge4.fsf@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204051533110.10302@utopia.booyaka.com> (Paul Walmsley's message of "Thu, 5 Apr 2012 15:33:32 -0600 (MDT)")
Paul Walmsley <paul@pwsan.com> writes:
> On Thu, 5 Apr 2012, Kevin Hilman wrote:
>
>> For OMAP4 only builds, the omap2_prm_* functions have dummy wrappers
>> to detect incorrect usage. However, several unrelated omap3 PRM
>> functions have made it inside the #else clause of the #ifdef wrapping
>> the omap2_prm stubs, causing them to disappear on OMAP4-only builds.
>>
>> This was unnoticed until the IO chain support was added and introduced
>> a new function in this section which is referenced by omap_hwmod.c:
>>
>> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c: In function '_reconfigure_io_chain':
>> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c:1665:3: error: implicit declaration of function 'omap3xxx_prm_reconfigure_io_chain' [-Werror=implicit-fungiction-declaration]
>>
>> Fix by using the #ifdef to only wrap the omap2_prm functions that
>> need stubs on OMAP4-only builds.
>>
>> Cc: Paul Walmsley <paul@pwsan.com>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>> ---
>> Paul, this patch applies on top your io_chain_devel_3.5 branch.
>
> Thanks, Tony reported this too. Any objections to me rolling this into
> the offending patch?
No objections.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: PRM: fix compile for OMAP4-only build
Date: Thu, 05 Apr 2012 17:07:31 -0700 [thread overview]
Message-ID: <87fwchhge4.fsf@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204051533110.10302@utopia.booyaka.com> (Paul Walmsley's message of "Thu, 5 Apr 2012 15:33:32 -0600 (MDT)")
Paul Walmsley <paul@pwsan.com> writes:
> On Thu, 5 Apr 2012, Kevin Hilman wrote:
>
>> For OMAP4 only builds, the omap2_prm_* functions have dummy wrappers
>> to detect incorrect usage. However, several unrelated omap3 PRM
>> functions have made it inside the #else clause of the #ifdef wrapping
>> the omap2_prm stubs, causing them to disappear on OMAP4-only builds.
>>
>> This was unnoticed until the IO chain support was added and introduced
>> a new function in this section which is referenced by omap_hwmod.c:
>>
>> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c: In function '_reconfigure_io_chain':
>> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c:1665:3: error: implicit declaration of function 'omap3xxx_prm_reconfigure_io_chain' [-Werror=implicit-fungiction-declaration]
>>
>> Fix by using the #ifdef to only wrap the omap2_prm functions that
>> need stubs on OMAP4-only builds.
>>
>> Cc: Paul Walmsley <paul@pwsan.com>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>> ---
>> Paul, this patch applies on top your io_chain_devel_3.5 branch.
>
> Thanks, Tony reported this too. Any objections to me rolling this into
> the offending patch?
No objections.
Kevin
next prev parent reply other threads:[~2012-04-06 0:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 21:20 [PATCH] ARM: OMAP2+: PRM: fix compile for OMAP4-only build Kevin Hilman
2012-04-05 21:20 ` Kevin Hilman
2012-04-05 21:33 ` Paul Walmsley
2012-04-05 21:33 ` Paul Walmsley
2012-04-05 22:53 ` Tony Lindgren
2012-04-05 22:53 ` Tony Lindgren
2012-04-05 23:37 ` Paul Walmsley
2012-04-05 23:37 ` Paul Walmsley
2012-04-06 0:07 ` Kevin Hilman [this message]
2012-04-06 0:07 ` Kevin Hilman
2012-04-09 16:51 ` Paul Walmsley
2012-04-09 16:51 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwchhge4.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.